1. 18 Nov, 2018 1 commit
  2. 17 Nov, 2018 2 commits
  3. 15 Nov, 2018 1 commit
  4. 14 Nov, 2018 2 commits
  5. 10 Nov, 2018 1 commit
  6. 07 Nov, 2018 2 commits
  7. 06 Nov, 2018 5 commits
  8. 31 Oct, 2018 3 commits
    • Kevin J. McCarthy's avatar
      Always print mutt_buffer_pool_free() size debug output. · e6059484
      Kevin J. McCarthy authored
      So I can easily see the resulting size of the pool at the end of a
      run.
      e6059484
    • Kevin J. McCarthy's avatar
      Add a flag for dynamic date range evaluation in patterns. · 5de55f85
      Kevin J. McCarthy authored
      By default, Mutt evaluates relative date patterns, such as "~d<1d"
      against the date when the pattern is compiled.
      
      For index-format-hook, we need to pattern match against a message
      based on the current date/time, so that for example, conditional date
      format patterns correctly match after Mutt has been open for many
      days/weeks.
      
      Add a flag, MUTT_PATTERN_DYNAMIC, that changes ~d and ~r evaluation to
      reevaluate the min/max range with each match.
      
      This will of course be slower, but for the index, where a screenful of
      messages at a time are evaluated, is an acceptable tradeoff against
      accurate pattern matching.
      5de55f85
    • Kevin J. McCarthy's avatar
      Add index-format-hook and expando. · 7ebb6205
      Kevin J. McCarthy authored
      index-format-hook is used to allow dynamic insertion/evaluation of
      format strings into $index_format.
      
      It can be used, for example, to implement date formatting based on the
      age of the message.
      
      Add a new %@name@ expando to $index_format, which evaluates the
      matching index-format-hooks with "name".
      7ebb6205
  9. 30 Oct, 2018 1 commit
  10. 23 Oct, 2018 1 commit
    • Peter Wu's avatar
      Fix memleaks of saslconn on error paths · 7c6d3851
      Peter Wu authored
      If mutt_sasl_client_new returns an error, the callers would ignore the
      allocated saslconn resource from sasl_client_new. Be sure to release
      these with sasl_dispose as documented in sasl.h. Likewise, let callers
      (POP/IMAP) dispose the resource on their error paths. SMTP was already
      taken care of. Found with LeakSanitizer in IMAP.
      7c6d3851
  11. 17 Oct, 2018 2 commits
    • Kevin J. McCarthy's avatar
      Minor syntactic cleanup in mutt_print_attachment(). · 420226ce
      Kevin J. McCarthy authored
      Converting a return to a rc assignment accidentally left an extra
      parenthesis.
      420226ce
    • Kevin J. McCarthy's avatar
      Ensure a resized empty buffer is null-terminated. · 42481bda
      Kevin J. McCarthy authored
      The new buffer code is using the pool, which ensures its buffers are
      null-terminated.
      
      However, if a "new" buffer from another part of the code were passed
      to one of the temporary interfaces that resizes the buffer, it's
      possible a non-terminated string might end up being passed through.
      
      It's reasonable to expect mutt_b2s() for a "new" buffer should be the
      same as after it is resized larger.  So ensure the resulting buf->data
      is properly terminated to avoid surprises.
      42481bda
  12. 16 Oct, 2018 1 commit
    • Kevin J. McCarthy's avatar
      Remove conversion of nbsp to space. · dd1e0ea4
      Kevin J. McCarthy authored
      Keep the behavior of it not line-breaking, but don't change it to a
      space character when displaying.  This is so copy-paste from the pager
      will preserve the nbsp, which is semantically important in some
      locales.
      dd1e0ea4
  13. 15 Oct, 2018 8 commits
  14. 11 Oct, 2018 1 commit
    • Kevin J. McCarthy's avatar
      Convert the rest of mh.c to use BUFFER for file paths. · b231f15a
      Kevin J. McCarthy authored
        * mh_read_sequences
        * mh_sequences_changed
        * mh_already_notified
        * mh_mkstemp
        * mh_update_sequences
        * mh_sequences_add_one
        * maildir_update_time
        * maildir_delayed_parsing
        * maildir_open_mailbox_append
        * mh_open_mailbox_append
        * maildir_mh_open_message
        * maildir_open_new_message
        * _mh_commit_message
        * mh_rewrite_message
        * mh_sync_mailbox
        * mh_check_mailbox
        * maildir_check_empty
        * mx_is_maildir
        * mx_is_mh()
      b231f15a
  15. 10 Oct, 2018 1 commit
  16. 09 Oct, 2018 2 commits
    • Kevin J. McCarthy's avatar
      Change gnutls certificate_file processing and interactive prompts. · d6581efc
      Kevin J. McCarthy authored
      Accept a saved cert at any point in the chain, except for those
      revoked or with invalid dates.
      
      The INSECUREALG processing was a bit goofed up.  It was skipping the
      prompt for every chain except the host, and was only displaying an
      error for entry 1 (the host being 0, root being len-1).  Instead
      prompt at any point, and display a warning as with the other errors.
      
      Add a CERTERR_OTHER type to capture other bits.  Recently GnuTLS has
      added additional certificate_status_t types.  We may want to improve
      the prompts in the future for those, but for now at least make sure
      it's recorded in certerr.
      d6581efc
    • Kevin J. McCarthy's avatar
      Fix gnutls (a)lways to properly save for all certerr values. · ea1ea1e5
      Kevin J. McCarthy authored
      For the case of SIGNERNOTCA, INSECUREALG, or a newer unhandled value,
      the "(a)ccept always" prompt was allowed, but the cert saving was
      prevented by a check only against NOTTRUSTED.  This ended up giving a
      strange error message saying the cert was not saved.
      
      Fix to save the cert for all errors except HOSTNAME (which is handled
      separately).
      ea1ea1e5
  17. 08 Oct, 2018 6 commits