1. 17 Jan, 2019 1 commit
    • Muh Muhten's avatar
      Add attributes support on color declarations · 8117a33e
      Muh Muhten authored
      color now accepts zero or more attributes words before the foreground.
      
      Also more or less resolves the issue that setting the color of an object
      which defaults to underline/reverse is irreversible.
      8117a33e
  2. 10 Jan, 2019 2 commits
  3. 08 Jan, 2019 6 commits
  4. 05 Jan, 2019 5 commits
    • Eike Rathke's avatar
      Fix mkdtemp() random signedness · 9b965fac
      Eike Rathke authored
      time_t return of time() may be signed 32-bit and in that case
      probably will roll over in the year 2038 and yield a negative
      value; signedness was propagated in the XOR operation to the
      'value' and then 'v' variables. The 'v % 62' operation then would
      had resulted in a negative value and LETTER[v%62] would had
      accessed an arbitrary data location.
      
      The same could had happened if the static long 'value' variable
      after a very long run time contained a sufficiently large value to
      which the time^pid value added resulted in a wrap / roll-over to a
      negative value.
      
      Using unsigned long types for 'value' and 'v' and casting time_t
      to unsigned long cures all this.
      9b965fac
    • Kevin J. McCarthy's avatar
      Merge branch 'stable' · 9a3b8a7c
      Kevin J. McCarthy authored
      9a3b8a7c
    • Kevin J. McCarthy's avatar
      ae3587cf
    • Kevin J. McCarthy's avatar
      Fix a few indenting issues. · 177f12ac
      Kevin J. McCarthy authored
      These are mostly the result of making the formatting changes commit
      after the indent changes commit.
      177f12ac
    • Kevin J. McCarthy's avatar
      Clean up formatting. · efa3afb5
      Kevin J. McCarthy authored
      Add spaces after if, else, while, for, switch.
      
      Unify the brace placement style.  The vast majority of the code uses
      Allman style so convert the relatively few K&R braces over.
      efa3afb5
  5. 04 Jan, 2019 3 commits
    • Kevin J. McCarthy's avatar
      Clean up code indentation. · 248c2ee8
      Kevin J. McCarthy authored
      These are mostly automated changes corresponding to the emacs
      settings:
        (c-set-style "linux")
        (setq c-basic-offset 2)
        (c-set-offset 'case-label '+)
      
      Most of the code follows the convention:
        (add-to-list 'c-cleanup-list 'space-before-funcall)
      but this is not enforced by this indentation cleanup.
      
      Also, I personally dislike tabs, so I have:
        (setq-default indent-tabs-mode nil)
      in my own configuration.  However I have no desire to change every line
      just for that effect.  So this cleanup does nothing about the mix issue.
      
      Some of the secondary files (e.g. regex.c) have been skipped.
      
      I've also skipped crypt-gpgme.c, because I need to think about that
      file.  Werner Koch and the GnuPG team contributed most it, and it
      follows the Gnu indentation settings.  It should probably be made
      uniform with Mutt, but I don't want to discourage future GnuPG
      contribution to the file.
      
      I manually reverted a few unsightly cleanups, and added a few tweeks
      when I saw things that could be improved.
      248c2ee8
    • Kevin J. McCarthy's avatar
      Merge branch 'stable' · 085a6f74
      Kevin J. McCarthy authored
      085a6f74
    • Kevin J. McCarthy's avatar
      Fix mkdtemp.c implementation. · 853e48bf
      Kevin J. McCarthy authored
      Two statements were indented on the same line under a for statement.
      The second one would not be included in the loop, only being executed
      after the loop finishes.
      
      This is obviously an error, as it modifies the LETTERS entry being
      used.
      853e48bf
  6. 01 Jan, 2019 2 commits
  7. 31 Dec, 2018 2 commits
    • Kevin J. McCarthy's avatar
      Remove unused MUTT_FORMAT_MAKEPRINT flag. · 1c59c271
      Kevin J. McCarthy authored
      The code in mutt_FormatString() that was using it was commented out 19
      years ago.
      1c59c271
    • Kevin J. McCarthy's avatar
      Remove dead code. · 3aa8d8a0
      Kevin J. McCarthy authored
      Most of these have been "#if 0" out for 10-20 years.  Any utility in
      keeping them around is miniscule at this point.
      
      There are a few other "#if 0" in the code, but I've kept them for now.
      Some are utility functions that are not used, but I think still may
      have some documentation value.
      3aa8d8a0
  8. 29 Dec, 2018 10 commits
  9. 28 Dec, 2018 6 commits
  10. 27 Dec, 2018 2 commits
  11. 25 Dec, 2018 1 commit