1. 05 Dec, 2016 1 commit
  2. 25 Nov, 2016 1 commit
  3. 20 Nov, 2016 1 commit
  4. 08 Sep, 2016 1 commit
  5. 23 Oct, 2016 2 commits
    • Kevin J. McCarthy's avatar
      Fix pager segfault when lineInfo.chunks overflows. (closes #3888) · 783bdc60
      Kevin J. McCarthy authored
      The reporter had an html attachment with extremely long lines,
      combined with a color pattern of "color body default default ."
      This overflowed the lineInfo.chunks, causing a segfault.
      
      Abort the body color patterns if this happens.
      783bdc60
    • Kevin J. McCarthy's avatar
      Prevent an integer overflow in mutt_mktime() (closes #3880) · a1dcc55a
      Kevin J. McCarthy authored
      Check to make sure the year passed in isn't bigger than can be
      represented using time_t on the platform.
      
      Also add a (time_t) cast to an intermediate "years * 365" calculation
      to prevent an overflow there.
      
      Thanks to TAKAHASHI Tamotsu for his patch, and to Vincent Lefèvre for
      his improvement.  I merely took their code and commited it.
      a1dcc55a
  6. 17 Oct, 2016 1 commit
    • Kevin J. McCarthy's avatar
      Actually fix gpgme segfault in create_recipient_set(). · d710f26a
      Kevin J. McCarthy authored
      Changeset 6e44bfa16096 did not fix the segv.  (Sorry, I made the fix
      based off a report on IRC but didn't trigger the segv myself: it was
      caused by an out-of-tree patch).
      
      The actual problem was that the rset was only resized on a successful
      gpgme_get_key().  However, on error, the array still needs to be
      NULL-terminated before calling free_recipient_set().
      
      Move the resize so it always takes place.  This obviates the need for
      the NULL check added in 6e44bfa16096.
      d710f26a
  7. 16 Oct, 2016 2 commits
  8. 08 Oct, 2016 3 commits
  9. 04 Oct, 2016 1 commit
    • Kevin J. McCarthy's avatar
      Preserve forwarded attachment names in d_filename. · 0f245345
      Kevin J. McCarthy authored
      When forwarding an attachment with an non-ascii name, mutt_copy_body()
      mangles the filename when calling mutt_adv_mktemp.  Preserve
      the original attachment filename in d_filename.
      
      Remove the double copy of b->filename, which is a memory leak.
      0f245345
  10. 25 Sep, 2016 1 commit
    • Kevin J. McCarthy's avatar
      Reset invalid parsed received dates to 0. (closes #3878) · c160ca1d
      Kevin J. McCarthy authored
      The actual problem in the ticket would be solved by d3f31cf9239e (see
      #3798).  However there is still the bug that Mutt considers a
      (hdr->received != 0) to be set and usable, despite not checking the
      return value of mutt_parse_date().
      
      Change mutt_read_rfc822_header() to unset an invalid received value
      back to 0.  We don't do this inside mutt_read_rfc822_line() because
      that would cause the next received line to be parsed.
      c160ca1d
  11. 22 Sep, 2016 1 commit
    • Antonio Radici's avatar
      Mark some gpgme pgp menu keybinding translations as fuzzy. (closes #3874) · 1937b309
      Antonio Radici authored
      Some translations for crypt-gpgme.c are marked as fuzzy but the keybindings
      attached to these translations are not, this creates confusions for the users
      who see the english message but have the keybindings for a message in their own
      language available.
      
      As long as the translations are fuzzy, the keybindings should stay fuzzy.
      1937b309
  12. 21 Sep, 2016 1 commit
    • Kevin J. McCarthy's avatar
      Check for NULL mx_ops in mx.c · 038eacdb
      Kevin J. McCarthy authored
      Eike Rathke reported this happening when in an IMAP index view the
      underlying connection was terminated, ctx->mx_ops was NULL and thus
      accessing ctx->mx_ops->check segfaulted.
      
      Thanks also to Eike Rathke for the initial patch, for which I expanded
      the checks to other functions.
      038eacdb
  13. 20 Sep, 2016 1 commit
  14. 08 Sep, 2016 1 commit
  15. 06 Sep, 2016 1 commit
  16. 05 Sep, 2016 3 commits
  17. 03 Sep, 2016 1 commit
    • Kevin J. McCarthy's avatar
      Disable ~X when message scoring. (closes #3861) · 9934a76f
      Kevin J. McCarthy authored
      mutt_score_message() purposely passes a NULL context to
      mutt_pattern_exec().  The idea was to block slow patterns, and the
      scoring documentation notes this by saying:
      
        "For efficiency reasons, patterns which scan information not
        available in the index, such as ~b, ~B or ~h, may not be used"
      
      ~X needs the context to parse the messages (during message scoring at
      least), and thus isn't suitable for message scoring either.
      
      Block ~X from being used when the context is NULL.  Add ~X to the list
      of patterns noted as unusable in the message scoring documentation.
      9934a76f
  18. 02 Sep, 2016 1 commit
  19. 18 Aug, 2016 5 commits
  20. 15 Aug, 2016 3 commits
  21. 10 Aug, 2016 2 commits
  22. 09 Aug, 2016 2 commits
  23. 08 Aug, 2016 1 commit
    • Kevin J. McCarthy's avatar
      Clear pager position upon returning to the index menu. · 30c913c7
      Kevin J. McCarthy authored
      This fixes a bug where opening a message sometimes shows it scrolled
      down.
      
      The easiest way to trigger this is to open a long message in a mailbox
      with no new messages, scroll down, hit <next-new-then-unread> and then
      reopen the message.  The pager will "remember" the position and scroll
      down.  If you simply exit the message and re-enter it, the position is
      not saved.
      
      More annoyingly, once in a very great while I will open a new message
      and have the message scrolled down partway.  I believe this is due to
      OldHdr happening to point to the same address as the Header of the new
      message.
      
      This is somewhat easily triggered on a mailbox with one message, which
      you open, scroll down in, hit <next-new-then-unread> to exit, and then
      delete/sync.  In another mutt instance, copy the same messsage back to
      the mailbox, then open the message in the original mutt instance.  At
      least some of the time, the OldHdr pointer matches the new message,
      and so it opens scrolled down.
      
      This patch solves the problem by clearing the pager position once all
      redirections through the index menu are done.
      30c913c7
  24. 06 Aug, 2016 1 commit
  25. 05 Aug, 2016 2 commits