1. 06 Nov, 2018 1 commit
  2. 01 Jun, 2018 1 commit
  3. 23 Mar, 2018 1 commit
    • Kevin J. McCarthy's avatar
      Fix comparison of flags with multiple bits set. · 47e6c5aa
      Kevin J. McCarthy authored
      PGPENCRYPT, PGPKEY, SMIMEENCRYPT, and SMIMEOPAQUE are all combination
      flags, with multiple bits set.  In a few places these flags were
      bitwise-and'ed incorrectly: expecting a non-zero result to indicate
      all the bits in the flag were set.  Change those to explicitly compare
      the result against the original flag.
      47e6c5aa
  4. 11 Jan, 2018 1 commit
    • Kevin J. McCarthy's avatar
      Create pgp and s/mime default and sign_as key vars. (see #3983) · db252e61
      Kevin J. McCarthy authored
      The $postpone_encrypt and $(pgp/smime)_self_encrypt configuration
      variables have created a somewhat messier situation for users.  Many
      of them now have to specify their keys across multiple configuration
      variables.
      
      (Trac) Ticket #3983 had a reasonable request: "if my encrypt and
      signing keys are the same, why can't I just specify my key once in my
      .muttrc?"
      
      The problem currently is that $smime_default_key and $pgp_sign_as are
      both used to specify signing keys, and are set by the "sign (a)s"
      security menu choice.  So we can't store encryption keys there because
      some users have separate sign-only capability keys.
      
      Create $pgp_default_key to store the default encryption key.  Change
      signing to use $pgp_default_key, unless overridden by $pgp_sign_as.
      The pgp "sign (a)s" will continue setting $pgp_sign_as.
      
      Create $smime_sign_as.  Change signing to use $smime_default_key
      unless overridden by $smime_sign_as.  Change s/mime "sign (a)s" menu
      to set $smime_sign_as instead.
      
      Change $postpone_encrypt and $(pgp/smime)_self_encrypt to use
      $(pgp/smime)_default_key by default.
      
      Mark $(pgp/smime)_self_encrypt_as deprecated.  They are now aliases
      for the $(pgp/smime)_default_key config vars.
      
      Change $(pgp/smime)_self_encrypt default to set.
      
      The intent is that most users now need only set
      $(pgp/smime)_default_key.  If they have a sign-only key, or have
      separate signing and encryption keys, they can put that in
      $(pgp/smime)_sign_as.  This also enables to default self_encrypt on
      and solve a very common request.
      
      Thanks to Michele Marcionelli and Vincent Lefèvre for gently pushing
      me towards a solution.
      db252e61
  5. 19 Nov, 2017 1 commit
  6. 19 Aug, 2017 1 commit
  7. 21 Jul, 2017 1 commit
  8. 13 Jun, 2017 1 commit
  9. 07 Jun, 2017 1 commit
  10. 30 Apr, 2017 2 commits
  11. 13 Oct, 2016 1 commit
  12. 13 Jul, 2016 2 commits
  13. 18 Jun, 2016 1 commit
    • Damien R.'s avatar
      pass context in mx_close_message · 6355572e
      Damien R. authored
      The mx_close_message is one of the few mx_* functions that don't have a
      context as parameter. To make them more consistent, pass the context.
      6355572e
  14. 09 May, 2016 1 commit
    • Derek Martin's avatar
      Change M_* symbols to MUTT_* · 9cafb05c
      Derek Martin authored
      Changeset 23334e967dd7 created a workaround for a namespace conflict
      with Solaris and derivatives.  After some discussion, the team decided
      it would be best to move away from using the "M_" prefix for macros.
      
      This patch was automatically generated by running:
        perl -wpi -e 's/\bM_(\w+)\b/MUTT_$1/g' `find . -name '*.[ch]' -print`
      with the exception that sys_socket.h was exempted.  (That file will
      be backed out subsequent to this commit.)
      
      Thanks to Andras Salamon for supplying the perl script used to make
      this change.
      9cafb05c
  15. 28 Apr, 2016 1 commit
  16. 20 Mar, 2016 1 commit
    • Kevin J. McCarthy's avatar
      Turn off asserts in sendlib.c. · 6814e45b
      Kevin J. McCarthy authored
      The Doctor reported triggering an assertion in convert_file_to(), due
      to an unexpected errno from iconv().  According to the comments, the
      assertions were only enabled for debugging and should have been turned
      off.  We certainly don't want to abort mutt for this case, so just
      disable them as the comment indicates.
      6814e45b
  17. 01 Jan, 2016 1 commit
    • Kevin J. McCarthy's avatar
      Update copyright notices. · 1b329ffe
      Kevin J. McCarthy authored
      This patch only updates existing copyright notices in the source
      files, using commit dates since the last copyright update in commits
      e3af935cdb1a and f8fd60d8d3f2.
      
      Add a notice to the COPYRIGHT file to refer to our mercurial
      repository for the full commit history.
      
      Add myself to the COPYRIGHT file and smime_keys.pl file.
      1b329ffe
  18. 24 Nov, 2015 1 commit
    • Kevin J. McCarthy's avatar
      Rename idna functions and bits for smtputf8 changes. · 0e0520fa
      Kevin J. McCarthy authored
      This is patch 1 of 4 implementing support for SMTPUTF8 (RFC 6531).
      
      Change mutt_idna.c to be always compiled.  Remove the stub functions in
      mutt_idna.h.  Instead, put #ifdefs around the idna function calls.  The
      conversion functions will be fixed up in the next patch.
      
      Rename the conversion functions to mutt_addrlist_to_intl() and
      mutt_env_to_intl().  Rename the ADDRESS idna status bits to "intl"
      status bits.
      0e0520fa
  19. 23 Jul, 2015 1 commit
    • Kevin J. McCarthy's avatar
      Fix compiler type warnings. (closes #3765) · d1ee38fe
      Kevin J. McCarthy authored
      The output of mutt_local_tz() was being passed to abs().  Technically
      the return type is time_t, but it represents a small value: the timezone
      offset in seconds.  Add a safe explicit cast to int.
      
      Change the txt parameter of mutt_make_help() to type const char *.
      Typically all calls run the txt parameter through _(), which
      accepts const char * and returns a char *. However, if NLS is not
      enabled, _() is a noop, simply returning the parameter itself.  In
      mutt_compile_help(), items[i].name is const char *, so it will generate
      a warning when passed as the txt parameter of mutt_make_help().
      
      On some systems, e.g. OS X, snprintf is defined as a macro.  One call
      in hcache.c was embedding directives inside the snprintf call.  This is
      apparently undefined behavior, so duplicate the call instead.
      d1ee38fe
  20. 30 Mar, 2015 1 commit
    • Kevin J. McCarthy's avatar
      Add a security bit to the message for oppenc mode. · 15b61571
      Kevin J. McCarthy authored
      This allows oppenc to be enabled/disabled on a message level.  If
      something initially enables encryption, such as crypt_autoencrypt or
      crypt_replyencrypt, oppenc is turned off for the message.
      
      Change the postpone/resume code to persist the oppenc bit.
      
      Also change resend message to enable and invoke oppenc if the option is
      set.
      15b61571
  21. 10 Feb, 2015 1 commit
  22. 15 Jan, 2015 1 commit
    • Kevin J. McCarthy's avatar
      Send the IMAP \Draft flag when postponing a message. · 4cfe99a8
      Kevin J. McCarthy authored
      This patch adds a mx_open_new_message() flag, M_SET_DRAFT.  It also adds
      a MESSAGE->flags.draft flag.
      
      mutt_write_fcc() passes the M_SET_DRAFT flag to mx_open_new_message(),
      which then sets MESSAGE->flags.draft.  Then, imap_append_message() is
      able to see this flag and so adds the \Draft flag.
      
      The imap_append_message() function started to have a bit too many flags,
      so this version of the patch separates out the flag generating code into
      a simpler version.
      4cfe99a8
  23. 01 Dec, 2014 1 commit
  24. 22 Feb, 2013 1 commit
  25. 21 Dec, 2012 1 commit
  26. 18 Dec, 2012 2 commits
    • Michael Elkins's avatar
      rename iswsp() to is_email_wsp() · 90eb6a39
      Michael Elkins authored
      add new inline funtion skip_email_wsp() to be used in lieu of SKIPWS() when parsing ASCII protocols rather than user input.
      
      change use of SKIPWS() to skip_email_wsp() in places where it is likely to be a problem.
      90eb6a39
    • Michael Elkins's avatar
      fix problem where mutt_substrdup() was called with the start · 30831a33
      Michael Elkins authored
      pointer > end pointer, as a result of using SKIPWS().  This
      occurred because the header field had an empty body, so the
      trailing newline was skipped over.  The fix is to just skip over
      ascii space and htab.
      
      closes #3609
      30831a33
  27. 03 Dec, 2011 1 commit
    • Dan Fandrich's avatar
      Declare many structures const (closes #3552) · 05df9d08
      Dan Fandrich authored
      Many structs used in mutt are actually constant but are defined
      without the 'const' keyword. This can slow initialization (slightly)
      in some environments due to extra copying and increases the amount of
      writable RAM required at run-time, which can be significant on non-MMU
      systems. Using const can also increase the opportunities for compiler
      optimization.
      
      The attached patch marks many such structures as const. On my test x86
      build, this reduces the size of .data by over 50%.
      05df9d08
  28. 25 Nov, 2011 1 commit
  29. 20 Jun, 2011 1 commit
  30. 30 Dec, 2010 1 commit
  31. 11 Sep, 2010 1 commit
  32. 23 Mar, 2010 1 commit
  33. 21 Mar, 2010 1 commit
  34. 29 Oct, 2009 1 commit
  35. 07 Jul, 2009 1 commit
  36. 25 Jun, 2009 2 commits