1. 03 Dec, 2011 1 commit
    • Dan Fandrich's avatar
      Declare many structures const (closes #3552) · 05df9d08
      Dan Fandrich authored
      Many structs used in mutt are actually constant but are defined
      without the 'const' keyword. This can slow initialization (slightly)
      in some environments due to extra copying and increases the amount of
      writable RAM required at run-time, which can be significant on non-MMU
      systems. Using const can also increase the opportunities for compiler
      optimization.
      
      The attached patch marks many such structures as const. On my test x86
      build, this reduces the size of .data by over 50%.
      05df9d08
  2. 09 Aug, 2010 1 commit
  3. 13 Jun, 2009 1 commit
  4. 17 Mar, 2009 1 commit
  5. 15 Mar, 2009 1 commit
  6. 04 Jan, 2009 2 commits
  7. 17 Dec, 2008 1 commit
  8. 30 Nov, 2008 1 commit
    • Rocco Rutte's avatar
      Manage last search pattern outside of menu lifecycle · 30541be3
      Rocco Rutte authored
      Previously, the pattern was thrown away during menu destruction.
      For the next search, mutt then can't provide a good suggestion.
      The new behaviour is to manage the pattern outside the lifecyle
      to always provide the last pattern as suggestion.
      30541be3
  9. 02 Jul, 2008 1 commit
  10. 20 Mar, 2007 1 commit
    • Rocco Rutte's avatar
      Enlarge help string buffers · 64f58f42
      Rocco Rutte authored
      Even on 80x25 terminals, SHORT_STRING (128 byte) may not be enough so use
      LONG_STRING (1k) as STRING (256 byte) may well be too short for wider
      terminals. Closes debian #4152777.
      64f58f42
  11. 20 Apr, 2006 1 commit
  12. 03 Jan, 2006 1 commit
  13. 13 Dec, 2005 1 commit
  14. 21 Oct, 2005 1 commit
  15. 17 Sep, 2005 2 commits
  16. 03 Feb, 2005 1 commit
  17. 27 Jun, 2004 1 commit
  18. 12 Apr, 2004 1 commit
  19. 03 Sep, 2003 1 commit
    • Dan Fandrich's avatar
      I've attached a patch for bug number 1036, as reported at · 3d8baab5
      Dan Fandrich authored
      http://bugs.guug.de/db/pa/lmutt.html ("segfault when more than one
      msg is postponed").  This is a patch against mutt 1.4.1.
      
      As it was previously left, no one could reproduce it.  The problem
      occurs because sorting is disabled when opening the postponed
      folder, but the Sort global variable still tells mutt to use
      whatever sorting algorithm the $sort config option indicates.
      Eventually, the code would get to mutt_messages_in_thread and try to
      dereference a NULL thread object, causing the segfault.
      3d8baab5
  20. 21 Jan, 2003 1 commit
    • Werner Koch's avatar
      - To cleanup the pgp/smime code and prepare for other backends. · c901be35
      Werner Koch authored
       - Support gpg-agent by not asking for a passphrase
       - autconf cleanups.
      
      This is just a start and probably we need a couple of other things to
      do. One drawback is that the help menu does always list all crypto
      realted stuff even when configured for no crypto at all.  Same goes
      for the configure options but I consider thsi a feature: It allows to
      use the same .muttrc for different versions of mutt - at least during
      development, this is an advantage.  This all might be fixed but
      requires some changes to the configuration system.
      
      Note, the use of the WithCrypto macro - it enables the compiler to do
      dead-code-elimination depending on the configured backend.  This is
      better readable than all the nested ifdefs.  I did some short tests
      and it seems to work, althoug mutt's size does not change largely when
      compiled w/o crypto.
      
      cryptglue.c is new as a warpper to all crypto calls; some are still in
      crypt.c but they should eventually also be wrapped.  We don't use
      function pointers to keep a path to use dlopen or runtime configured
      backends.  crypt.h is also new and replaces pgp.h and smime.h in most
      files (except for the backend).
      
      
      
      2003-01-06  Werner Koch  <wk@gnupg.org>
      
      	* crypt.c (crypt_valid_passphrase): Detect gpg-agent and don't ask
      	for the passphrase.
      	* pgp.c (pgp_decrypt_part, pgp_application_pgp_handler)
      	(pgp_sign_message, pgp_encrypt_message)
      	(pgp_traditional_encryptsign): Make sure that we never ever send
      	the passphrase if the gpg-agent has been detected.  Likewise.
      
      	* acconfig.h: Removed all remaining stuff as AC_TEMPLATEs to
      	configure.in. BTW, we should consider to rename configure.in to
      	configure.ac.
      
      2003-01-04  Werner Koch  <wk@gnupg.org>
      
              Replaced the use of HAVE_PGP and HAVE_SMIME by a more readable
      	and extendable solution.
      
      	* pgplib.h: Moved enum pgp_ring and KEYFLAGS_* to
      	* crypt.h: here.
      	* smime.c (mutt_is_application_smime): Moved to
      	* crypt.c (mutt_is_application_smime): here.
      	* pgp.c (mutt_is_application_pgp): Moved to
      	* crypt.c (mutt_is_application_pgp): here.
      	* pgp.c (pgp_is_multipart_encrypted): Removed. Merged code with
      	* crypt.c (mutt_is_multipart_encrypted): this.
      
      	* mutt.h: Protect against double inclusion.
      
      	* pgplib.h (struct pgp_keyinfo): Remove the typedef to pgp_key_t.
      	* crypt.h (pgp_key_t): Declare the typedef here.  NOTE:  This is
      	now a pointer.  Changed all usages accordingly.
      
      	* configure.in: Replace HAVE_PGP and HAVE_SMIME by the new
      	CRYPT_BACKEND macros.  Always include all OPS.*.
      	(LIBOBJ): Replaced by AC_LIBOBJ as required by newer autoconfs.
      	* Makefile.am (EXTRA_mutt_SOURCES): Move crypt.c to mutt_SOURCES.
      	(mutt_SOURCES): Add cryptglue.c
      	(EXTRA_DIST): Add crypt.h
      
      	* pgp.h, pgplib.h, smime.h: Use the header only when the
      	approriate backend has been configured.
      	* pgp.c, pgpkey.c, smime.c: Build only if the approriate
      	CRYPT_BACKEND_ macro is defined.
      	* pgp.h, smime.h, global.h: Moved all variable declarations to
      	global.h because they are now always defined.
      
      	* sort.h: Always define PgpSortKey, although it does not belong to
      	here.
      
      	* keymap.h: Unconditionally include all PGP and SMIME stuff.
      	* mutt.h: Ditto.
      	* protos.h: Ditto.
      
      	* init.h (HAVE_SMIME): Unconditionally include all crypto related
      	definitions.  Mark the doc entries with "(Crypto/PGP/SMIME only)".
      
      	* globals.h: Replace gpg.h and smime.h by crypt.h.
      
      	* functions.h: Always include all crypto commands.
      
      	* copy.h: Unconditionally define the crypto related M_CM_
      
      	* pgplib.h: Move APPLICATION_PGP and PGP* to crypt.h and include
      	it.
      	* smime.h: Move APPLICATION_SMIME and SMIME* to crypt.h and
      	include it.
      	* mutt_crypt.h (ENCRYPT,SIGN,GOODSIGN, BADSIGN): Move to crypt.h.
      
      	* crypt.c: Replaced pgp.h and smime.h header by crypt.h.  Always
      	include all functions but shortcut them depending on WITHCRYPTO.
              All over the place use WITHCRYPTO instead of ifdefs.  Replaced all
      	direct calls of the backend fucntions by twrapper functions
      	defined in cryptglue.c
      	(crypt_get_keys): Removed prototypes.
      	* pgp.h (pgp_findKeys): New prototype.
      	* smime.h (smime_findKeys): New prototype.
      	* cryptglue.c: New.
      	* crypt.h: New.
      	* mutt_crypt.h: Moved all crypt_* prototypes to gcrypt.h.
      	Unconditionally use this file.
      
      	* init.c: Replaced pgp.h and smime.h header by crypt.h.
      	(parse_set): Use WITHCRYPTO instead of ifdefs.
      	(mutt_var_value_complete): Ditto.
      
      	* sendlib.c: Replaced pgp.h and smime.h header by crypt.h.
      	(write_as_text_part): Now one macro using WITHCRYPTO.
      	(mutt_write_mime_body): Use WITHCRYPTO instead of ifdefs.
      	(mutt_make_message_attach): Ditto.
      	(mutt_write_fcc): Ditto.
      
      	* send.c: Replaced pgp.h and smime.h header by crypt.h.
      	(include_forward): Use WITHCRYPTO and validate passphrases for pgp
      	and smime.
      	(include_reply): Ditto.
      	(generate_body): Use WITHCRYPTO instead of ifdefs.
      	(ci_send_message): Ditto.
      
      	* recvattach.c: Replaced pgp.h and smime.h header by crypt.h.
      	(mutt_gen_attach_list): Use WITHCRYPTO instead of ifdefs.
      	(mutt_attach_display_loop): Ditto
      	(mutt_view_attachments): Ditto.
      
      	* postpone.c: Replaced pgp.h and smime.h header by crypt.h.
      	(mutt_get_postponed): Use WITHCRYPTO instead of ifdefs.
      	(mutt_parse_crypt_hdr): Always include and use WITHCRYPTO instead
      	of ifdefs.
      	(mutt_prepare_template): Use WITHCRYPTO instead of ifdefs.
      
      	* pop.c: Removed pgp.h and smime.h.
      	(pop_fetch_message): Use WITHCRYPTO instead of ifdefs.
      
      	* pattern.c: Replaced pgp.h and smime.h header by crypt.h.
      	(Flags): Always include the crypto flags.
      	(msg_search): Use WITHCRYPTO instead of ifdefs.
      	(mutt_pattern_exec): Ditto.
      
      	* parse.c: Removed pgp.h and smime.h.
      	(mutt_parse_mime_message): Use WITHCRYPTO instead of ifdefs.
      
      	* pager.c: Replaced pgp.h and smime.h header by crypt.h.
      	(mutt_pager): Use WITHCRYPTO instead of ifdefs.
      
      	* mx.c: Removed smime.h and pgp.h.
      	(mx_update_context): Use WITHCRYPTO instead of ifdefs.
      
      	* muttlib.c: Replaced pgp.h and smime.h header by crypt.h.
      	(mutt_needs_mailcap): Use WITHCRYPTO. Note, that there used to be
      	an error when PGP was not configured so that TYPEAPPLICATION was
      	not recognized for SMIME.
      	(mutt_is_text_part): Use WITHCRYPTO instead of ifdefs.
      
      	* main.c: Include crypt.h.
      	(show_version): Remove HAVE_PGP and HAVE_SMIME.  Add
      	CRYPT_BACKEND_CLASSIC_PGP, CRYPT_BACKEND_CLASSIC_SMIME.
      
      	* keymap.c: Include crypt.h so that we can test WITHCRYPTO.
      	(Menus): Always include pgp and smime.
      	(km_init): Create smime and pgp bindings depending on WITHCRYPTO.
      	(km_get_table): Return OpPgp depending on WITHCRYPTO.
      
      	* hook.c (mutt_parse_hook): Use WITHCRYPTO instead of ifdefs.
      	(mutt_crypt_hook): Always include.
      
      	* headers.c: Replaced pgp.h and smime.h header by crypt.h.
      	(mutt_edit_headers): Use WITHCRYPTO instead of ifdefs
      
      	* hdrline.c: Replaced pgp.h and smime.h header by crypt.h.
      	(hdr_format_str): Use WITHCRYPTO.
      
      	* handler.c: Replaced pgp.h and smime.h header by crypt.h.
      	(mutt_can_decode): Use WITHCRYPTO instead of ifdefs.
      	(mutt_can_decode): Application/smime is now also checked when PGP
      	support is not configured.
      	(mutt_body_handler): Use WITHCRYPTO
      
      	* curs_main.c: Replaced pgp.h and smime.h header by crypt.h.
      	(mutt_index_menu): Shortcut crypto only operations depending on
      	WITHCRYPTO.
      
      	* copy.c: Replaced pgp.h and smime.h header by crypt.h.
      	(_mutt_copy_message):
      
      	* compose.c: Replaced pgp.h and smime.h header by crypt.h.
      	(enum): Always include HDR_CRYPT and HDR_CRYPTINFO.
      	(redraw_crypt_lines): Always include this fnc but shortcut it
      	depending on WITHCRYPT.  Draw lines depending on the configured
      	crypto support.
      	(pgp_send_menu): Always include this one.  Call wrapper functions.
      	(smime_send_menu): Likewise.
      	(draw_envelope): Use WITHCRYPTO instead of ifdefs.
      	(mutt_compose_menu): Allow pgp/smime commands only when configured.
      
      	* commands.c: Replaced pgp.h and smime.h header by crypt.h.
      	(mutt_display_message,pipe_msg, _mutt_pipe_message)
      	(set_copy_flags, mutt_save_message, mutt_edit_content_type)
      	(_mutt_check_traditional_pgp): Use pgp wrapper.
      
      	* attach.c (mutt_view_attachment): Removed HAVE_GPG and HAVE_SMIME
      	and replaced by global variable WITHCRYPTO.  Replaced pgp and
      	smime header by crypt.h.x
      c901be35
  21. 11 Dec, 2002 1 commit
  22. 10 Dec, 2002 1 commit
  23. 09 Sep, 2002 2 commits
  24. 28 May, 2002 1 commit
  25. 30 Mar, 2002 1 commit
  26. 24 Jan, 2002 1 commit
  27. 31 Oct, 2001 1 commit
  28. 26 Apr, 2001 1 commit
  29. 12 Feb, 2001 1 commit
  30. 20 Jul, 2000 1 commit
  31. 21 Jun, 2000 4 commits
  32. 03 Mar, 2000 2 commits
  33. 10 Feb, 2000 1 commit