Commit a21fb60e authored by Kevin J. McCarthy's avatar Kevin J. McCarthy

Merge branch 'stable'

parents 2e8f6e3f bf161cf5
Pipeline #20508748 passed with stages
in 15 minutes and 45 seconds
2018-04-13 20:39:35 -0700 Kevin McCarthy <> (ceb0534d)
* Improve gss debug printing of status_string.
Commit f52ee2f7 ensured the debug strings were properly '\0'
terminated. However, it did not prevent the strncpy from reading past
the end of the status_string.value data; it simply capped it
afterwards. Improve the code so it only reads up to
status_string.length without overwriting the buffer.
M imap/auth_gss.c
2018-04-13 19:03:29 -0700 Kevin McCarthy <> (f52ee2f7)
* Remove trailing null count from gss_buffer_desc.length field.
RFC 2744 section 3.2.2 clearly states that trailing NULL characters
are not to be included in the length field, and are not to be assumed
to be present in the value field.
Thanks to Greg Hudson, who recently debugged this same issue with
fetchmail, and kindly took the time to look at Mutt's code too.
M imap/auth_gss.c
2018-04-08 15:37:09 -0700 Kevin McCarthy <> (a550d535)
* Rename _regex.h to _mutt_regex.h to avoid name collision on Macs.
On Macs, <regex.h> includes <_regex.h>. Because Mutt defines '-I .'
during compilation, our bundled version of _regex.h was being used
instead of the system one.
I have no idea how it managed to work before, but starting in Xcode
9.3, the differences in struct size and fields started to produce a
crash and other strange behavior.
The real issue is our use of '-I .' during compilation, which allows
our local headers to override system ones. An easier fix for now is
to rename the header.
Many thanks to Charles Diza, Christian Ebert, and Fabian Groffen for
their help trying things out and helping to debug the problem.
Also, a huge thanks to Steve Karmeinsky for allowing me to ssh in to
his Mac so I could track down the underlying issue.
R100 _regex.h _mutt_regex.h
M mutt_regex.h
M regex.c
2018-04-02 11:30:31 -0700 Kevin McCarthy <> (4fe6cfeb)
* configure: check for tinfo matching ncurses
When we selected ncursesw, look for tinfow as well. Since ncurses-6.1
the binary compatibility between tinfo and tinfow disappeared, resulting
in crashes and other odd behaviour.
This change checks for tinfo or tinfow based on which ncurses we found
to continue with.
[Thanks to Fabian Groffen for the patch. I made a minor modification
to fall back to tinfo because pre-6.1 systems may not have a tinfow
but still need tinfo to compile.]
2018-03-22 09:32:31 -0700 Kevin McCarthy <> (eeba9a9b)
* Fix s/mime non-detached signature handling.
This fix is based on stbuehler's patch from
Recent versions of gpgme seem to terminate the connection for a
protocol error. stbuehler's analysis is that this is actually a
gpgme bug, but recreating the context works around the problem.
M crypt-gpgme.c
2018-03-03 13:40:27 -0800 Kevin McCarthy <> (9eeb406b)
* automatic post-release commit for mutt-1.9.4
M ChangeLog
2018-02-28 15:20:59 -0800 Kevin McCarthy <> (65068235)
* Add subjectrx section to the muttrc man page.
......@@ -8,6 +8,10 @@
The keys used are:
!: modified feature, -: deleted feature, +: new feature
1.9.5 (2018-04-14):
! Bug fix release.
1.9.4 (2018-03-03):
! Bug fix release.
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment