ChangeLog 1.05 MB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95
2020-08-29 12:25:28 -0700  Kevin McCarthy  <[email protected]> (5fb17352)

        * Update UPDATING file for 1.14.7.

M	UPDATING

2020-08-27 15:03:08 -0700  Kevin McCarthy  <[email protected]> (2b30e41d)

        * Remove cur parameter for pager recall and make-key ops.
        
        For the recall operation, this can lead to a memory leak where the
        recalled message overwrites the sctx saved data.
        
        Arguably instead, the send_message setup could be more picky about
        saving cur, or recall-message could be careful to not overwrite the
        message-id.
        
        The context parameter isn't actually used for mail-key, and the
        curs_main.c doesn't pass it.  But I can't bring myself to make that
        change for a stable fix.

M	pager.c

2020-08-24 13:45:24 -0400  Remco Rijnders  <[email protected]> (f8f760d8)

        * Fix segfault when imap server is unreachable

M	mx.c

2020-08-12 10:37:56 -0700  Kevin McCarthy  <[email protected]> (3548ec07)

        * Ensure SIGALRM interrupts connect() in batch mode.
        
        Mutt doesn't call mutt_signal_init() in batch mode, which mean no
        default handler for SIGALRM is set in that case.  The man pages seem
        to indicate SIGALRM by default should terminate the process, but
        ticket 273 reported no interruption occurring: Mutt just hung
        indefinitely.
        
        In any case, terminating isn't the desired behavior either.  Add a
        handler, as is done in imap_wait_keepalive() and send_msg().

M	mutt_socket.c

2020-07-29 13:54:19 -0700  Kevin McCarthy  <[email protected]> (05a2008e)

        * Fix List-Post header parser to handle multiple values.
        
        If the mailto url was in the second or greater position, beg was on
        the wrong character.  This would cause url_check_scheme() to fail to
        recognize the mailto.
        
        Change the loop to skip to the '<' on subsequent loops.  Keep the loop
        iterator the same, to ensure the list-post entries are comma
        separated.
        
        As a note, the parser is still not strictly following the RFC, but
        appears to work well enough in the "real world" that I'm not going to
        tweak it for now.

M	parse.c

2020-07-24 15:45:17 -0700  Kevin McCarthy  <[email protected]> (c3ae7ba5)

        * Prevent lynx from dumping a remote site if manual.txt is missing.
        
        Ambrose Li reported that if the xsltproc step fails in manual
        generation, lynx will dump a *remote* site to manual.txt, because
        manual.html does not exist.  w3m and elinks appear not to have this
        issue.
        
        Prevent lynx from doing this by adding '-localhost' flag.
        
        Ambrose also suggested prefixing './manual.html' instead should fix
        the problem, but to be conservative about not breaking anything I'm
        just adding the '-localhost' flag.

M	doc/Makefile.am

2020-07-15 19:47:11 -0700  Kevin McCarthy  <[email protected]> (62fab7bd)

        * Ensure a blackslash inside backquotes doesn't skip past eos.
        
        I'm not sure if this is possible because of the way the input is read
        by the muttrc parser, but fix the logic to ensure it can't happen.

M	init.c

2020-07-11 12:58:51 -0700  Kevin McCarthy  <[email protected]> (9bb7acf7)

        * automatic post-release commit for mutt-1.14.6

M	ChangeLog
M	VERSION

96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129
2020-07-11 12:55:01 -0700  Kevin McCarthy  <[email protected]> (e78fcc51)

        * Update UPDATING file for 1.14.6.

M	UPDATING

2020-07-07 21:09:03 -0700  Kevin McCarthy  <[email protected]> (222bd804)

        * Fix utimensat() to use cwd for relative paths.
        
        The utimensat() invocations were missing the AT_FDCWD parameter,
        meaning they would not work on relative paths.
        
        I can't remember whether I completely missed that difference from
        utime, or somehow thought all the paths would be full paths.  :-(
        
        In any case, Mutt currently does not expand relative paths in
        mutt_expand_path(), so the paths can most certainly be relative in
        those calls too.
        
        This caused a bug where atimes were not being properly reset for
        mailbox entries.

M	buffy.c
M	mbox.c
M	mx.c

2020-06-23 10:44:09 -0700  Kevin McCarthy  <[email protected]> (85ab28c9)

        * automatic post-release commit for mutt-1.14.5

M	ChangeLog
M	VERSION

130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179
2020-06-23 10:24:23 -0700  Kevin McCarthy  <[email protected]> (09cf1bca)

        * Update UPDATING file for 1.14.5 release.
        
        Amend notes for the 1.14.3 release, which also added $ssl_force_tls
        checking for an unencrypted IMAP PREAUTH connection.

M	UPDATING

2020-06-22 12:33:09 -0700  Kevin McCarthy  <[email protected]> (e37516c3)

        * Remove $ssl_starttls check for IMAP PREAUTH.
        
        Checking $ssl_starttls provides no real protection, because an
        attacker can just as easily spoof "* OK" and strip the STARTTLS
        capability as it can spoof "* PREAUTH".  The only way to really
        protect again the MITM is through $ssl_force_tls.
        
        Add documentation about STARTTLS, $tunnel, and the current PREAUTH
        exception when using $tunnel.
        
        The behavior of Mutt about $tunnel is somewhat inconsistent: is it
        considered secure or not?  For PREAUTH, to avoid breaking
        configurations, we assume it is secure.  But at the same time, Mutt is
        still negotiating STARTTLS for other $tunnel connections.
        
        This will be resolved in master for the next release; probably by
        adding a $tunnel_is_secure config variable defaulting "yes" and
        removing the STARTTLS negotiation in that case.

M	doc/manual.xml.head
M	imap/imap.c

2020-06-20 06:35:35 -0700  Kevin McCarthy  <[email protected]> (dc909119)

        * Don't check IMAP PREAUTH encryption if $tunnel is in use.
        
        $tunnel is used to create an external encrypted connection.  The
        default of $ssl_starttls is yes, meaning those kinds of connections
        will be broken by the CVE-2020-14093 fix.

M	imap/imap.c

2020-06-18 14:13:12 -0700  Kevin McCarthy  <[email protected]> (c94d2b00)

        * automatic post-release commit for mutt-1.14.4

M	ChangeLog
M	VERSION

180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229
2020-06-18 14:09:03 -0700  Kevin McCarthy  <[email protected]> (e6ec35de)

        * Update UPDATING file for 1.14.4.

M	UPDATING

2020-06-16 13:49:20 -0700  Kevin McCarthy  <[email protected]> (c547433c)

        * Fix STARTTLS response injection attack.
        
        Thanks again to Damian Poddebniak and Fabian Ising from the Münster
        University of Applied Sciences for reporting this issue.  Their
        summary in ticket 248 states the issue clearly:
        
          We found another STARTTLS-related issue in Mutt. Unfortunately, it
          affects SMTP, POP3 and IMAP.
        
          When the server responds with its "let's do TLS now message", e.g. A
          OK begin TLS\r\n in IMAP or +OK begin TLS\r\n in POP3, Mutt will
          also read any data after the \r\n and save it into some internal
          buffer for later processing. This is problematic, because a MITM
          attacker can inject arbitrary responses.
        
          There is a nice blogpost by Wietse Venema about a "command
          injection" in postfix (http://www.postfix.org/CVE-2011-0411.html).
          What we have here is the problem in reverse, i.e. not a command
          injection, but a "response injection."
        
        This commit fixes the issue by clearing the CONNECTION input buffer in
        mutt_ssl_starttls().
        
        To make backporting this fix easier, the new functions only clear the
        top-level CONNECTION buffer; they don't handle nested buffering in
        mutt_zstrm.c or mutt_sasl.c.  However both of those wrap the
        connection *after* STARTTLS, so this is currently okay.  mutt_tunnel.c
        occurs before connecting, but it does not perform any nesting.

M	mutt_socket.c
M	mutt_socket.h
M	mutt_ssl.c
M	mutt_ssl_gnutls.c

2020-06-14 14:17:45 -0700  Kevin McCarthy  <[email protected]> (34e3a1a3)

        * automatic post-release commit for mutt-1.14.3

M	ChangeLog
M	UPDATING
M	VERSION

230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347
2020-06-14 11:30:00 -0700  Kevin McCarthy  <[email protected]> (3e88866d)

        * Prevent possible IMAP MITM via PREAUTH response.
        
        This is similar to CVE-2014-2567 and CVE-2020-12398.  STARTTLS is not
        allowed in the Authenticated state, so previously Mutt would
        implicitly mark the connection as authenticated and skip any
        encryption checking/enabling.
        
        No credentials are exposed, but it does allow messages to be sent to
        an attacker, via postpone or fcc'ing for instance.
        
        Reuse the $ssl_starttls quadoption "in reverse" to prompt to abort the
        connection if it is unencrypted.
        
        Thanks very much to Damian Poddebniak and Fabian Ising from the
        Münster University of Applied Sciences for reporting this issue, and
        their help in testing the fix.

M	imap/imap.c

2020-06-06 20:03:56 -0700  Kevin McCarthy  <[email protected]> (f64ec1de)

        * Fix GnuTLS interactive prompt short-circuiting.
        
        tls_verify_peers() doesn't verify expiration dates.  So aborting early
        because of a 0 certstat and the leaf passing tls_check_preauth() does
        not mean subsequent intermediate certs are okay: they could be
        expired.
        
        In the saved-cert preauth loop, instead of just noting the
        tls_check_preauth() rc for the leaf, note the highest cert that passes
        preauth.
        
        Then, in the interactive loop (which goes in the opposite order, from
        CA to leaf) check that value instead.  Since we are trusting certs one
        by one, anything that passed in the previous loop will certainly pass
        the preauth check at the beginning of tls_check_one_certificate().

M	mutt_ssl_gnutls.c

2020-06-05 18:16:31 -0700  Kevin McCarthy  <[email protected]> (5fccf603)

        * Abort GnuTLS certificate check if a cert in the chain is rejected.
        
        GnuTLS is not checking dates because we disabled that in
        tls_negotiate().
        
        So if we don't do this, rejecting an expired intermediate cert will
        have no effect.  Certstat won't contain an expiration error, and
        tls_check_preauth() will only look at each subsequent cert in the
        chain's dates.

M	mutt_ssl_gnutls.c

2020-06-05 15:21:03 -0700  Kevin McCarthy  <[email protected]> (bb0e6277)

        * Fix GnuTLS tls_verify_peers() checking.
        
        * Change the function to pass the certstatus parameter by reference,
        and indicate success/failure of the function via the return value.  It
        was previously returning the certstatus, but was also returning 0 or
        the *unset* certstatus on error too.  Since a 0 certstatus means
        "success", this meant a gnutls_certificate_verify_peers2() failure
        would be regarded as a valid cert.
        
        * The gnutls_certificate_type_get() inside tls_verify_peers() checks
        the *client* certificate type.  Since it was only called if
        gnutls_certificate_verify_peers2() failed, I assume was either a
        mistake, or perhaps an attempt to give a special error message if the
        client cert was OpenPGP.  In either case, the error message was not
        very informative, so just remove the call and special error message.
        
        * Fix GNUTLS_E_NO_CERTIFICATE_FOUND check to be against verify_ret
        instead of certstat.
        
        * Fix gnutls_strerror() call to use verify_ret instead of certstat.
        
        * gnutls_certificate_verify_peers2() already calls and checks
        gnutls_auth_get_type(), so remove call at the beginning of
        tls_check_certificate().
        
        * gnutls_certificate_verify_peers2() also verifies the certificate
        type for the *server* is GNUTLS_CRT_X509.  Add a comment about that.

M	mutt_ssl_gnutls.c

2020-05-27 14:33:58 -0700  Kevin McCarthy  <[email protected]> (5ea51e88)

        * Fix doc install to check builddir first for bundled files.
        
        Although some of the built files are bundled in the tarball, someone
        could still try to build/install from a git checkout with a separate
        build directory.  There might be other circumstances too, so better to
        just add the check for now.

M	doc/Makefile.am

2020-05-26 13:51:56 -0700  Kevin McCarthy  <[email protected]> (0136dbd1)

        * Remove Muttrc and manual.txt from dist tarball files.
        
        The Muttrc needs to be generated because of docdir substitution.  The
        manual.txt may traditionally be generated by a different tool than the
        one on my machine (lynx), so force that to be regenerated too.
        
        It may still be necessary to just rebuild everything, but let's see if
        this will do for stable for now.

M	doc/Makefile.am

2020-05-25 13:37:20 -0700  Kevin McCarthy  <[email protected]> (6feaec02)

        * automatic post-release commit for mutt-1.14.2

M	ChangeLog
M	VERSION

348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438
2020-05-25 13:29:22 -0700  Kevin McCarthy  <[email protected]> (642a1cfd)

        * Update UPDATING file for release.

M	UPDATING

2020-05-25 12:44:43 -0700  Kevin McCarthy  <[email protected]> (f6fb5a17)

        * Fix mutt_pattern_comp() to not segv on a NULL pattern string.
        
        The change to mutt_parse_score() could now result in a NULL score
        pattern if the user specified ''.  It might be possible for this to
        happen elsewhere too, so just add a check at the top of
        mutt_pattern_comp() to handle the case.

M	pattern.c

2020-05-25 12:23:02 -0700  Kevin McCarthy  <[email protected]> (5761113a)

        * Fix buffer pool buffer truncation with my_hdr and score commands.
        
        The buffer pool is now used for command invocation, but unfortunately
        a couple cases of mutt_buffer_init() were hidden in the my_hdr and
        score command processors.
        
        This would result in a shortened buffer being returned to the pool and
        used later for something like the prompt - which expects LONG_STRING
        everywhere.
        
        Fix up the two places to instead copy the string over.  They don't
        need to grab a large buffer pool sized hunk of memory.
        
        Also, fix the mutt_buffer_pool_release() to resize upwards in case
        future code does this.  I should have done this originally, but was
        afraid it would paper over more serious issues.  :-/
        
        Thanks to Armin Wolfermann for reporting the problem.

M	buffer.c
M	init.c
M	score.c

2020-05-24 13:26:49 -0700  Kevin McCarthy  <[email protected]> (d8e518db)

        * Increase the buffer size in _mutt_get_field().
        
        Not doing so caused the subsequent _mutt_enter_string() to use the
        default buffer pool size of 1024 - negating the HUGE_STRING value
        passed into _mutt_get_field().
        
        (Once we fully transition to buffers, this awkwardness can go away...)

M	curs_lib.c

2020-05-19 12:26:55 -0700  Kevin McCarthy  <[email protected]> (c72f740a)

        * Add mitigation against DoS from thousands of parts.
        
        A demonstration attack using a million tiny parts will freeze Mutt for
        several minutes.  This is actually better than some other mail
        software, but can still be a problem at large levels.
        
        For now, set it to a very conservative 5000, but this can be adjusted
        up (or down) if necessary.
        
        Declare the previous stack-limit max depth as a constant too, and
        decrease it down to 50.  Change the handler to return non-fatal "1" on
        reaching the limit.

M	handler.c
M	mime.h
M	parse.c

2020-05-16 14:34:07 -0700  Kevin McCarthy  <[email protected]> (a4059dd2)

        * Document my release process.
        
        The old script contents is for mercurial so remove it.
        
        My process is not automated, but at least write it down.

M	build-release

2020-05-16 10:43:06 -0700  Kevin McCarthy  <[email protected]> (12cf5b46)

        * automatic post-release commit for mutt-1.14.1

M	ChangeLog
M	UPDATING
M	VERSION

439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555
2020-05-03 17:29:55 +0200  Vincent Lefevre  <[email protected]> (b4936342)

        * Add missing blank lines in ChangeLog due to buggy update-changelog.

M	ChangeLog

2020-05-03 17:18:28 +0200  Vincent Lefevre  <[email protected]> (274b1c5a)

        * Fix update-changelog rule (missing blank line in generated ChangeLog).

M	Makefile.am

2020-05-09 18:30:13 -0700  Kevin McCarthy  <[email protected]> (7bd57bc3)

        * Set AM_DISTCHECK_CONFIGURE_FLAGS to allow make distcheck to run.
        
        Add the '--with-homespool' flag, to allow it to run as non-root.

M	Makefile.am

2020-05-09 16:26:20 -0700  Kevin McCarthy  <[email protected]> (ba0c9f9e)

        * Fix doc installation directories.
        
        The conversion of makedoc.c to perl goofed up the documentation
        build/install process from a tarball.  A late commit, 3c575cab, tried
        to fix this, but didn't fix the problem when building with a separate
        srcdir.
        
        Previously, because makedoc didn't exist, all the documentation would
        be rebuilt, even though it was distributed in the tarball.
        
        Now the files don't need to be rebuilt, and so exist in $(srcdir)
        instead of the build directory.
        
        I'm a little bit unsure how this would all work, trying to install
        from git with a separate srcdir.  I think it would fail now.  However,
        I don't believe that's a common use case.
        
        If I'm wrong, then an alternative would be to go back to rebuilding
        everything.  This would be done by creating a new makedoc target, with
        rule 'cp $(srcdir)/makedoc.pl makedoc', and then changing all the
        other targets to depend on and invoke makedoc instead.

M	doc/Makefile.am

2020-05-08 12:48:19 -0700  Kevin McCarthy  <[email protected]> (30340e50)

        * Fix edit-message false-modified bug.
        
        The file was being stat() before the truncate, and
        mutt_decrease_mtime() only decreases if the sb.st_mtime is equal to
        the current time.  That means operations crossing the second boundary:
          time x:   stat
          time x+1: truncate, decrease_mtime
        would result in a false-modified bug if no changes were made during
        editing.
        
        The mutt_decrease_mtime() and callers need to be cleaned up for better
        error handling, but I will do that in master.

M	editmsg.c

2020-05-08 12:10:51 -0700  Kevin McCarthy  <[email protected]> (094a07fc)

        * Fix rc error setting in edit_one_message().
        
        In a couple places, the rc was not set before bailing on an error.
        With a default of 0, the original message would be marked for
        delete/purge.

M	editmsg.c

2020-05-07 15:23:12 -0700  Kevin McCarthy  <[email protected]> (51ed59a7)

        * Wrap 'saving fcc' message in curses and sendmailx check.

M	send.c

2020-05-02 15:16:46 -0700  Kevin McCarthy  <[email protected]> (020321ed)

        * automatic post-release commit for mutt-1.14.0

M	ChangeLog
M	VERSION
M	build-release
M	po/bg.po
M	po/ca.po
M	po/cs.po
M	po/da.po
M	po/de.po
M	po/el.po
M	po/eo.po
M	po/es.po
M	po/et.po
M	po/eu.po
M	po/fi.po
M	po/fr.po
M	po/ga.po
M	po/gl.po
M	po/hu.po
M	po/id.po
M	po/it.po
M	po/ja.po
M	po/ko.po
M	po/lt.po
M	po/nl.po
M	po/pl.po
M	po/pt_BR.po
M	po/ru.po
M	po/sk.po
M	po/sv.po
M	po/tr.po
M	po/uk.po
M	po/zh_CN.po
M	po/zh_TW.po

556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670 1671 1672 1673 1674 1675 1676 1677 1678 1679 1680 1681 1682 1683 1684 1685 1686 1687 1688 1689 1690 1691 1692 1693 1694 1695 1696 1697 1698 1699 1700 1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716 1717 1718 1719 1720 1721 1722 1723 1724 1725 1726 1727 1728 1729 1730 1731 1732 1733 1734 1735 1736 1737 1738 1739 1740 1741 1742 1743 1744 1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760 1761 1762 1763 1764 1765 1766 1767 1768 1769 1770 1771 1772 1773 1774 1775 1776 1777 1778 1779 1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 1793 1794 1795 1796 1797 1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811 1812 1813 1814 1815 1816 1817 1818 1819 1820 1821 1822 1823 1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835 1836 1837 1838 1839 1840 1841 1842 1843 1844 1845 1846 1847 1848 1849 1850 1851 1852 1853 1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865 1866 1867 1868 1869 1870 1871 1872 1873 1874 1875 1876 1877 1878 1879 1880 1881 1882 1883 1884 1885 1886 1887 1888 1889 1890 1891 1892 1893 1894 1895 1896 1897 1898 1899 1900 1901 1902 1903 1904 1905 1906 1907 1908 1909 1910 1911 1912 1913 1914 1915 1916 1917 1918 1919 1920 1921 1922 1923 1924 1925 1926 1927 1928 1929 1930 1931 1932 1933 1934 1935 1936 1937 1938 1939 1940 1941 1942 1943 1944 1945 1946 1947 1948 1949 1950 1951 1952 1953 1954 1955 1956 1957 1958 1959 1960 1961 1962 1963 1964 1965 1966 1967 1968 1969 1970 1971 1972 1973 1974 1975 1976 1977 1978 1979 1980 1981 1982 1983 1984 1985 1986 1987 1988 1989 1990 1991 1992 1993 1994 1995 1996 1997 1998 1999 2000 2001 2002 2003 2004 2005 2006 2007 2008 2009 2010 2011 2012 2013 2014 2015 2016 2017 2018 2019 2020 2021 2022 2023 2024 2025 2026 2027 2028 2029 2030 2031 2032 2033 2034 2035 2036 2037 2038 2039 2040 2041 2042 2043 2044 2045 2046 2047 2048 2049 2050 2051 2052 2053 2054 2055 2056 2057 2058 2059 2060 2061 2062 2063 2064 2065 2066 2067 2068 2069 2070 2071 2072 2073 2074 2075 2076 2077 2078 2079 2080 2081 2082 2083 2084 2085 2086 2087 2088 2089 2090 2091 2092 2093 2094 2095 2096 2097 2098 2099 2100 2101 2102 2103 2104 2105 2106 2107 2108 2109 2110 2111 2112 2113 2114 2115 2116 2117 2118 2119 2120 2121 2122 2123 2124 2125 2126 2127 2128 2129 2130 2131 2132 2133 2134 2135 2136 2137 2138 2139 2140 2141 2142 2143 2144 2145 2146 2147 2148 2149 2150 2151 2152 2153 2154 2155 2156 2157 2158 2159 2160 2161 2162 2163 2164 2165 2166 2167 2168 2169 2170 2171 2172 2173 2174 2175 2176 2177 2178 2179 2180 2181 2182 2183 2184 2185 2186 2187 2188 2189 2190 2191 2192 2193 2194 2195 2196 2197 2198 2199 2200 2201 2202 2203 2204 2205 2206 2207 2208 2209 2210 2211 2212 2213 2214 2215 2216 2217 2218 2219 2220 2221 2222 2223 2224 2225 2226 2227 2228 2229 2230 2231 2232 2233 2234 2235 2236 2237 2238 2239 2240 2241 2242 2243 2244 2245 2246 2247 2248 2249 2250 2251 2252 2253 2254 2255 2256 2257 2258 2259 2260 2261 2262 2263 2264 2265 2266 2267 2268 2269 2270 2271 2272 2273 2274 2275 2276 2277 2278 2279 2280 2281 2282 2283 2284 2285 2286 2287 2288 2289 2290 2291 2292 2293 2294 2295 2296 2297 2298 2299 2300 2301 2302 2303 2304 2305 2306 2307 2308 2309 2310 2311 2312 2313 2314 2315 2316 2317 2318 2319 2320 2321 2322 2323 2324 2325 2326 2327 2328 2329 2330 2331 2332 2333 2334 2335 2336 2337 2338 2339 2340 2341
2020-05-02 14:58:03 -0700  Kevin McCarthy  <[email protected]> (3c575cab)

        * Add missing doc built distfiles.
        
        When building the 1.14.0 release tarball, I discovered a hidden
        dependency problem from switching to makedoc.pl.
        
        The manual.xml is not properly defined, and so trying to build the
        muttrc.man and mutt.info file errors out.  This was previously hidden
        because makedoc need to be compiled, forcing a rebuild.
        
        This problem derives because the stamp-* files (and most of the other
        documentation) are *included* in the tarball, except for muttrc.man
        and mutt.texi.  Those attempt to rebuild, but manual.xml doesn't
        exist.
        
        For now, include muttrc.man and mutt.texi in the dist files.
        
        A better solution requires some thought, but not while I'm trying to
        get a release out.

M	doc/Makefile.am

2020-05-02 11:16:31 -0700  Kevin McCarthy  <[email protected]> (bd776a65)

        * Fix 'gpg' -> 'GPG' in manual and autocrypt translation string.

M	autocrypt/autocrypt_gpgme.c
M	doc/manual.xml.head
M	po/bg.po
M	po/ca.po
M	po/cs.po
M	po/da.po
M	po/de.po
M	po/el.po
M	po/eo.po
M	po/es.po
M	po/et.po
M	po/eu.po
M	po/fi.po
M	po/fr.po
M	po/ga.po
M	po/gl.po
M	po/hu.po
M	po/id.po
M	po/it.po
M	po/ja.po
M	po/ko.po
M	po/lt.po
M	po/nl.po
M	po/pl.po
M	po/pt_BR.po
M	po/ru.po
M	po/sk.po
M	po/sv.po
M	po/tr.po
M	po/uk.po
M	po/zh_CN.po
M	po/zh_TW.po

2020-05-02 10:57:22 -0700  Kevin McCarthy  <[email protected]> (c6534102)

        * Update 'mutt -v' copyright date.
        
        Since the phrase contains "and others" the developers judged it was
        correct to increase the year number.

M	main.c
M	po/bg.po
M	po/ca.po
M	po/cs.po
M	po/da.po
M	po/de.po
M	po/el.po
M	po/eo.po
M	po/es.po
M	po/et.po
M	po/eu.po
M	po/fi.po
M	po/fr.po
M	po/ga.po
M	po/gl.po
M	po/hu.po
M	po/id.po
M	po/it.po
M	po/ja.po
M	po/ko.po
M	po/lt.po
M	po/nl.po
M	po/pl.po
M	po/pt_BR.po
M	po/ru.po
M	po/sk.po
M	po/sv.po
M	po/tr.po
M	po/uk.po
M	po/zh_CN.po
M	po/zh_TW.po

2020-05-02 10:39:05 -0700  Kevin McCarthy  <[email protected]> (c60c7f69)

        * Set UPDATING release date for 1.14.0.

M	UPDATING

2020-05-01 09:26:48 -0700  Kevin McCarthy  <[email protected]> (48e5c70f)

        * Ensure idata->reopen is clear when the mailbox is closed.
        
        Commit ab457327 accidentally introduced a performance regression in
        the 1.13.0 release.  The reason is that imap_sync_mailbox() was
        leaving IMAP_REOPEN_ALLOW set.  When a mailbox was closed, and another
        opened, the imap_open_mailbox() would be processed with the reopen
        set.
        
        The initial connection and exec statements would trigger a
        imap_cmd_finish().  That would then prematurely trigger fetching new
        mail, with the newMailCount misset, which would in turn generate a
        tiny uid_hash.  When the real download occurred, it would use the
        existing tiny hash, throttling performance.
        
        The regression commit removed what I thought was an unnecessary check,
        but it was guarding the fetch from happening at the wrong time during
        mailbox open too.
        
        The performance issue was already addressed by commit a8337951 in
        master, but I think it's good to wipe the entire state.  The removes
        other possible strange behavior.
        
        A HUGE thanks to Guilhem Moulin for his help on this issue.  Without
        all his work detailing the problem, creating automated testing, git
        bisecting, and logging, I would not have been able to find and fix the
        problem.

M	imap/imap.c

2020-05-01 03:55:39 -0700  Kevin McCarthy  <[email protected]> (67948d74)

        * Fix CONDSTORE/QRESYNC context flag counts on updates.
        
        read_headers_condstore_qresync_updates() differs from
        read_headers_normal_eval_cache() in that the FLAGS updates are issued
        for existing messages in the context.
        
        So cmd_parse_fetch() will process the flags *but* it will also
        increment/decrement context flag counters.
        
        Zero out the flags (as was being done for VANISHED handling), and let
        mx_update_context() set them properly afterwards.
        
        Thanks to Guilhem Moulin for reporting the issue and helping me test
        this fix.

M	imap/message.c

2020-04-30 16:57:01 +0200  Grzegorz Szymaszek  <[email protected]> (3a20ab36)

        * Improve the Polish translation

M	po/pl.po

2020-04-28 18:56:42 +0200  Grzegorz Szymaszek  <[email protected]> (99d67832)

        * Fix a typo in a message in the Polish translation

M	po/pl.po

2020-04-28 18:49:27 +0200  Grzegorz Szymaszek  <[email protected]> (8d8af9c2)

        * Improve a message in the Polish translation
        
        This makes the translation of “Unable to create SSL context” closer to
        the original meaning.

M	po/pl.po

2020-04-28 17:49:50 -0700  Kevin McCarthy  <[email protected]> (0fdc8668)

        * Document change to exact-address writing behavior.

M	UPDATING
M	doc/manual.xml.head

2020-04-28 15:23:29 -0700  Kevin McCarthy  <[email protected]> (b3fd56a4)

        * Turn off writing exact-addresses that require 2047-encoding.
        
        The full strdup'ed copy of the address can't be properly encoded
        without significant rework to parse, encode, and reassemble.
        (Additionally, IDNA is not being performed on the domain written in
        the exact-address string.)
        
        As an example, consider the current exact address behavior, given the
        three addresses:
          "ascii name" (comment) <[email protected]>
          The ènd (comment) <[email protected]>
          "The ènd" (comment) <[email protected]>
        
        Before this commit, when sending Mutt would generate:
          "ascii name" (comment) <[email protected]>
          The =?iso-8859-1?B?6G5kIChjb21tZW50KSA8YWRkcjJAZXhhbXBsZS5jb20+?=
          =?iso-8859-1?B?IlRoZSDobmQiIChjb21tZW50KSA8YWRkcjNAZXhhbXBsZS5jb20+?=
        
        The second address 2047 encodes everything starting with ènd,
        including the comment and address.  The third address is completely
        encoded.
        
        A "quick workaround" I proposed to the list was turning off
        encode_specials.  This results in:
          "ascii name" (comment) <[email protected]>
          The =?iso-8859-1?B?6G5k?= (comment) <[email protected]>
          "The =?iso-8859-1?Q?=E8nd=22?= (comment) <[email protected]>
        
        That solves the second case, but in the third case 2047-encodes
        ènd" - including the trailing double quote.
        
        With this patch, we turn off writing the exact address if encoding is
        needed, generating:
          "ascii name" (comment) <[email protected]>
          The =?iso-8859-1?B?6G5k?= <[email protected]>
          The =?iso-8859-1?B?6G5k?= <[email protected]>
        
        This reverts to Mutt-generated normalized form in the last two
        addresses, which require encoding.  For the first case it preserves
        the address as "typed" by the user.

M	rfc2047.c
M	rfc2047.h

2020-04-27 18:18:34 -0700  Kevin McCarthy  <[email protected]> (43204e7b)

        * Add contrib/bgedit-screen-tmux.sh.
        
        This script wraps running the editor inside a new GNU Screen or tmux
        session.
        
        The script is derived from Aaron Schrab's script posted to mutt-dev,
        but rewritten to run in a posix shell, automatically adjust between
        tmux and screen, and with a bit more error checking.

M	contrib/Makefile.am
A	contrib/bgedit-screen-tmux.sh
M	doc/manual.xml.head

2020-04-27 06:40:11 -0700  Ivan Vilata i Balaguer  <[email protected]> (d5d8b62a)

        * Updated Catalan translation.

M	po/ca.po

2020-04-26 07:02:47 -0700  Morten Bo Johansen  <[email protected]> (0ab54fc7)

        * Updated Danish translation.

M	po/da.po

2020-04-25 07:08:05 -0700  Kevin McCarthy  <[email protected]> (0284e7dc)

        * Minor fix to polish translation.

M	po/pl.po

2020-04-25 14:30:52 +0200  Grzegorz Szymaszek  <[email protected]> (d19ed86c)

        * Update the Polish translation for Mutt 1.14

M	po/pl.po

2020-04-25 04:34:10 +0200  Vincent Lefevre  <[email protected]> (8c960f97)

        * Fix typo in UPDATING.

M	UPDATING

2020-04-22 06:53:57 -0700  Kevin McCarthy  <[email protected]> (d9cb3438)

        * First draft of UPDATING file for 1.14 release.

M	UPDATING

2020-04-24 14:30:11 -0700  Kevin McCarthy  <[email protected]> (858d3f92)

        * Adjust comment on header.num_hidden field.
        
        Changeset 83be183b modified _mutt_traverse_thread() to update
        num_hidden in the entire thread, so that ~v will work properly when
        switching to a non-threaded view.

M	mutt.h

2020-04-24 14:20:16 -0700  Kevin McCarthy  <[email protected]> (3dfbff41)

        * Fix minor indentation problem in hcachever.pl.

M	hcachever.pl

2020-04-22 06:14:08 +0000  Tamotsu TAKAHASHI  <[email protected]> (af8b26b7)

        * Update ja.po for 1.14

M	po/ja.po

2020-04-20 03:40:17 +0200  Vincent Lefevre  <[email protected]> (9935e756)

        * fr.po: forgot a period

M	po/fr.po

2020-04-19 18:28:52 -0700  Kevin McCarthy  <[email protected]> (d31f5692)

        * Fix copyright address.

M	contrib/bgedit-detectgui.sh

2020-04-20 03:19:41 +0200  Vincent Lefevre  <[email protected]> (190ef657)

        * fr.po: typo in a comment

M	po/fr.po

2020-04-20 03:07:34 +0200  Vincent Lefevre  <[email protected]> (5672c160)

        * Updated French translation.

M	po/fr.po

2020-04-19 13:23:17 -0700  Kevin McCarthy  <[email protected]> (c1d58163)

        * Clarify sidebar sorting by path vs alpha/name.
        
        The former only sorts by the path.
        
        The latter two will sort by label if defined.

M	doc/manual.xml.head

2020-04-19 09:31:01 -0700  Kevin McCarthy  <[email protected]> (5eea506e)

        * Add contrib/bgedit-detectgui.sh from Eike Rathke.

M	contrib/Makefile.am
A	contrib/bgedit-detectgui.sh

2020-04-18 14:05:52 -0700  Kevin McCarthy  <[email protected]> (3179e93c)

        * Freshen up other configuration options in INSTALL.
        
        Remco's patch pointed out this file has been getting rather stale.  I
        haven't added all of the flags, but reordered them and added some of
        the major ones that were missing.

M	INSTALL

2020-04-18 11:50:45 -0400  Remco Rijnders  <[email protected]> (7299f6af)

        * Include instructions on how to build with sidebar support

M	INSTALL

2020-04-18 11:51:47 -0700  Remco Rijnders  <[email protected]> (749337e0)

        * Updated Dutch translation.

M	po/nl.po

2020-04-18 06:43:58 -0700  Vsevolod Volkov  <[email protected]> (0fcf6a42)

        * Updated Russian translation.

M	po/ru.po

2020-04-18 06:42:10 -0700  Vsevolod Volkov  <[email protected]> (e442d478)

        * Updated Ukrainian translation.

M	po/uk.po

2020-04-17 12:12:07 -0700  Petr Pisar  <[email protected]> (8a8e008d)

        * Updated Czech translation.

M	po/cs.po

2020-04-16 19:50:22 +0200  Olaf Hering  <[email protected]> (37a94853)

        * Update de.po
        
        Signed-off-by: Olaf Hering <[email protected]>

M	po/de.po

2020-04-16 09:42:01 -0700  Kevin McCarthy  <[email protected]> (653b20b8)

        * Add l10n comment above the revised translation string.

M	rfc1524.c

2020-04-16 08:58:24 +0200  Olaf Hering  <[email protected]> (850aac1b)

        * Update error string in mailcap_path handling
        
        The code expects either 'mailcap_path' in muttrc, or MAILCAPS in environment.
        In this context a string 'mailcap path' is incorrect.
        
        Signed-off-by: Olaf Hering <[email protected]>

M	rfc1524.c

2020-04-15 20:26:20 +0200  Olaf Hering  <[email protected]> (0cca6886)

        * refresh de.po
        
        Signed-off-by: Olaf Hering <[email protected]>

M	po/de.po

2020-04-14 01:30:08 +0200  Vincent Lefevre  <[email protected]> (a2f963fd)

        * Fix spelling mistake in manual.

M	doc/manual.xml.head

2020-04-14 01:07:29 +0200  Vincent Lefevre  <[email protected]> (61867c9e)

        * Fix typo in manual.

M	doc/manual.xml.head

2020-04-12 13:13:43 -0700  Kevin McCarthy  <[email protected]> (c289e74c)

        * Remove ansi formatting from autoview generated quoted replies.
        
        If $allow_ansi is set, and the user has an autoview generating ansi
        output, it is helpful to strip out those sequences.
        
        This is based on Fabian's patch for ticket #218.  My version results
        in partially duplicated logic, but avoids tangling the handler with
        pager's internal fill_buffer() logic.

M	handler.c
M	muttlib.c
M	protos.h

2020-04-13 07:00:49 -0700  Kevin McCarthy  <[email protected]> (950cc435)

        * Add background.c to POTFILES.in.
        
        Thanks to Petr Pisar for pointing out the mistake.

M	po/POTFILES.in

2020-04-10 14:30:11 -0700  Kevin McCarthy  <[email protected]> (15ef4a13)

        * Document multipart/alternative inline part disposition for counting.
        
        An initial multipart/alternative's top-level inline parts are also
        counted via the "root" disposition.

M	doc/manual.xml.head

2020-04-10 13:37:42 -0700  Kevin McCarthy  <[email protected]> (cc895ebc)

        * Clarify $imap_fetch_chunk_size is referring to headers.
        
        !81 was opened because the documentation was confusing.  Hopefully
        this rewording will make it clear the "size" refers to number of
        headers per request.

M	init.h

2020-04-09 20:23:42 -0700  Kevin McCarthy  <[email protected]> (489a81ce)

        * Change default $background_format value.
        
        Move the status before the pid to more clearly separate it the
        from the subject.  Increase the pid width.
        
        Thanks to Aaron Schrab for both suggestions.

M	init.h

2020-04-09 23:25:02 +0200  Olaf Hering  <[email protected]> (f1233d94)

        * refresh de.po
        
        Signed-off-by: Olaf Hering <[email protected]>

M	po/de.po

2020-04-09 13:33:50 -0700  Kevin McCarthy  <[email protected]> (38ea4042)

        * Remove makedoc.c.
        
        The perl version seems to be working okay.  So it's a good time to
        remove this file, before the next release.

D	doc/makedoc.c

2020-04-09 11:22:07 -0700  Kevin McCarthy  <[email protected]> (53a1b4ce)

        * Convert "non-fatal" handler errors to return 1 instead of -1.
        
        When displaying a message, display a mutt_error() to warn of
        incomplete rendering.
        
        Fix mutt_copy_message() to check for ferror and feof errors on partial
        decode too.
        
        Clean up _mutt_append_message() to not pass a partial-decode along as
        a success.
        
        Modify the crypt handlers to return 1 if any kind of state message is
        displayed.  There is some fuzzyness about what a "fatal" error is, but
        for now just consider a handler error that notifies by
        state_attach_puts() as "non-fatal".

M	commands.c
M	copy.c
M	crypt-gpgme.c
M	handler.c
M	pgp.c
M	smime.c

2020-04-08 09:20:54 -0700  Kevin McCarthy  <[email protected]> (4fc97a20)

        * Display error if no imap authenticators are available.
        
        Without SASL enabled, and with an explicit value in
        $imap_authenticators not natively implemented by Mutt, no calls to
        authenticator->authenticate() were occuring.
        
        This resulted in the default r value of -1 passing through, which did
        not trigger the mutt_error() message after the loop.
        
        Without that message, an empty index would display with the
        "connecting" message still on the bottom, giving the appearance that
        Mutt is hung.

M	imap/auth.c

2020-04-07 19:30:46 -0700  Kevin McCarthy  <[email protected]> (4465a872)

        * Print progress meter when copying/saving tagged messages.
        
        When copying from local to IMAP, it would previously only display a
        percentage count for each individual message.  Suppress that by
        passing MUTT_QUIET.
        
        Note, this is only for "regular" copies.  IMAP server-side copies
        happen in a single command and can't display a progress meter.

M	commands.c

2020-04-06 15:58:58 -0700  Kevin McCarthy  <[email protected]> (8615cae9)

        * Add message/global to the list of known "message" types.
        
        This will allow Mutt to at least handle those messages the same as
        message/rfc822 body types.

M	mime.h
M	recvattach.c

2020-04-06 14:53:42 -0700  Kevin McCarthy  <kevin[email protected]> (5df8b2a1)

        * Turn on READONLY flag for postpone count check.
        
        We don't manipulate the context, so I don't think this is fixing an
        actual bug.  But better to be explicit about it.

M	postpone.c

2020-04-06 14:46:53 -0700  Kevin McCarthy  <[email protected]> (a8337951)

        * Turn off REOPEN flag after imap open and sync operations.
        
        Leaving a just opened imap mailbox with REOPEN set can cause all sorts
        of problems.  Postpone.c had a memory corruption bug because of this.
        The background compose reply-flag setting code had to ensure it was
        turned off too.
        
        The main index worked around this by always ensuring
        mx_check_mailbox() was called right afterwards.  But after researching
        I can't see any reason to leave it open.
        
        imap_sync_mailbox() also leaves the REOPEN set, and I can't see a good
        reason for doing this either.  Both are memory corruption bugs just
        waiting to happen.
        
        With the flag turned off, remove the workaround calls to
        mx_check_mailbox() in postpone.c and send.c.

M	imap/imap.c
M	postpone.c
M	send.c

2020-04-02 20:05:01 -0700  Kevin McCarthy  <[email protected]> (ed2567d1)

        * Add "root" part logic for multipart/alternative counting
        
        Distinguish between the inline parts of a root multipart/alternative,
        which should also be considered as "root" parts, and those of a
        non-root multipart/alternative, which should be counted as "inline"
        parts.

M	mutt.h
M	parse.c

2020-04-02 14:30:08 -0700  Kevin McCarthy  <[email protected]> (3b9cc43f)

        * Add "root" disposition to attachments command.
        
        An initial inline part was previously always skipped, for the good
        reasons outlined by @dgc in #217.
        
        Unfortunately, some mail clients have started sending "attachments" as
        the root (and only) part, more and more lately.  Although this may be
        bad practice, Mutt should support counting these as "attachments".
        
        To do so without breaking existing configs, add a "root" disposition
        argument to the attachments command.  This will count an initial
        inline part in a message or multipart container.
        
        The existing code skipped counting for the "top-level" and recursive
        calls, so group both of these cases under "root".

M	doc/manual.xml.head
M	globals.h
M	init.c
M	parse.c

2020-04-03 14:11:13 -0700  Kevin McCarthy  <[email protected]> (434b55ee)

        * Change disabled crypto pattern op error message and return value.
        
        If mutt is compiled without crypto support, attempting to use one of
        the patterns ~g, ~G, ~k, ~V fails with the cryptic (pun intended)
        error message:
          "error: unknown op %d (report this error)."
        
        Since the op is known, just not enabled, and furthermore is an opaque
        number, it doesn't help the user understand what the problem is.
        
        Change the code to instead print out the pattern operator character
        that is disabled:
          "Pattern operator '~%c' is disabled."
        
        Almost all callers of mutt_pattern_exec() expect it to return 0 or 1.
        Returning -1 in the event of a disabled or bad op will lead to
        undesirable "matching" behavior.  Change to return 0 in the event of
        one of these errors, since none of the callers do (or can) handle the
        error in a meaningful way.

M	pattern.c

2020-04-01 14:36:05 -0700  Kevin McCarthy  <[email protected]> (b54ccb54)

        * Simplify _smime_getkeys()
        
        The code is basically duplicated for whether a key is specified or
        falling back to SmimeDefaultKey.  The calls to
        smime_void_passhphrase() can also be simplified to whenever the key
        changes.

M	smime.c

2020-03-31 19:26:53 -0700  Kevin McCarthy  <[email protected]> (98c1a45f)

        * Convert smime static key/cert variables to buffers.

M	smime.c

2020-03-31 16:19:00 -0700  Kevin McCarthy  <[email protected]> (0e71d0ee)

        * Create crypt glue cleanup method.
        
        Create stub classic smime and cleanup functions, which will be used in
        the next commit.

M	crypt-mod-pgp-classic.c
M	crypt-mod-pgp-gpgme.c
M	crypt-mod-smime-classic.c
M	crypt-mod-smime-gpgme.c
M	crypt-mod.h
M	cryptglue.c
M	main.c
M	mutt_crypt.h
M	smime.c
M	smime.h

2020-03-31 15:48:00 -0700  Kevin McCarthy  <[email protected]> (a9451f9d)

        * Convert LastSaveFolder to buffer.

M	commands.c
M	main.c
M	protos.h

2020-03-31 13:47:35 -0700  Kevin McCarthy  <[email protected]> (b94d291f)

        * Convert mutt_make_message_attach() to use buffer tempfile.
        
        This is the last caller of the old mutt_mktemp() function.

M	sendlib.c

2020-03-31 13:19:48 -0700  Kevin McCarthy  <[email protected]> (4e153adf)

        * Convert mutt_init() to use buffer pool for path operations.
        
        Convert getdnsdomainname(), called by mutt_init(), to accept a BUFFER
        parameter instead.

M	getdomain.c
M	init.c
M	protos.h

2020-03-31 12:23:51 -0700  Kevin McCarthy  <[email protected]> (e0dc7dec)

        * Add buffer.h as a dependency of hcversion.h.
        
        The recent BUFFER change needs to force a regeneration of hcversion.h.

M	Makefile.am

2020-03-30 19:46:12 -0700  Kevin McCarthy  <[email protected]> (0b6eb1ab)

        * Remove buffer->destroy.
        
        Fix backtick processing to append to tok instead of allocating and
        assigning to tok->data directly.

M	buffer.c
M	buffer.h
M	hcache.c
M	init.c

2020-03-30 19:00:38 -0700  Kevin McCarthy  <[email protected]> (b207c280)

        * Convert mutt_parse_rc_line() to use real buffer to hold the line.
        
        Previously, the parameter converted into a kind of read-only buffer,
        pointing to the char *line passed in.  The problem is that
        mutt_extract_token() backtick processing allocates and assigns a new
        token->data.
        
        As a result, buffer->destroy was added, whose sole purpose is to keep
        track of the read-only token buffer being reallocated so that it can
        be properly freed inside mutt_parse_rc_line().  (The char *line is
        allocated and freed in source_rc()).
        
        Remove the token parameter, and convert line to a const char *.  Copy
        that into a buffer-pool buffer, so the buffer can be modified
        "normally".
        
        Create a mutt_buffer_rc_buffer() function taking the line buffer
        parameter.  To make the source_rc() just a tiny bit faster, have it
        directly manage and call mutt_parse_rc_buffer() itself.
        
        Other callers likely don't need the speed, so remove their cumbersome
        creation/free of that parameter.
        
        The next commit will deal with removing buffer->destroy and fixing up
        backtick handling.

M	commands.c
M	hook.c
M	imap/command.c
M	imap/imap.c
M	init.c
M	protos.h

2020-03-30 16:17:03 -0700  Kevin McCarthy  <[email protected]> (0d8257cb)

        * Ensure rc_line err BUFFER is always dynamic.
        
        The mailboxes command changes started using standard mutt_buffer_*()
        functions, which will attempt to realloc err->data if the size is too big.

M	imap/command.c
M	imap/imap.c

2020-03-30 13:22:16 -0700  Kevin McCarthy  <[email protected]> (e84cf897)

        * Convert built-in editor to use mutt_buffer_expand_path().

M	edit.c

2020-03-30 11:21:20 -0700  Kevin McCarthy  <[email protected]> (18cef028)

        * Convert mutt_pipe_message() to use buffer pool.

M	commands.c

2020-03-30 11:11:39 -0700  Kevin McCarthy  <[email protected]> (ae5953a2)

        * Convert mutt_pipe_attachment_list() to use buffer pool.

M	recvattach.c

2020-03-29 15:17:32 -0700  Kevin McCarthy  <[email protected]> (1a0b525a)

        * Mention -nopoll in New Mail Detection manual section.
        
        Add a brief mention a couple times to help make more users aware of
        the flag.

M	doc/manual.xml.head

2020-03-29 14:49:41 -0700  Kevin McCarthy  <[email protected]> (3f0009f4)

        * Mention $status_format %B expando in background edit section.
        
        It's added to the default, but some users will have customized the
        value and may miss the new expando.

M	doc/manual.xml.head

2020-03-28 12:34:09 -0700  Kevin McCarthy  <[email protected]> (046a3cc1)

        * Merge branch 'stable'

2020-03-28 11:34:42 -0700  Kevin McCarthy  <[email protected]> (43f2270c)

        * automatic post-release commit for mutt-1.13.5

M	ChangeLog
M	VERSION

2020-03-27 15:13:15 -0700  Kevin McCarthy  <[email protected]> (febed0bc)

        * Fix up mailboxes documentation synopsis.
        
        Specify the flags as type "option", instead of as parameters.

M	doc/manual.xml.head

2020-03-25 15:07:48 -0700  Kevin McCarthy  <[email protected]> (1487ea64)

        * Add -label and -nopoll arguments to mailboxes command
        
        -nopoll allows adding the mailbox to the sidebar, or the mailbox
        browser menu, without incurring polling costs.
        
        -poll can be used to re-enable polling for a previously disabled
        mailbox.
        
        -label allows specifying an alternative string to show in the sidebar
        and mailbox browser menu.
        
        -nolabel removes a label from an existing mailbox.
        
        Change $sidebar_sort_method so that "alpha" and "name" will sort by
        the label if specified.  "path", however, will always sort by the
        actual mailbox path.

M	browser.c
M	buffy.c
M	buffy.h
M	doc/manual.xml.head
M	doc/muttrc.man.head
M	imap/browse.c
M	imap/imap.c
M	init.h
M	protos.h
M	sidebar.c

2020-03-24 19:42:43 -0700  Kevin McCarthy  <[email protected]> (1e9ab8b6)

        * Minor sidebar HilIndex and redraw cleanup.
        
        Ensure HilIndex is reset to -1 if all mailboxes are hidden, preventing
        <sidebar-open> from opening a hidden mailbox in that case.
        
        Previously, draw_sidebar() would still be triggered in that case,
        causing an empty loop to run and trailing space to be drawn.  But with
        this change TopIndex and BottomIndex will still be -1 in that case.
        
        Change the prepare_sidebar() return value to check if HilIndex is set,
        and if mutt_sb_draw() to clear out in that case.

M	sidebar.c

2020-03-24 19:23:41 -0700  Kevin McCarthy  <[email protected]> (67acdd72)

        * Add sidebar-first and sidebar-last functions.

M	OPS.SIDEBAR
M	curs_main.c
M	functions.h
M	pager.c
M	sidebar.c

2020-03-24 10:12:58 -0700  Kevin McCarthy  <[email protected]> (87f5f3f0)

        * Merge branch 'stable'

2020-03-22 15:06:40 -0700  Kevin McCarthy  <[email protected]> (970fbcb0)

        * Clarify PGP Pseudo-header S<id> duration.
        
        Due to the background edit changes, S<id> values are now assigned to
        the send-context, not to $pgp_sign_as.  The duration of the change is
        no longer permanent.

M	doc/manual.xml.head

2020-03-21 14:57:52 -0700  Kevin McCarthy  <[email protected]> (883ccfdf)

        * Fix typo "delimeter".

M	doc/manual.xml.head
M	pgp.c

2020-03-19 15:12:49 -0700  Kevin McCarthy  <[email protected]> (ab790a7d)

        * Add $fcc_delimiter, to allow multiple Fcc mailboxes.
        
        The variable defaults unset, to prevent breaking anyone's
        configuration.
        
        If set to a value, such as ",", $record and fcc-hook may list multiple
        mailboxes separated by the delimiter.  Mutt will tokenize and
        expand/prettify each separate mailbox.  At Fcc time, it will loop
        through trying to save to each mailbox.
        
        This patch introduces a bit more uglyness into init.c, which has to
        special-process for $record in a few places.  I don't like that, but I
        believe the feature is important enough to allow for the one-off
        behavior hack, because we are constrained by backwards compatibility.
        
        Add documentation notes about the resulting issues with '<' mailbox
        shortcut expansion, and with fcc-save-hook processing.  It is
        recommended to use fcc-hook to set multiple mailboxes in those cases
        instead.

M	compose.c
M	doc/manual.xml.head
M	globals.h
M	headers.c
M	hook.c
M	init.c
M	init.h
M	muttlib.c
M	postpone.c
M	protos.h
M	send.c

2020-03-16 14:59:43 -0700  Kevin McCarthy  <[email protected]> (0b971305)

        * Add $folder to send scope.
        
        It's hard to know where to draw the line on scope variables, but
        $folder seems likely to change across "account switches" and will
        affect Fcc pretty_mailbox and expansion.  The user can also manually
        change Fcc from the compose menu.
        
        If spoolfile or infile complaints come in, I can add that, but I'm not
        convinced those will commonly be an issue for sending emails.

M	doc/manual.xml.head
M	send.c
M	send.h

2020-03-08 14:41:22 -0700  Kevin McCarthy  <[email protected]> (5cf8a042)

        * Convert progress and socket_poll millis to unsigned long long.
        
        64-bit platforms should already be using a 64-bit tv_sec, so we should
        use the same for the millis values.

M	curs_lib.c
M	mutt_curses.h
M	mutt_socket.c

2020-03-06 14:35:19 -0800  Kevin McCarthy  <[email protected]> (3ac6f3ea)

        * Change mutt_FormatString() data parameter to type void *.
        
        All invocations pass a pointer parameter.  Perhaps at one point this
        was like the init.h combined usage.  But as with that, using an
        unsigned long is incorrect, and we've been lucky to get away with it.
        Since we don't need a union, just change it to void * to properly size
        the parameter.

M	addrbook.c
M	autocrypt/autocrypt_acct_menu.c
M	background.c
M	browser.c
M	compose.c
M	compress.c
M	crypt-gpgme.c
M	hdrline.c
M	history.c
M	muttlib.c
M	pgpinvoke.c
M	pgpkey.c
M	protos.h
M	query.c
M	recvattach.c
M	remailer.c
M	sidebar.c
M	smime.c
M	status.c

2020-03-06 13:51:49 -0800  Kevin McCarthy  <[email protected]> (435f0cdb)

        * Merge branch 'stable'

2020-03-05 17:06:26 +0000  Zero King  <[email protected]> (e13e84f0)

        * Remove unreachable code

M	pgpewrap.c

2020-03-03 11:10:22 -0800  Kevin McCarthy  <[email protected]> (862ed68b)

        * Fix for $recall part 2.
        
        Fix the sctx->flags check further below too.  Now that
        SENDBACKGROUNDEDIT is added, a direct comparison is incorrect.

M	send.c

2020-03-03 10:18:45 -0800  Kevin McCarthy  <[email protected]> (63cb4e9f)

        * Fix $recall prompting.
        
        The background-edit added a flag for the <mail> operation, so the
        previous test for !flags now always fails.
        
        I don't see a more elegant fix, other than changing it to match
        SENDBACKGROUNDEDIT, plus the existing test for sctx->msg being NULL.
        
        Add a comment because the flag test is confusing otherwise.

M	send.c

2020-03-02 14:05:49 -0800  Kevin McCarthy  <[email protected]> (fa8702ff)

        * Add $status_format 'B' expando for backgrounded count.
        
        Add "%?B? Back:%B?" to the default $status_format.
        
        Rather than iterating ProcessList for each status bar refresh, just
        add a counter in background.c.

M	background.c
M	background.h
M	init.h
M	status.c

2020-03-01 18:07:02 -0800  Kevin McCarthy  <[email protected]> (86e18125)

        * Update send_ctx comment about the cur field.

M	send.h

2020-03-01 18:05:46 -0800  Kevin McCarthy  <[email protected]> (c045cbc9)

        * Add %i to $background_format.
        
        This will show the parent message id for replies and forwarded
        messages.

M	background.c
M	init.h

2020-03-01 14:22:26 -0800  Kevin McCarthy  <[email protected]> (c51e833a)

        * Refresh flag setting message.
        
        Despite MUTT_QUIET, there are still messages displayed by opening an
        IMAP mailbox, so refresh the message.

M	send.c

2020-03-01 14:20:39 -0800  Kevin McCarthy  <[email protected]> (1399257d)

        * Try to respect MUTT_QUIET for IMAP contexts too.
        
        There are still connection related messages, but at least reduce the
        number of messages.

M	imap/imap.c
M	imap/message.c

2020-03-01 12:09:17 -0800  Kevin McCarthy  <[email protected]> (14752ae2)

        * Use -1, not WAIT_ANY for waitpid() portability.

M	background.c

2020-02-27 13:00:49 -0800  Kevin McCarthy  <[email protected]> (48868326)

        * Add Background Editing sections to manual.

M	doc/manual.xml.head
M	init.h

2020-02-26 15:07:00 -0800  Kevin McCarthy  <[email protected]> (107f4334)

        * Add background flags to all other operations.
        
        - index and pager send operations.
        
        - query menu and resending.
        
        - recvattach operations.
        
        I initially thought there were complications, but the attachment menu
        decouples everything from the ATTACH_CONTEXT and doesn't free things
        before they are used.

M	background.c
M	curs_main.c
M	pager.c
M	query.c
M	recvattach.c
M	recvcmd.c
M	send.c

2020-02-26 19:45:18 -0800  Kevin McCarthy  <[email protected]> (d802c700)

        * Clean up background edit landing page.
        
        Try to get the OP_EXIT keybinding and print that instead.
        
        Manually center the strings, to avoid negative column computations.
        Allow overruns though - it's just a landing page.  The message is more
        important than a possible sidebar overwrite due to a tiny window.

M	background.c

2020-02-26 14:35:44 -0800  Kevin McCarthy  <[email protected]> (1cc04929)

        * Set reply flags when backgrounded.
        
        Store security and message_id fields to deal with replies without
        access to cur in the resumable part.
        
        Reopen the correct mailbox if it has changed.
        
        Display a message when setting reply flags, in case there is a
        noticeable pause.

M	edit.c
M	postpone.c
M	send.c
M	send.h

2020-02-22 14:15:50 -0800  Kevin McCarthy  <[email protected]> (92322ccf)

        * Confirm exiting if background edit processes exist.
        
        This prompt is in addition to the $quit prompt.  A bit annoying, but I
        believe necessary to combat muscle memory and avoid losing compose
        sessions.

M	background.c
M	background.h
M	curs_lib.c
M	curs_main.c
M	init.h
M	mutt.h

2020-02-19 19:30:41 -0800  Kevin McCarthy  <[email protected]> (d800ede1)

        * Pass sctx by reference to mutt_send_message_resume().
        
        This makes it more noticable that the parameter may be freed, and also
        prevents a use after free.

M	background.c
M	send.c
M	send.h

2020-02-19 16:34:05 -0800  Kevin McCarthy  <[email protected]> (6fe9b1d5)

        * Add background compose menu and $background_format config var.
        
        List the backgrounded sessions.  Allow the user to resume one, or exit
        the menu.
        
        Bind to 'B' by default in the index and pager menus.
        
        Remove the "<mail>" function autoresuming functionality, instead
        invoke the menu to resume backgrounded sessions.

M	OPS
M	background.c
M	background.h
M	curs_main.c
M	functions.h
M	globals.h
M	init.h
M	menu.c
M	mutt_menu.h
M	pager.c
M	send.h
M	signal.c

2020-02-17 14:40:57 -0800  Kevin McCarthy  <[email protected]> (33177255)

        * Save and restore a subset of config variables when backgrounding.
        
        Save all the booleans, quadoptions, along with:
          $record
          $postponed
          $envelope_from_address
          $from
          $sendmail
          $smtp_url
          $pgp_sign_as
          $smime_sign_as
          $smime_encrypt_with
        
        This is to prevent multiple background compose sessions from
        interfering with each other, along with account/folder changes made
        while in the index menu.

M	send.c
M	send.h

2020-02-16 12:30:54 -0800  Kevin McCarthy  <[email protected]> (0d66dd5f)

        * Add background edit landing page.
        
        The landing page waits for the $editor process to exit, or until the
        user presses <exit>, "q" by default.  If they press exit they are
        returned to the index.  If the $editor exits first, they are returned
        directly to the compose process.

M	background.c
M	compose.c
M	headers.c
M	send.c

2020-01-28 15:51:57 -0800  Kevin McCarthy  <[email protected]> (4af5c934)

        * Enable backgrounding a single <mail> function.
        
        Backgrounding exits to the index menu.  Re-invoking <mail> will resume
        the backgrounded session, if one exists, otherwise start a new
        session.
        
        This is just to get basic support going.  Multiple background edits, a
        landing page, a background compose menu list will be added next.

M	Makefile.am
A	background.c
A	background.h
M	compose.c
M	curs_main.c
M	edit.c
M	headers.c
M	init.h
M	main.c
M	mutt.h
M	protos.h
M	send.c
M	send.h

2020-02-03 13:25:30 -0800  Kevin McCarthy  <[email protected]> (9defa202)

        * Write out sctx sign_as values in mutt_write_fcc().

M	compose.c
M	protos.h
M	send.c
M	sendlib.c

2020-02-02 15:10:34 -0800  Kevin McCarthy  <[email protected]> (d3d0f3a2)

        * Change send_menus to set sctx instead of globals.
        
        Add a "cleared" bit for smime_crypt_alg.  Otherwise clearing the value
        in smime.c's menu would cause the compose menu and mutt_protect() to
        fall back to using SmimeCryptAlg.

M	compose.c
M	crypt-gpgme.c
M	crypt-gpgme.h
M	crypt-mod-pgp-classic.c
M	crypt-mod-pgp-gpgme.c
M	crypt-mod-smime-classic.c
M	crypt-mod-smime-gpgme.c
M	crypt-mod.h
M	crypt.c
M	cryptglue.c
M	mutt_crypt.h
M	pgp.c
M	pgp.h
M	send.h
M	smime.c
M	smime.h

2020-01-31 15:06:20 -0800  Kevin McCarthy  <[email protected]> (093cc268)

        * Change mutt_protect() to use sctx signas values.
        
        Pass the sctx into postpone_message() and save_fcc() to it can be
        passed to mutt_protect.
        
        Change compose menu to show the sctx values, but fall back to the
        globals.

M	compose.c
M	crypt.c
M	mutt_crypt.h
M	send.c

2020-01-30 16:12:10 -0800  Kevin McCarthy  <[email protected]> (88d3d6d4)

        * Use sctx->signas values in compose menu.
        
        todo: we need to fix the send_menus.
        We need to save/restore the globals in mutt_protect().

M	compose.c
M	headers.c
M	mutt_crypt.h
M	postpone.c
M	send.c
M	send.h

2020-01-30 15:19:49 -0800  Kevin McCarthy  <[email protected]> (c33d2e8b)

        * Pass sctx to mutt_builtin_editor() and mutt_edit_headers().
        
        This will be used to set the sctx signas instead of globals for header
        editing.

M	compose.c
M	edit.c
M	headers.c
M	protos.h
M	send.c

2020-01-30 15:06:36 -0800  Kevin McCarthy  <[email protected]> (3b3186c2)

        * Add send_ctx to compose menu and get_postponed().
        
        This will be used to store and use sctx for sign_as values.

M	compose.c
M	mutt.h
M	postpone.c
M	protos.h
M	send.c
M	send.h

2020-01-29 19:43:37 -0800  Kevin McCarthy  <[email protected]> (2b6fc1b4)

        * Refactor mutt_send_message() into multiple functions.
        
        The functions are delineated by points of editing where we want to
        resume.
        
        Create SEND_CONTEXT to contain all the state logic.

M	send.c
M	send.h

2020-01-29 15:46:02 -0800  Kevin McCarthy  <[email protected]> (541c722f)

        * Rename ci_send_message() to mutt_send_message().
        
        This fits the current naming conventions.  There are a few other "ci_"
        prefixed functions, but there's no need to tackle all those changes
        right now.

M	compose.c
M	curs_main.c
M	main.c
M	mutt.h
M	pager.c
M	query.c
M	recvcmd.c
M	send.c
M	send.h

2020-01-29 15:35:28 -0800  Kevin McCarthy  <[email protected]> (d46745e5)

        * Rename send_message() to invoke_mta().
        
        This will help distinguish mutt_send_message() and
        mutt_send_message_resume() from the actual invocation of the MTA.
        Otherwise the names are too similar and confusing.

M	send.c

2020-01-29 15:09:59 -0800  Kevin McCarthy  <[email protected]> (8bf37106)

        * Create send.h header.
        
        This will hold the send context, so we may as well pull the prototypes
        into the header file too.

M	Makefile.am
M	autocrypt/autocrypt.c
M	curs_main.c
M	group.c
M	main.c
M	pager.c
M	protos.h
M	query.c
M	recvcmd.c
M	send.c
A	send.h
M	sendlib.c
M	smime.c

2020-02-28 19:30:51 +0000  Zero King  <[email protected]> (9c1f1e48)

        * Fix use of uninitialized buffer in imap_open_connection()

M	imap/imap.c

2020-02-23 13:00:43 -0800  Kevin McCarthy  <[email protected]> (1464f842)

        * Merge branch 'stable'

2020-02-21 12:35:08 -0800  Kevin McCarthy  <[email protected]> (758d406e)

        * Limit recurse depth when parsing mime messages.
        
        Limit to 100 depth to prevent a crash due to stack overflow.  If this
        turns out to be too large (or small), I'll adjust it.

M	handler.c
M	parse.c

2020-02-15 12:26:56 -0800  Kevin McCarthy  <[email protected]> (5f79e1c6)

        * Merge branch 'stable'

2020-02-12 18:21:36 -0800  Kevin McCarthy  <[email protected]> (f1808b6c)

        * Merge branch 'stable'

2020-02-08 19:16:33 -0800  Kevin McCarthy  <[email protected]> (83be183b)

        * Fix ~v tagging when switching to non-threaded sorting.
        
        Place num_hidden in all the collapsed thread messages, rather than
        just the visible ones (i.e. the root headers).
        
        This is a tweak to commit 0f8a079d, where I discovered the behavior
        inconsistent with the documentation.  I'm making this change in master
        due to the (tiny) behavior change.

M	thread.c

2020-02-10 15:34:59 -0800  Kevin McCarthy  <[email protected]> (8d77022b)

        * Merge branch 'stable'

2020-02-10 14:58:20 -0800  Kevin McCarthy  <[email protected]> (f2b05d7c)

        * Merge branch 'stable'

2020-02-10 14:43:00 -0800  Kevin McCarthy  <[email protected]> (7a1a121e)

        * Merge branch 'stable'

2020-01-22 19:09:55 -0800  Kevin McCarthy  <[email protected]> (7e0886af)

        * Add move-up and move-down functions to compose menu.
        
        This adds the ability to rearrange the order of the attachments,
        including swapping the first attachment if desired.
        
        The compose menu doesn't support nested attachments, but since data
        structures and code are shared with recvattach, the new functions use
        the v2r and try to behave sensibly with respect to parent pointer
        adjustments.
        
        However, the functions do restrict movement to be between siblings.
        Adding code to support cross-tree movement would be more complicated
        for no current purpose.

M	OPS
M	compose.c
M	functions.h

2020-01-18 17:57:03 -0800  Kevin McCarthy  <[email protected]> (235c74a7)

        * Allow ~b ~B ~h patterns in send2-hook.
        
        This allows searching the message body or headers for making
        configuration settings.
        
        Right now, this only searches the primary message content.  I don't
        think it would be useful to search attachments, but if I'm wrong we
        can add iteration later.

M	hook.c
M	mutt.h
M	pattern.c

2020-01-16 11:12:36 -0800  Kevin McCarthy  <[email protected]> (71c770ae)

        * Rename smime oppenc mode parameter to get_keys_by_addr().
        
        Make it the same as with pgpkey.c and crypt-gpgme.c, to remove
        confusion in the future about this (as I had briefly).
        
        This is also needed because the
        $crypt_opportunistic_encrypt_strong_keys logic added to smime.c relies
        on the "may_ask" parameter being a reflection of oppenc mode, not just
        a "quiet" mode.

M	smime.c

2020-01-14 14:48:24 -0800  Kevin McCarthy  <[email protected]> (427d472d)

        * Add $crypt_opportunistic_encrypt_strong_keys config var.
        
        When set, this modifies $crypt_opportunistic_encrypt to only search
        for "strong" keys (fully valid keys according to the web of trust).
        
        S/MIME behavior depends on the backend.

M	crypt-gpgme.c
M	init.h
M	mutt.h
M	pgpkey.c
M	smime.c

2020-01-12 13:17:49 -0800  Kevin McCarthy  <[email protected]> (6470663e)

        * Merge branch 'stable'

2020-01-11 13:48:28 -0800  Kevin McCarthy  <[email protected]> (965d5b3a)

        * Merge branch 'stable'

2020-01-08 19:09:33 -0800  Kevin McCarthy  <[email protected]> (acd49f24)

        * Convert hcachever.sh.in to hcachever.pl.
        
        Use Digest::MD5 to remove build-time dependency on mutt_md5, for
        cross-compilation support.

M	.gitignore
M	Makefile.am
M	configure.ac
A	hcachever.pl
D	hcachever.sh.in

2019-12-28 15:53:11 -0800  Kevin McCarthy  <[email protected]> (46e1d670)

        * Merge branch 'stable'

2019-12-24 19:04:07 -0800  Kevin McCarthy  <[email protected]> (27fdc2f5)

        * Convert makedoc.c to makedoc.pl.
        
        This removes the build-time dependency on a compiled program, which
        doesn't work for cross-compilation.
        
        My perl is pretty rusty, and the result isn't super pretty.  However,
        since perl is already a build dependency, it made the most sense to
        use that.  The output of Muttrc, muttrc.man, and manual.xml match.
        
        There might be a few bugs, so I'm going to leave makedoc.c in for now
        as a reference.

M	doc/Makefile.am
M	doc/devel-notes.txt
A	doc/makedoc.pl
M	init.h
M	sort.h

2019-12-22 11:00:22 -0800  Kevin McCarthy  <[email protected]> (a83ab85d)

        * Merge branch 'stable'

2019-12-17 03:02:19 +0100  Marek Marczykowski-Górecki  <[email protected]> (162e6088)

        * Add protected-headers="v1" to Content-Type when protecting headers
        
        This is optional part of the draft RFC, marked with "FIXME":
        
            * FIXME: Enigmail adds "protected-headers="v1"" parameter to
              "payload" here. Is this necessary?
        
        The answer is: for Enigmail yes. Otherwise it ignores protected headers
        and use the envelope headers. This results in all the emails listed with
        "..." subject, which isn't very helpful.
        
        Since the user can disable protected headers while in the compose menu
        (after potentially failed send), remove the attribute if protected
        headers are disabled.

M	crypt.c

2019-12-19 17:15:21 +0000  Olaf Hering  <[email protected]> (b2c7aad8)

        * Update de.po
        
        Signed-off-by: Olaf Hering <[email protected]>

M	po/de.po

2019-12-18 14:25:49 -0800  Kevin McCarthy  <[email protected]> (ddb33a0c)

        * Merge branch 'stable'

2019-12-18 14:14:01 -0800  Kevin McCarthy  <[email protected]> (0582f058)

        * Merge branch 'stable'

2019-12-17 14:53:25 -0800  Kevin McCarthy  <[email protected]> (2541fa8a)

        * Fix $imap_deflate reconnection issue.
        
        Restore connection methods and data on close, so the subsequent reopen
        succeeds.

M	mutt_zstrm.c

2019-12-14 12:52:24 -0800  Kevin McCarthy  <[email protected]> (aba16e60)

        * Merge branch 'stable'

2019-12-13 16:07:18 -0800  Kevin McCarthy  <[email protected]> (83e559b6)

        * Merge branch 'stable'

2019-12-13 11:00:47 -0800  Kevin McCarthy  <[email protected]> (47f855c4)

        * Merge branch 'stable'

2019-12-12 18:51:35 -0800  Kevin McCarthy  <[email protected]> (cc4092cc)

        * Merge branch 'stable'

2019-12-08 19:11:01 -0800  Kevin McCarthy  <[email protected]> (4977bb0a)

        * Fix trash_append to use ctx parameter instead of Context.
        
        In all current cases, an open context with deleted messages will be
        "Context", but it's incorrect to not use the parameter.

M	mx.c

2019-12-03 19:18:27 -0800  Kevin McCarthy  <[email protected]> (b33087d3)

        * Merge branch 'stable'

2019-12-03 19:04:40 -0800  Kevin McCarthy  <[email protected]> (60055cd0)

        * Merge branch 'stable'

2019-12-01 15:25:54 -0800  Kevin McCarthy  <[email protected]> (e18d3986)

        * Mention $imap_qresync and $imap_deflate in performance tuning.
        
        Leave some breadcrumbs for the brave. :-)

M	doc/manual.xml.head

2019-12-01 12:56:16 -0800  Kevin McCarthy  <[email protected]> (b2e2d6af)

        * Add mutt_zstrm.c to POTFILE.in
        
        There aren't any translations in the file, but it should be added just
        in case.

M	po/POTFILES.in

2019-12-01 12:46:36 -0800  Kevin McCarthy  <[email protected]> (d9453318)

        * Merge branch 'stable'

2019-12-01 10:20:38 -0800  Kevin McCarthy  <[email protected]> (060c6345)

        * Minor isodate fixes.
        
        Make sure the year isn't negative if they type something crazy.
        
        Don't use unitialized p for the month error message.  Ideally we would
        either use %d or provide a better error message.  But I think it's
        enough to just print out the full string for now.  Non-iso dates do
        that for day-of-month for example.

M	pattern.c

2019-11-30 16:49:57 +0000  ed  <[email protected]> (9d8b9b99)

        * Adding ISO 8601 calendar date, closes #105.
        
        This adds support for date in YYYYMMDD, ISO8601 calendar date formatting.

M	doc/manual.xml.head
M	doc/muttrc.man.head
M	pattern.c

2019-12-01 07:44:05 -0800  Kevin McCarthy  <[email protected]> (d1d3a989)

        * Add USE_ZLIB to makedoc-defs.h so imap_deflate manual is generated.

M	doc/makedoc-defs.h

2019-12-01 07:31:41 -0800  Kevin McCarthy  <[email protected]> (ee220ca9)

        * Fix copyright header in mutt_zstrm.[ch]
        
        In <https://gitlab.com/muttmua/mutt/merge_requests/60#note_252772011>
        Fabian noticed that he copied the header file as a template but forgot
        to adjust the copyright line at the top to himself.
        
        Also, adjust the formats in both to match the rest of mutt, so the
        copyright updater script will work properly.

M	mutt_zstrm.c
M	mutt_zstrm.h

2019-11-18 19:11:52 -0800  Kevin McCarthy  <[email protected]> (f2f6dd46)

        * Fixes and cleanup for imap deflate patch.
        
        Rework mutt_zstrm_read():
        - Pass along the error if conn_read() returns < 0.
        - Separate out conn_eof and stream_eof flags so they can be dealt
          with differently.
        - Don't use Z_FINISH on conn_eof, because the passed in buf might
          not be big enough to hold the decompressed output.  Instead continue
          looping until either Z_STREAM_END or Z_BUF_ERROR.
        - Remove recursive calls to retry, instead goto 'retry' target.
        - Remove op statements in malloc/free.
        - Bail on other rcs.  Mutt doesn't check errno on a read error, so
          lump all other error codes into a -1 return value.  Use default so
          we handle other weird stuff such as Z_NEED_DICT or Z_STREAM_ERROR
          too.
        
        Convert $imap_deflate to boolean, default unset.
        
        Configure.ac fixes:
        - Fix indentation
        - Remove unneeded AM_CONDITIONAL.
        - Don't restore LDFLAGS and CPPFLAGS.  Save and restore LIBS instead.
        
        imap_conn_find() fixes:
        - Don't queue CAPABILITY command.  (This mistake has been in there
          since UTF-8 and QRESYNC were added.).
        - Check imap_exec() returns 0 before wrapping.  Even with FAIL_OK set,
          the imap_exec() can still return -1 on some errors.

M	configure.ac
M	imap/imap.c
M	init.h
M	mutt.h
M	mutt_zstrm.c

2019-11-11 08:34:49 +0100  Fabian Groffen  <[email protected]> (136ae0ad)

        * imap: add support for COMPRESS=DEFLATE, RFC 4978
        
        - added mutt_zstrm which allows wrapping an existing connection with
          deflate/inflate (zlib compression)
        - call mutt_zstrm_wrap_conn when setting up an IMAP connection if the
          server supports COMPRESSION=DEFLATE and imap_deflate evaluates to yes
        - add config quad-option imap_deflate enable/disable use of
          (de)compression for IMAP connections, defaulting to yes
        - add configure check for zlib, --with-zlib to detect if mutt_zstrm can
          (or should) be built
        
        Tested against a Dovecot IMAP server, observed easily 7x compression
        rates on received data, and 5x on sent data for a normal session.  Rates
        can be observed when the connection is closed on debug level 4 and
        higher.
        
        Bug: https://gitlab.com/muttmua/mutt/issues/92

M	Makefile.am
M	configure.ac
M	imap/command.c
M	imap/imap.c
M	imap/imap_private.h
M	init.h
M	mutt.h
A	mutt_zstrm.c
A	mutt_zstrm.h
2342

2343 2344 2345 2346 2347 2348 2349 2350 2351 2352 2353 2354 2355 2356 2357 2358 2359 2360 2361 2362 2363 2364 2365 2366 2367 2368 2369 2370 2371 2372 2373 2374 2375 2376 2377 2378 2379 2380 2381 2382 2383 2384 2385 2386 2387 2388 2389 2390 2391 2392 2393 2394 2395 2396 2397 2398 2399 2400 2401 2402
2020-03-28 11:20:21 -0700  Kevin McCarthy  <[email protected]> (f42ee069)

        * Update UPDATING for 1.13.5.

M	UPDATING

2020-03-24 10:01:07 -0700  Kevin McCarthy  <[email protected]> (0266f6e4)

        * Fix use-after-free in mutt_str_replace().
        
        The Outlook content-type fix in commit 4cec4b63 inadvertantly
        introduced a use-after-free.  Calling mutt_set_parameter() pointing to
        a different part of the same string ends up calling mutt_str_replace()
        with both parameters pointing to the same hunk of memory.
        
        Improve mutt_str_replace() to deal with that case, to fix this bug and
        prevent possible future bugs resulting from that mistake.
        
        Thank you to Vita Batrla for the excellent bug report and patch.  I
        merely added a comment and removed the "SAFE_FREE comment" from his
        patch.

M	lib.c

2020-03-06 13:48:45 -0800  Kevin McCarthy  <[email protected]> (d7ab6a73)

        * Fix format string parameters.
        
        crypt-gpgme and pgpkey $pgp_entry_format optional expando processing
        passed the wrong function parameter.  So did remailer for
        $mix_entry_format.

M	crypt-gpgme.c
M	pgpkey.c
M	remailer.c

2020-02-23 12:53:46 -0800  Kevin McCarthy  <[email protected]> (619cd6cf)

        * Ensure format string dest buffer is cleared for callback function.
        
        There is some variation in Mutt as to the behavior of an undefined
        expando.  Some functions pass the op through, some output nothing.
        
        Unfortunately, a few callback functions also don't ensure the dest
        buffer is cleared if no expandos match the passed in op.  This is
        mostly my fault - I think I added a few using addrbook as a template,
        which was unfortunately missing the default clear switch.
        
        Rather than adding it to the places a default is missing, just ensure
        it's cleared in mutt_FormatString() itself, which will prevent future
        mistakes too.

M	muttlib.c

2020-02-15 12:23:36 -0800  Kevin McCarthy  <[email protected]> (1adc3a5d)

        * automatic post-release commit for mutt-1.13.4

M	ChangeLog
M	VERSION
2403

2404 2405 2406 2407 2408 2409 2410 2411 2412 2413 2414 2415 2416 2417 2418 2419 2420 2421 2422 2423 2424 2425 2426 2427 2428 2429 2430 2431 2432 2433 2434 2435 2436 2437 2438 2439 2440 2441 2442 2443 2444 2445 2446 2447 2448 2449 2450 2451 2452 2453 2454 2455 2456 2457 2458 2459 2460 2461 2462 2463 2464 2465 2466 2467 2468 2469 2470 2471 2472 2473 2474 2475 2476 2477 2478 2479 2480 2481 2482 2483 2484 2485 2486 2487 2488 2489 2490 2491 2492 2493 2494 2495 2496 2497 2498 2499 2500 2501 2502 2503 2504 2505 2506 2507 2508 2509 2510 2511 2512 2513 2514 2515 2516 2517 2518 2519 2520 2521 2522 2523 2524 2525 2526 2527 2528 2529 2530 2531 2532 2533 2534 2535 2536 2537
2020-02-15 11:25:37 -0800  Kevin McCarthy  <[email protected]> (05a257e8)

        * Update UPDATING file 1.13.4.

M	UPDATING

2020-02-11 15:34:17 -0800  Kevin McCarthy  <[email protected]> (6051760c)

        * Fix crash when syncing large IMAP mailboxes.
        
        imap_sync_mailbox() and imap_exec_msgset() make a copy of the headers
        before resorting them to generate a message-set, to avoid context
        changes.  I noticed the oddity in the past but didn't investigate
        deeply enough at the time. :-/
        
        The code in imap_sync_mailbox() was wrong for four reasons:
        1) Because IMAP_REOPEN_ALLOW is set, sync_helper() can trigger
           an imap_exec if the queue fills up, resulting in new messages
           being downloaded or expunges being triggered.
        
        2) The copy was only allocating msgcount headers, instead of hdrmax.
           Downloading new messages could then attempt to append beyond the end
           of the array if hdrmax > msgcount.
        
        3) New messages or expunges would disappear when the copy was restored
           afterwards.
        
        4) The callers of mx_sync_mailbox() are prepared for context changes,
           and will adjust the cursor properly to avoid jumps.
        
        The same problems can occur in imap_exec_msgset() when reopen is set.
        Not all of its callers enable reopen, or are prepared to deal with
        context changes though, so the copy is needed when reopen is not set.
        
        An alternative solution tried converting to call mutt_sort_headers()
        when possible.  However that solution turned out to visibly slow down
        syncs due to the double sorting.
        
        This commit instead turns off reopen for the duration of the msgset
        operations.
        
        While verifying all queued operations are flushed, I noticed the
        initial "quick delete" in imap_sync_mailbox() did not seem to be
        guaranteed to flush.  Ensure the imap_exec() further below is
        triggered if either the quick delete or sync_helper calls generate
        changes.  Change the quick delete to assign to "quickdel_rc" to make
        it clear the flush below is for both.
        
        Change the post sync/msgset check to look for both ((oldsort != Sort)
        || hdrs), just to make sure a memory leak doesn't occur.

M	imap/imap.c

2020-02-08 11:34:13 -0800  Kevin McCarthy  <[email protected]> (0f8a079d)

        * Speed up thread sort when many long threads exist.
        
        Merge request !75 reported a massive slowdown opening a mailbox with
        many long threads: on the order of an hour.
        
        This is because mutt_set_virtual() was iterating through the whole
        thread for each message.
        
        After taking a closer look at current Mutt behavior, it seems the
        num_hidden count is only needed in the root thread.  Quoting my
        comment in the merge request:
        
          The index-format expando %M only applies to root level headers, so
          there are no issues there.
        
          The only concern is the pattern ~v. Limiting always resets collapsed
          and num_hidden, so there also can't be any issues there. Tagging and
          other pattern operators only work on visible messages. So tagging
          while threads are sorted will only tag the root messages of
          collapsed threads.
        
          However, if you sort by thread, collapse a thread, and then sort by
          date, the collapsed and num_hidden fields are not reset for each
          header. In theory this would allow us to tag ~v with date
          ordering. However, in master the num_hidden is only set (by
          mutt_set_virtual()) for visible messages with a virtual number.
        
          So even in master, switching to date-order and tagging ~v will only
          tag the root messages of each collapsed thread.
        
        This commit removes the num_hidden setting in mutt_set_virtual(),
        instead directly assigning that value in the roothdr during a collapse
        operation.
        
        A subsequent commit will fix the behavior of ~v, when switching
        sorting from threaded to something else, by putting num_hidden in
        every header in the thread.  This is technically a change in behavior,
        so I will make that commit in the master branch.
        
        Thanks to Score_Under for the pull request and for testing my
        alternate solutions.

M	mutt.h
M	protos.h
M	thread.c

2020-02-10 14:52:32 -0800  Kevin McCarthy  <[email protected]> (376716eb)

        * Revert $ssl_force_tls to default unset.
        
        In theory it's a good idea encourage SSL usage everywhere.
        
        However ticket #210 showed that, in reality, that kind of change
        breaks configs and so is still not a good idea.
        
        $ssl_startls defaults set and will use STARTTLS if the server
        advertises it.

M	init.h

2020-02-10 11:38:51 +0100  Daniel Tameling  <[email protected]> (10a35e5d)

        * Fix rendering of replacement_char when Charset_is_utf8
        
        Use mutt_addwch instead of addch to draw the replacement_char in
        pager.c. The line to draw the replacement char was
        addch (replacement_char ())
        However, if Charset_is_utf8 is true, replacement_char returns 0xfffd,
        which is outside the range that addch can handle. Use mutt_addwch
        instead so that the pager displays the replacement char properly.

M	pager.c

2020-01-12 13:12:00 -0800  Kevin McCarthy  <[email protected]> (ad277fd1)

        * automatic post-release commit for mutt-1.13.3

M	ChangeLog
M	VERSION
2538

2539 2540 2541 2542 2543 2544 2545 2546 2547 2548 2549 2550 2551 2552 2553 2554 2555 2556 2557 2558 2559 2560 2561 2562 2563 2564 2565 2566 2567 2568 2569 2570 2571 2572 2573 2574 2575 2576 2577 2578 2579 2580 2581 2582 2583 2584 2585 2586 2587 2588 2589 2590 2591 2592 2593 2594 2595
2020-01-12 13:01:58 -0800  Kevin McCarthy  <[email protected]> (f76b45e2)

        * Update UPDATING file for 1.13.3 release.

M	UPDATING

2020-01-11 13:47:56 -0800  Kevin McCarthy  <[email protected]> (be406ede)

        * Update copyrights to 2020.

M	COPYRIGHT
M	doc/manual.xml.head
M	doc/mutt.man
M	main.c

2019-12-28 15:43:07 -0800  Kevin McCarthy  <[email protected]> (edf5699c)

        * Fix crash when polling a closed ssl connection.
        
        Commit 8353407c enabled checking for buffered OpenSSL/GnuTLS data when
        polling, but neglected to check if the connection was already closed.
        
        This can be triggered during imap_logout() if the connection write of
        "LOGOUT" fails and closes the connection, before the poll.  It's a bit
        tricky to trigger because imap_logout_all() checks for a closed
        connection, so the failure needs to take place at that last write.
        
        Thanks to Stefan Sperling for pointing out the problem, complete with
        a backtrace and patch.  (This commit takes a different approach for a
        stable-branch fix.)

M	mutt_ssl.c
M	mutt_ssl_gnutls.c

2019-12-21 19:40:52 -0800  Kevin McCarthy  <[email protected]> (8914a1ba)

        * Turn off auto-clear outside of autocrypt initialization.
        
        The auto-clearing code was added in commit 01bc088c, for autocrypt
        initial prompting.  It removed having to keep track of every place a
        browser or other menu might be displayed and having to remember to
        clear it out.
        
        However, clearing when mutt exits is a change of behavior for those
        who have turned off alternative screens.

M	autocrypt/autocrypt.c
M	menu.c
M	mutt.h

2019-12-18 14:22:17 -0800  Kevin McCarthy  <[email protected]> (bbe9bd1a)

        * automatic post-release commit for mutt-1.13.2

M	ChangeLog
M	UPDATING
M	VERSION
2596

2597 2598 2599 2600 2601 2602 2603 2604 2605 2606 2607 2608 2609 2610
2019-12-18 14:10:38 -0800  Kevin McCarthy  <[email protected]> (7aed228a)

        * Revert "Fixes unchecked return from link() in dotlock.c"
        
        This reverts commit 317b7f6b53d8a4272acf8ef1b56f3406e9bc2691.

M	dotlock.c

2019-12-14 12:49:23 -0800  Kevin McCarthy  <[email protected]> (60dd8986)

        * automatic post-release commit for mutt-1.13.1

M	ChangeLog
M	VERSION
2611

2612 2613 2614 2615 2616 2617 2618 2619 2620 2621 2622 2623 2624 2625 2626 2627 2628 2629 2630 2631 2632 2633 2634 2635 2636 2637 2638 2639 2640 2641 2642 2643 2644 2645 2646 2647 2648 2649 2650 2651 2652 2653 2654 2655 2656 2657 2658 2659 2660 2661 2662 2663 2664 2665 2666 2667 2668 2669 2670 2671 2672 2673 2674 2675 2676 2677 2678 2679 2680 2681 2682 2683 2684 2685 2686 2687 2688 2689 2690 2691 2692 2693 2694 2695 2696 2697 2698 2699 2700 2701 2702 2703 2704 2705 2706 2707 2708 2709 2710 2711 2712 2713 2714 2715 2716 2717 2718 2719 2720 2721 2722 2723 2724 2725 2726 2727 2728 2729 2730 2731 2732 2733 2734 2735 2736 2737 2738 2739 2740 2741 2742 2743 2744 2745 2746 2747 2748 2749 2750 2751 2752 2753 2754 2755 2756 2757 2758 2759 2760 2761 2762 2763 2764 2765 2766 2767 2768 2769 2770
2019-12-14 11:33:51 -0800  Kevin McCarthy  <[email protected]> (fcfd5ee5)

        * Update UPDATING file for 1.13.1 release.

M	UPDATING

2019-12-13 15:58:20 -0800  Kevin McCarthy  <[email protected]> (3d9a1072)

        * Fix segv in IMAP postponed menu caused by reopen_allow.
        
        imap_open_mailbox() leaves IMAP_REOPEN_ALLOW set for the connection.
        I noticed this previously but didn't bother untangling the logic yet
        because the index always calls mx_check_mailbox() right away, which
        unsets the flag.
        
        However, when debugging the segv for commit 51729d8d I realized the
        postponed menu/context also suffers from the problem, leaving the menu
        ripe for segvs due to unmanaged expunges.
        
        I believe imap_read_headers() turns it off and back on to avoid
        goofing up imap_cmd_finish() when a reopen *is* allowed.
        
        The logic needs to be cleaned up and fixed.  However for a stable
        branch fix, I'm am taking a conservative approach and just calling
        mx_check_mailbox() to turn it back off.

M	postpone.c

2019-12-12 17:58:11 -0800  Kevin McCarthy  <[email protected]> (d9dd1d51)

        * Fix imap postponed mailbox use-after-free error.
        
        mutt_get_postponed() was calling mx_close_mailbox(), but not checking
        the return value.  Because the postponed context is an actual
        read-write, selected mailbox in a new connection, a failed close left
        a dangling pointer in connection->idata->ctx.
        
        imap_keepalive() traversed the connection list, finding the Postponed
        connection still there, and passed the dangling pointer to
        imap_check_mailbox.
        
        Change an empty postponed mailbox to just call fastclose.  Change the
        other closes to retry on a postive return code "reopen" event and then
        finally just call fastclose.
        
        Outside the index and postponed menu, Mutt's code only uses append or
        readonly temporary contexts.  Those are guaranteed to call
        mx_fastclose_mailbox() and return 0.

M	mx.c
M	postpone.c

2019-12-13 10:57:03 -0800  Kevin McCarthy  <[email protected]> (011cfc67)

        * Rename sidebar mailbox shortcuts option and default off.
        
        Rename to $sidebar_use_mailbox_shortcuts.  The shortening wasn't that
        much shorter and made the name confusing.
        
        To prevent complaints in the future as others transition to 1.13,
        default off.

M	init.h

2019-12-07 13:47:37 -0800  Kevin McCarthy  <[email protected]> (bbfa9271)

        * Make shortpath/indent code guards explicit.
        
        In actuality, the parent_depth and indent_width won't ever be
        negative.
        
        But the new code for unset $sidebar_relative_shortpath_indent makes
        this much less obvious.  Better to be explicit than have some small
        future code change result in a bug.

M	sidebar.c

2019-12-07 13:21:49 -0800  Kevin McCarthy  <[email protected]> (b09a0b80)

        * Create $sidebar_relative_shortpath_indent, default unset.
        
        When unset this option provides the pre-1.13.0 sidebar indentation and
        shortpath behavior.
        
        Setting the option will enable the new (relative to previous entries)
        indentation and shortening behavior.
        
        Note the mailbox shortcuts are controlled by
        $sidebar_use_mb_shortcuts, which defaults set.

M	init.h
M	mutt.h
M	sidebar.c

2019-12-03 19:16:33 -0800  Kevin McCarthy  <[email protected]> (8846480c)

        * Fix new option order in the manual.
        
        I actually intended to push commit abfaa0e0 to a remote branch, but
        accidentally ended up pushing it to stable. :-O
        
        Anyway, I think the option is okay, but may have to tweek it a bit.
        This fixes a mistake where it was placed out of order in init.h.

M	init.h

2019-12-03 18:55:49 -0800  Kevin McCarthy  <[email protected]> (abfaa0e0)

        * Add $sidebar_use_mb_shortcuts to turn off shortcuts.
        
        If unset, Mutt will revert to pre-1.13 display behavior, matching and
        removing a literal $folder prefix, without using mailbox shortcuts.

M	init.h
M	mutt.h
M	sidebar.c

2019-12-01 12:44:36 -0800  Kevin McCarthy  <[email protected]> (ba1b595c)

        * Minor documentation fixes.

M	doc/manual.xml.head

2019-11-30 10:19:26 -0800  Kevin McCarthy  <[email protected]> (1dd65e6b)

        * automatic post-release commit for mutt-1.13.0

M	ChangeLog
M	VERSION
M	po/bg.po
M	po/ca.po
M	po/cs.po
M	po/da.po
M	po/de.po
M	po/el.po
M	po/eo.po
M	po/es.po
M	po/et.po
M	po/eu.po
M	po/fi.po
M	po/fr.po
M	po/ga.po
M	po/gl.po
M	po/hu.po
M	po/id.po
M	po/it.po
M	po/ja.po
M	po/ko.po
M	po/lt.po
M	po/nl.po
M	po/pl.po
M	po/pt_BR.po
M	po/ru.po
M	po/sk.po
M	po/sv.po
M	po/tr.po
M	po/uk.po
M	po/zh_CN.po
M	po/zh_TW.po
2771

2772 2773 2774 2775 2776 2777 2778 2779 2780 2781 2782 2783 2784 2785 2786 2787 2788 2789 2790 2791 2792 2793 2794 2795 2796 2797 2798 2799