ChangeLog 1010 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60
2020-03-28 11:20:21 -0700  Kevin McCarthy  <[email protected]> (f42ee069)

        * Update UPDATING for 1.13.5.

M	UPDATING

2020-03-24 10:01:07 -0700  Kevin McCarthy  <[email protected]> (0266f6e4)

        * Fix use-after-free in mutt_str_replace().
        
        The Outlook content-type fix in commit 4cec4b63 inadvertantly
        introduced a use-after-free.  Calling mutt_set_parameter() pointing to
        a different part of the same string ends up calling mutt_str_replace()
        with both parameters pointing to the same hunk of memory.
        
        Improve mutt_str_replace() to deal with that case, to fix this bug and
        prevent possible future bugs resulting from that mistake.
        
        Thank you to Vita Batrla for the excellent bug report and patch.  I
        merely added a comment and removed the "SAFE_FREE comment" from his
        patch.

M	lib.c

2020-03-06 13:48:45 -0800  Kevin McCarthy  <[email protected]> (d7ab6a73)

        * Fix format string parameters.
        
        crypt-gpgme and pgpkey $pgp_entry_format optional expando processing
        passed the wrong function parameter.  So did remailer for
        $mix_entry_format.

M	crypt-gpgme.c
M	pgpkey.c
M	remailer.c

2020-02-23 12:53:46 -0800  Kevin McCarthy  <[email protected]> (619cd6cf)

        * Ensure format string dest buffer is cleared for callback function.
        
        There is some variation in Mutt as to the behavior of an undefined
        expando.  Some functions pass the op through, some output nothing.
        
        Unfortunately, a few callback functions also don't ensure the dest
        buffer is cleared if no expandos match the passed in op.  This is
        mostly my fault - I think I added a few using addrbook as a template,
        which was unfortunately missing the default clear switch.
        
        Rather than adding it to the places a default is missing, just ensure
        it's cleared in mutt_FormatString() itself, which will prevent future
        mistakes too.

M	muttlib.c

2020-02-15 12:23:36 -0800  Kevin McCarthy  <[email protected]> (1adc3a5d)

        * automatic post-release commit for mutt-1.13.4

M	ChangeLog
M	VERSION
61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194
2020-02-15 11:25:37 -0800  Kevin McCarthy  <[email protected]> (05a257e8)

        * Update UPDATING file 1.13.4.

M	UPDATING

2020-02-11 15:34:17 -0800  Kevin McCarthy  <[email protected]> (6051760c)

        * Fix crash when syncing large IMAP mailboxes.
        
        imap_sync_mailbox() and imap_exec_msgset() make a copy of the headers
        before resorting them to generate a message-set, to avoid context
        changes.  I noticed the oddity in the past but didn't investigate
        deeply enough at the time. :-/
        
        The code in imap_sync_mailbox() was wrong for four reasons:
        1) Because IMAP_REOPEN_ALLOW is set, sync_helper() can trigger
           an imap_exec if the queue fills up, resulting in new messages
           being downloaded or expunges being triggered.
        
        2) The copy was only allocating msgcount headers, instead of hdrmax.
           Downloading new messages could then attempt to append beyond the end
           of the array if hdrmax > msgcount.
        
        3) New messages or expunges would disappear when the copy was restored
           afterwards.
        
        4) The callers of mx_sync_mailbox() are prepared for context changes,
           and will adjust the cursor properly to avoid jumps.
        
        The same problems can occur in imap_exec_msgset() when reopen is set.
        Not all of its callers enable reopen, or are prepared to deal with
        context changes though, so the copy is needed when reopen is not set.
        
        An alternative solution tried converting to call mutt_sort_headers()
        when possible.  However that solution turned out to visibly slow down
        syncs due to the double sorting.
        
        This commit instead turns off reopen for the duration of the msgset
        operations.
        
        While verifying all queued operations are flushed, I noticed the
        initial "quick delete" in imap_sync_mailbox() did not seem to be
        guaranteed to flush.  Ensure the imap_exec() further below is
        triggered if either the quick delete or sync_helper calls generate
        changes.  Change the quick delete to assign to "quickdel_rc" to make
        it clear the flush below is for both.
        
        Change the post sync/msgset check to look for both ((oldsort != Sort)
        || hdrs), just to make sure a memory leak doesn't occur.

M	imap/imap.c

2020-02-08 11:34:13 -0800  Kevin McCarthy  <[email protected]> (0f8a079d)

        * Speed up thread sort when many long threads exist.
        
        Merge request !75 reported a massive slowdown opening a mailbox with
        many long threads: on the order of an hour.
        
        This is because mutt_set_virtual() was iterating through the whole
        thread for each message.
        
        After taking a closer look at current Mutt behavior, it seems the
        num_hidden count is only needed in the root thread.  Quoting my
        comment in the merge request:
        
          The index-format expando %M only applies to root level headers, so
          there are no issues there.
        
          The only concern is the pattern ~v. Limiting always resets collapsed
          and num_hidden, so there also can't be any issues there. Tagging and
          other pattern operators only work on visible messages. So tagging
          while threads are sorted will only tag the root messages of
          collapsed threads.
        
          However, if you sort by thread, collapse a thread, and then sort by
          date, the collapsed and num_hidden fields are not reset for each
          header. In theory this would allow us to tag ~v with date
          ordering. However, in master the num_hidden is only set (by
          mutt_set_virtual()) for visible messages with a virtual number.
        
          So even in master, switching to date-order and tagging ~v will only
          tag the root messages of each collapsed thread.
        
        This commit removes the num_hidden setting in mutt_set_virtual(),
        instead directly assigning that value in the roothdr during a collapse
        operation.
        
        A subsequent commit will fix the behavior of ~v, when switching
        sorting from threaded to something else, by putting num_hidden in
        every header in the thread.  This is technically a change in behavior,
        so I will make that commit in the master branch.
        
        Thanks to Score_Under for the pull request and for testing my
        alternate solutions.

M	mutt.h
M	protos.h
M	thread.c

2020-02-10 14:52:32 -0800  Kevin McCarthy  <[email protected]> (376716eb)

        * Revert $ssl_force_tls to default unset.
        
        In theory it's a good idea encourage SSL usage everywhere.
        
        However ticket #210 showed that, in reality, that kind of change
        breaks configs and so is still not a good idea.
        
        $ssl_startls defaults set and will use STARTTLS if the server
        advertises it.

M	init.h

2020-02-10 11:38:51 +0100  Daniel Tameling  <[email protected]> (10a35e5d)

        * Fix rendering of replacement_char when Charset_is_utf8
        
        Use mutt_addwch instead of addch to draw the replacement_char in
        pager.c. The line to draw the replacement char was
        addch (replacement_char ())
        However, if Charset_is_utf8 is true, replacement_char returns 0xfffd,
        which is outside the range that addch can handle. Use mutt_addwch
        instead so that the pager displays the replacement char properly.

M	pager.c

2020-01-12 13:12:00 -0800  Kevin McCarthy  <[email protected]> (ad277fd1)

        * automatic post-release commit for mutt-1.13.3

M	ChangeLog
M	VERSION
195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251
2020-01-12 13:01:58 -0800  Kevin McCarthy  <[email protected]> (f76b45e2)

        * Update UPDATING file for 1.13.3 release.

M	UPDATING

2020-01-11 13:47:56 -0800  Kevin McCarthy  <[email protected]> (be406ede)

        * Update copyrights to 2020.

M	COPYRIGHT
M	doc/manual.xml.head
M	doc/mutt.man
M	main.c

2019-12-28 15:43:07 -0800  Kevin McCarthy  <[email protected]> (edf5699c)

        * Fix crash when polling a closed ssl connection.
        
        Commit 8353407c enabled checking for buffered OpenSSL/GnuTLS data when
        polling, but neglected to check if the connection was already closed.
        
        This can be triggered during imap_logout() if the connection write of
        "LOGOUT" fails and closes the connection, before the poll.  It's a bit
        tricky to trigger because imap_logout_all() checks for a closed
        connection, so the failure needs to take place at that last write.
        
        Thanks to Stefan Sperling for pointing out the problem, complete with
        a backtrace and patch.  (This commit takes a different approach for a
        stable-branch fix.)

M	mutt_ssl.c
M	mutt_ssl_gnutls.c

2019-12-21 19:40:52 -0800  Kevin McCarthy  <[email protected]> (8914a1ba)

        * Turn off auto-clear outside of autocrypt initialization.
        
        The auto-clearing code was added in commit 01bc088c, for autocrypt
        initial prompting.  It removed having to keep track of every place a
        browser or other menu might be displayed and having to remember to
        clear it out.
        
        However, clearing when mutt exits is a change of behavior for those
        who have turned off alternative screens.

M	autocrypt/autocrypt.c
M	menu.c
M	mutt.h

2019-12-18 14:22:17 -0800  Kevin McCarthy  <[email protected]> (bbe9bd1a)

        * automatic post-release commit for mutt-1.13.2

M	ChangeLog
M	UPDATING
M	VERSION
252 253 254 255 256 257 258 259 260 261 262 263 264 265
2019-12-18 14:10:38 -0800  Kevin McCarthy  <[email protected]> (7aed228a)

        * Revert "Fixes unchecked return from link() in dotlock.c"
        
        This reverts commit 317b7f6b53d8a4272acf8ef1b56f3406e9bc2691.

M	dotlock.c

2019-12-14 12:49:23 -0800  Kevin McCarthy  <[email protected]> (60dd8986)

        * automatic post-release commit for mutt-1.13.1

M	ChangeLog
M	VERSION
266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424
2019-12-14 11:33:51 -0800  Kevin McCarthy  <[email protected]> (fcfd5ee5)

        * Update UPDATING file for 1.13.1 release.

M	UPDATING

2019-12-13 15:58:20 -0800  Kevin McCarthy  <[email protected]> (3d9a1072)

        * Fix segv in IMAP postponed menu caused by reopen_allow.
        
        imap_open_mailbox() leaves IMAP_REOPEN_ALLOW set for the connection.
        I noticed this previously but didn't bother untangling the logic yet
        because the index always calls mx_check_mailbox() right away, which
        unsets the flag.
        
        However, when debugging the segv for commit 51729d8d I realized the
        postponed menu/context also suffers from the problem, leaving the menu
        ripe for segvs due to unmanaged expunges.
        
        I believe imap_read_headers() turns it off and back on to avoid
        goofing up imap_cmd_finish() when a reopen *is* allowed.
        
        The logic needs to be cleaned up and fixed.  However for a stable
        branch fix, I'm am taking a conservative approach and just calling
        mx_check_mailbox() to turn it back off.

M	postpone.c

2019-12-12 17:58:11 -0800  Kevin McCarthy  <[email protected]> (d9dd1d51)

        * Fix imap postponed mailbox use-after-free error.
        
        mutt_get_postponed() was calling mx_close_mailbox(), but not checking
        the return value.  Because the postponed context is an actual
        read-write, selected mailbox in a new connection, a failed close left
        a dangling pointer in connection->idata->ctx.
        
        imap_keepalive() traversed the connection list, finding the Postponed
        connection still there, and passed the dangling pointer to
        imap_check_mailbox.
        
        Change an empty postponed mailbox to just call fastclose.  Change the
        other closes to retry on a postive return code "reopen" event and then
        finally just call fastclose.
        
        Outside the index and postponed menu, Mutt's code only uses append or
        readonly temporary contexts.  Those are guaranteed to call
        mx_fastclose_mailbox() and return 0.

M	mx.c
M	postpone.c

2019-12-13 10:57:03 -0800  Kevin McCarthy  <[email protected]> (011cfc67)

        * Rename sidebar mailbox shortcuts option and default off.
        
        Rename to $sidebar_use_mailbox_shortcuts.  The shortening wasn't that
        much shorter and made the name confusing.
        
        To prevent complaints in the future as others transition to 1.13,
        default off.

M	init.h

2019-12-07 13:47:37 -0800  Kevin McCarthy  <[email protected]> (bbfa9271)

        * Make shortpath/indent code guards explicit.
        
        In actuality, the parent_depth and indent_width won't ever be
        negative.
        
        But the new code for unset $sidebar_relative_shortpath_indent makes
        this much less obvious.  Better to be explicit than have some small
        future code change result in a bug.

M	sidebar.c

2019-12-07 13:21:49 -0800  Kevin McCarthy  <[email protected]> (b09a0b80)

        * Create $sidebar_relative_shortpath_indent, default unset.
        
        When unset this option provides the pre-1.13.0 sidebar indentation and
        shortpath behavior.
        
        Setting the option will enable the new (relative to previous entries)
        indentation and shortening behavior.
        
        Note the mailbox shortcuts are controlled by
        $sidebar_use_mb_shortcuts, which defaults set.

M	init.h
M	mutt.h
M	sidebar.c

2019-12-03 19:16:33 -0800  Kevin McCarthy  <[email protected]> (8846480c)

        * Fix new option order in the manual.
        
        I actually intended to push commit abfaa0e0 to a remote branch, but
        accidentally ended up pushing it to stable. :-O
        
        Anyway, I think the option is okay, but may have to tweek it a bit.
        This fixes a mistake where it was placed out of order in init.h.

M	init.h

2019-12-03 18:55:49 -0800  Kevin McCarthy  <[email protected]> (abfaa0e0)

        * Add $sidebar_use_mb_shortcuts to turn off shortcuts.
        
        If unset, Mutt will revert to pre-1.13 display behavior, matching and
        removing a literal $folder prefix, without using mailbox shortcuts.

M	init.h
M	mutt.h
M	sidebar.c

2019-12-01 12:44:36 -0800  Kevin McCarthy  <[email protected]> (ba1b595c)

        * Minor documentation fixes.

M	doc/manual.xml.head

2019-11-30 10:19:26 -0800  Kevin McCarthy  <[email protected]> (1dd65e6b)

        * automatic post-release commit for mutt-1.13.0

M	ChangeLog
M	VERSION
M	po/bg.po
M	po/ca.po
M	po/cs.po
M	po/da.po
M	po/de.po
M	po/el.po
M	po/eo.po
M	po/es.po
M	po/et.po
M	po/eu.po
M	po/fi.po
M	po/fr.po
M	po/ga.po
M	po/gl.po
M	po/hu.po
M	po/id.po
M	po/it.po
M	po/ja.po
M	po/ko.po
M	po/lt.po
M	po/nl.po
M	po/pl.po
M	po/pt_BR.po
M	po/ru.po
M	po/sk.po
M	po/sv.po
M	po/tr.po
M	po/uk.po
M	po/zh_CN.po
M	po/zh_TW.po
425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670 1671 1672 1673 1674 1675 1676 1677 1678 1679 1680 1681 1682 1683 1684 1685 1686 1687 1688 1689 1690 1691 1692 1693 1694 1695 1696 1697 1698 1699 1700 1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716 1717 1718 1719 1720 1721 1722 1723 1724 1725 1726 1727 1728 1729 1730 1731 1732 1733 1734 1735 1736 1737 1738 1739 1740 1741 1742 1743 1744 1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760 1761 1762 1763 1764 1765 1766 1767 1768 1769 1770 1771 1772 1773 1774 1775 1776 1777 1778 1779 1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 1793 1794 1795 1796 1797 1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811 1812 1813 1814 1815 1816 1817 1818 1819 1820 1821 1822 1823 1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835 1836 1837 1838 1839 1840 1841 1842 1843 1844 1845 1846 1847 1848 1849 1850 1851 1852 1853 1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865 1866 1867 1868 1869 1870 1871 1872 1873 1874 1875 1876 1877 1878 1879 1880 1881 1882 1883 1884 1885 1886 1887 1888 1889 1890 1891 1892 1893 1894 1895 1896 1897 1898 1899 1900 1901 1902 1903 1904 1905 1906 1907 1908 1909 1910 1911 1912 1913 1914 1915 1916 1917 1918 1919 1920 1921 1922 1923 1924 1925 1926 1927 1928 1929 1930 1931 1932 1933 1934 1935 1936 1937 1938 1939 1940 1941 1942 1943 1944 1945 1946 1947 1948 1949 1950 1951 1952 1953 1954 1955 1956 1957 1958 1959 1960 1961 1962 1963 1964 1965 1966 1967 1968 1969 1970 1971 1972 1973 1974 1975 1976 1977 1978 1979 1980 1981 1982 1983 1984 1985 1986 1987 1988 1989 1990 1991 1992 1993 1994 1995 1996 1997 1998 1999 2000 2001 2002 2003 2004 2005 2006 2007 2008 2009 2010 2011 2012 2013 2014 2015 2016 2017 2018 2019 2020 2021 2022 2023 2024 2025 2026 2027 2028 2029 2030 2031 2032 2033 2034 2035 2036 2037 2038 2039 2040 2041 2042 2043 2044 2045 2046 2047 2048 2049 2050 2051 2052 2053 2054 2055 2056 2057 2058 2059 2060 2061 2062 2063 2064 2065 2066 2067 2068 2069 2070 2071 2072 2073 2074 2075 2076 2077 2078 2079 2080 2081 2082 2083 2084 2085 2086 2087 2088 2089 2090 2091 2092 2093 2094 2095 2096 2097 2098 2099 2100 2101 2102 2103 2104 2105 2106 2107 2108 2109 2110 2111 2112 2113 2114 2115 2116 2117 2118 2119 2120 2121 2122 2123 2124 2125 2126 2127 2128 2129 2130 2131 2132 2133 2134 2135 2136 2137 2138 2139 2140 2141 2142 2143 2144 2145 2146 2147 2148 2149 2150 2151 2152 2153 2154 2155 2156 2157 2158 2159 2160 2161 2162 2163 2164 2165 2166 2167 2168 2169 2170 2171 2172 2173 2174 2175 2176 2177 2178 2179 2180 2181 2182 2183 2184 2185 2186 2187 2188 2189 2190 2191 2192 2193 2194 2195 2196 2197 2198 2199 2200 2201 2202 2203 2204 2205 2206 2207 2208 2209 2210 2211 2212 2213 2214 2215 2216 2217 2218 2219 2220 2221 2222 2223 2224 2225 2226 2227 2228 2229 2230 2231 2232 2233 2234 2235 2236 2237 2238 2239 2240 2241 2242 2243 2244 2245 2246 2247 2248 2249 2250 2251 2252 2253 2254 2255 2256 2257 2258 2259 2260 2261 2262 2263 2264 2265 2266 2267 2268 2269 2270 2271 2272 2273 2274 2275 2276 2277 2278 2279 2280 2281 2282 2283 2284 2285 2286 2287 2288 2289 2290 2291 2292 2293 2294 2295 2296 2297 2298 2299 2300 2301 2302 2303 2304 2305 2306 2307 2308 2309 2310 2311 2312 2313 2314 2315 2316 2317 2318 2319 2320 2321 2322 2323 2324 2325 2326 2327 2328 2329 2330 2331 2332 2333 2334 2335 2336 2337 2338 2339 2340 2341 2342 2343 2344 2345 2346 2347 2348 2349 2350 2351 2352 2353 2354 2355 2356 2357 2358 2359 2360 2361 2362 2363 2364 2365 2366 2367 2368 2369 2370 2371 2372 2373 2374 2375 2376 2377 2378 2379 2380 2381 2382 2383 2384 2385 2386 2387 2388 2389 2390 2391 2392 2393 2394 2395 2396 2397 2398 2399 2400 2401 2402 2403 2404 2405 2406 2407 2408 2409 2410 2411 2412 2413 2414 2415 2416 2417 2418 2419 2420 2421 2422 2423 2424 2425 2426 2427 2428 2429 2430 2431 2432 2433 2434 2435 2436 2437 2438 2439 2440 2441 2442 2443 2444 2445 2446 2447 2448 2449 2450 2451 2452 2453 2454 2455 2456 2457 2458 2459 2460 2461 2462 2463 2464 2465 2466 2467 2468 2469 2470 2471 2472 2473 2474 2475 2476 2477 2478 2479 2480 2481 2482 2483 2484 2485 2486 2487 2488 2489 2490 2491 2492 2493 2494 2495 2496 2497 2498 2499 2500 2501 2502 2503 2504 2505 2506 2507 2508 2509 2510 2511 2512 2513 2514 2515 2516 2517 2518 2519 2520 2521 2522 2523 2524 2525 2526 2527 2528 2529 2530 2531 2532 2533 2534 2535 2536 2537 2538 2539 2540 2541 2542 2543 2544 2545 2546 2547 2548 2549 2550 2551 2552 2553 2554 2555 2556 2557 2558 2559 2560 2561 2562 2563 2564 2565 2566 2567 2568 2569 2570 2571 2572 2573 2574 2575 2576 2577 2578 2579 2580 2581 2582 2583 2584 2585 2586 2587 2588 2589 2590 2591 2592 2593 2594 2595 2596 2597 2598 2599 2600 2601 2602 2603 2604 2605 2606 2607 2608 2609 2610 2611 2612 2613 2614 2615 2616 2617 2618 2619 2620 2621 2622 2623 2624 2625 2626 2627 2628 2629 2630 2631 2632 2633 2634 2635 2636 2637 2638 2639 2640 2641 2642 2643 2644 2645 2646 2647 2648 2649 2650 2651 2652 2653 2654 2655 2656 2657 2658 2659 2660 2661 2662 2663 2664 2665 2666 2667 2668 2669 2670 2671 2672 2673 2674 2675 2676 2677 2678 2679 2680 2681 2682 2683 2684 2685 2686 2687 2688 2689 2690 2691 2692 2693 2694 2695 2696 2697 2698 2699 2700 2701 2702 2703 2704 2705 2706 2707 2708 2709 2710 2711 2712 2713 2714 2715 2716 2717 2718 2719 2720 2721 2722 2723 2724 2725 2726 2727 2728 2729 2730 2731 2732 2733 2734 2735 2736 2737 2738 2739 2740 2741 2742 2743 2744 2745 2746 2747 2748 2749 2750 2751 2752 2753 2754 2755 2756 2757 2758 2759 2760 2761 2762 2763 2764 2765 2766 2767 2768 2769 2770 2771 2772 2773 2774 2775 2776 2777 2778 2779 2780 2781 2782 2783 2784 2785 2786 2787 2788 2789 2790 2791 2792 2793 2794 2795 2796 2797 2798 2799 2800 2801 2802 2803 2804 2805 2806 2807 2808 2809 2810 2811 2812 2813 2814 2815 2816 2817 2818 2819 2820 2821 2822 2823 2824 2825 2826 2827 2828 2829 2830 2831 2832 2833 2834 2835 2836 2837 2838 2839 2840 2841 2842 2843 2844 2845 2846 2847 2848 2849 2850 2851 2852 2853 2854 2855 2856 2857 2858 2859 2860 2861 2862 2863 2864 2865 2866 2867 2868 2869 2870 2871 2872 2873 2874 2875 2876 2877 2878 2879 2880 2881 2882 2883 2884 2885 2886 2887 2888 2889 2890 2891 2892 2893 2894 2895 2896 2897 2898 2899 2900 2901 2902 2903 2904 2905 2906 2907 2908 2909 2910 2911 2912 2913 2914 2915 2916 2917 2918 2919 2920 2921 2922 2923 2924 2925 2926 2927 2928
2019-11-30 10:08:44 -0800  Kevin McCarthy  <[email protected]> (b1d99670)

        * Set UPDATING file release date for 1.13.0.

M	UPDATING

2019-11-30 09:56:16 -0800  Kevin McCarthy  <[email protected]> (0950403f)

        * Change "Prf Enc" to "Prf Encr".
        
        Make the abbreviation a bit clearer, that it means Encryption instead
        of Encoding.
        
        Thanks to Morten Bo Johansen for the suggestion.

M	autocrypt/autocrypt_acct_menu.c
M	po/ca.po
M	po/cs.po
M	po/da.po
M	po/de.po
M	po/ja.po
M	po/ru.po
M	po/uk.po

2019-11-29 18:22:49 +0100  Olaf Hering  <[email protected]> (c6845bd1)

        * Update de.po
        
        Sync from mutt.pot after 'make update-po'
        
        Signed-off-by: Olaf Hering <[email protected]>

M	po/de.po

2019-11-28 07:13:47 +0000  Tamotsu TAKAHASHI  <[email protected]> (e8214c87)

        * Update copyright year

M	po/ja.po

2019-11-28 06:59:47 +0000  Tamotsu TAKAHASHI  <[email protected]> (be4801f8)

        * Update ja.po

M	po/ja.po

2019-11-25 15:36:48 -0800  Kevin McCarthy  <[email protected]> (220a4c91)

        * Clarify $write_bcc documentation.
        
        The wording was ambiguous, and could give the impression that a
        message, if fcc'ed, would contain the Bcc header when sent too.

M	init.h

2019-11-23 19:45:20 -0800  Kevin McCarthy  <[email protected]> (54aa06f7)

        * Add a bit more documentation about sending.
        
        Although the behavior has now been fixed, add $write_bcc references to
        $record, $sendmail, and $smtp_url to make users more aware of the
        behavior.

M	doc/manual.xml.head
M	init.h

2019-11-23 18:33:28 -0800  Kevin McCarthy  <[email protected]> (acca75f2)

        * Minor UPDATING file edits.

M	UPDATING

2019-11-23 18:22:24 -0800  Ivan Vilata i Balaguer  <[email protected]> (b302a3e7)

        * Updated Catalan translation.

M	po/ca.po

2019-11-20 13:23:00 -0800  Petr Pisar  <[email protected]> (2e3f535a)

        * Updated Czech translation.

M	po/cs.po

2019-11-20 12:21:24 -0800  Vsevolod Volkov  <[email protected]> (2e3e9556)

        * Updated Russian translation.

M	po/ru.po

2019-11-20 12:19:47 -0800  Vsevolod Volkov  <[email protected]> (0c0f4518)

        * Updated Ukrainian translation.

M	po/uk.po

2019-11-18 12:54:26 -0800  Morten Bo Johansen  <[email protected]> (f84c1fba)

        * Updated Danish translation.

M	po/da.po

2019-11-16 21:40:27 +0100  Olaf Hering  <[email protected]> (40e7c914)

        * Update de.po
        
        Signed-off-by: Olaf Hering <[email protected]>

M	po/de.po

2019-11-14 20:10:35 -0800  Kevin McCarthy  <[email protected]> (33604971)

        * Add initial UPDATING file entries for 1.13.0.
        
        This is just an initial version, complete with typos and other
        mistakes.  Committing now so translators can refer to it.

M	UPDATING

2019-11-13 20:09:37 -0800  Kevin McCarthy  <[email protected]> (24ca73ae)

        * Fix $fcc_attach to not prompt in batch mode.
        
        Include attachments if it is 'yes' or 'ask-yes', like $copy and
        $send_multipart_alternative.

M	send.c

2019-11-13 19:28:11 -0800  Kevin McCarthy  <[email protected]> (06698649)

        * Change $send_multipart_alternative to run in batch mode on ask-yes.
        
        Emulate the behavior of $copy, which performs fcc for 'yes' or
        'ask-yes' values.

M	send.c

2019-11-13 17:51:04 +0000  madroach  <[email protected]> (e850e89f)

        * allow autoview preview of multipart/alternative content
        
        add view-alt function, so now we have
         * view-alt "v"
         * view-alt-text "Esc v"
         * view-alt-mailcap "V"

M	OPS
M	compose.c
M	doc/manual.xml.head
M	functions.h

2019-11-13 00:27:28 +0000  David Champion  <[email protected]> (20c7b0d8)

        * Fix __attribute__((warn_unused_result)) issue in query.c
        
        Changing to mutt_read_line() avoids -Wunused-result warning while
        reading the ignored line in query protocol response.

M	query.c

2019-11-13 00:27:27 +0000  David Champion  <[email protected]> (f098ac2d)

        * Fix __attribute__((warn_unused_result)) issue in help.c

M	help.c

2019-11-13 00:27:27 +0000  David Champion  <[email protected]> (09dfed3f)

        * Fix __attribute__((warn_unused_result)) warning in enter.c

M	enter.c

2019-11-13 00:27:25 +0000  David Champion  <[email protected]> (317b7f6b)

        * Fixes unchecked return from link() in dotlock.c

M	dotlock.c

2019-11-11 10:06:44 +0000  David Champion  <[email protected]> (afb14d62)

        * Update copyrights

M	COPYRIGHT

2019-11-11 10:06:44 +0000  David Champion  <[email protected]> (d8b9f793)

        * Update patchlist.sh to support `guilt' patch queues

M	patchlist.sh

2019-11-10 19:58:43 -0800  Kevin McCarthy  <[email protected]> (88f26048)

        * Add gcc comments for fallthrough case statements.
        
        Most of these were already commented.  Change a few of them to
        a format gcc will recognize.  In the future, we'll want to change to
        whatever is standardized.

M	addrbook.c
M	autocrypt/autocrypt_gpgme.c
M	browser.c
M	compose.c
M	curs_main.c
M	doc/makedoc.c
M	enter.c
M	handler.c
M	hdrline.c
M	pager.c
M	pattern.c
M	pgppacket.c
M	query.c
M	recvattach.c
M	signal.c
M	smime.c

2019-11-10 18:50:41 -0800  Kevin McCarthy  <[email protected]> (aae2d87a)

        * Add $count_alternatives to count attachments inside alternatives.
        
        Some mail clients (*cough* Apple Mail) have started to put email
        attachments in one of the multipart/alternative branches.
        
        The config changes the searching to recurse inside alternatives when
        performing attachment counting.

M	doc/manual.xml.head
M	init.h
M	mutt.h
M	parse.c

2019-11-10 15:09:54 -0800  Kevin McCarthy  <[email protected]> (5835f4c0)

        * Remove nonreentrant calls from exit_handler()
        
        _() can invoke malloc, so remove l10n translations.
        
        printf() is not safe either, so use write().
        
        I'm not sure at this point about curs_set() and endwin(), but they
        seem important enough for proper terminal cleanup to risk leaving in.
        
        Thanks to Oswald Buddenhagen for pointing out the problem, and the old
        trac ticket from Vincent at:
        <https://gitlab.com/muttmua/trac-tickets/raw/master/tickets/open/3791-SIGQUIT_Ctrl_while_opening_mailbox_made_Mutt_hang.txt>

M	signal.c

2019-11-09 13:43:11 -0800  Kevin McCarthy  <[email protected]> (183c4687)

        * Add markdown2html contrib script.
        
        This was contributed by martin f. kraft, to give an example script for
        the new $send_multipart_alternative_filter funtionality.

M	contrib/Makefile.am
A	contrib/markdown2html

2019-11-09 13:29:16 -0800  Kevin McCarthy  <[email protected]> (202ec2c8)

        * Remove input buffer flush on sigwinch in index.
        
        I recall seeing a message on IRC, where someone reported their macro
        suddenly aborting after invoking an editor or something similar.  At
        the time, I wasn't sure of the problem, but this seems a likely
        culprit, if the event caused a sigwinch.
        
        Neither the menu.c nor the pager.c SigWinch handlers do such a thing.
        The line was part of the initial import 21 years ago, so there is no
        justification given.

M	curs_main.c

2019-11-08 08:07:21 -0800  Kevin McCarthy  <[email protected]> (ef7e5e42)

        * Fix sigwinch race in the index and menu processor.
        
        Reset the SigWinch flag before the screen resize/reflow, not afterwards.

M	curs_main.c
M	menu.c

2019-11-07 19:33:31 -0800  Kevin McCarthy  <[email protected]> (c64baf93)

        * Change $write_bcc to default off.
        
        Change Fcc'ing to always write a Bcc header regardless of the setting.
        
        Update the variable documentation to note the difference when Fcc'ing.

M	init.h
M	mutt.h
M	sendlib.c

2019-11-07 15:06:53 -0800  Kevin McCarthy  <[email protected]> (29167ecf)

        * Block multipart type alternatives generation.
        
        Since generating multipart types using
        $send_multipart_alternative_filter will not send properly, display an
        error message and block alternatives of that type.

M	sendlib.c

2019-11-07 02:14:05 +0000  David Champion  <[email protected]> (127bcc3c)

        * s/Mercurial/Git/ in INSTALL

M	INSTALL

2019-11-06 10:43:09 -0800  Kevin McCarthy  <[email protected]> (ab9b7b08)

        * Ensure APP_PGP flag is enabled for autocrypt.
        
        There was no code that explicitly enabled APP_PGP mode when either the
        recommendation engine or autocrypt menu were invoked.  This would
        cause the actual encryption to fail when sending.
        
        This was hidden by the $crypt_opportunistic_encrypt config, which does
        ensure it gets turned on.  I can only guess that this variable is
        popular with the autocrypt early adopters too.
        
        Also explicity enable APP_PGP for $autocrypt_reply.  We can't rely on
        $crypt_autopgp to turn this on.

M	compose.c
M	send.c

2019-10-29 13:53:20 +0800  Kevin McCarthy  <[email protected]> (0e566a03)

        * Add ability to generate multipart/alternative using a filter script.
        
        Create config variables $send_multipart_alternative (a quadoption)
        and $send_multipart_alternative_filter.  The filter script expects
        output to be the mime type, a blank line, then the content.
        
        Add ability to preview alternative from compose menu.  <view-alt-text>
        forces viewing as text.  <view-alt-mailcap> forces using the mailcap.
        Bind them to 'v' and 'V', respectively.
        
        Improve <resend-message> so a multipart/alternative is stripped out,
        which would just confuse the compose menu.  Currently this preserves
        the first alternative.
        
        Allow alternative generation in batch mode, as long as the quadoption
        is set to 'yes'.

M	OPS
M	compose.c
M	doc/manual.xml.head
M	functions.h
M	globals.h
M	init.h
M	mutt.h
M	postpone.c
M	protos.h
M	send.c
M	sendlib.c

2019-10-29 14:58:57 +0800  Kevin McCarthy  <[email protected]> (3f911681)

        * Create multipart/mixed helpers.
        
        Since we will be dealing with multipart/alternative, we need the
        helpers to be a bit more specific.
        
        We need to distinguish a top-level multipart/alternative from a
        multipart/mixed created because of attachments.

M	compose.c
M	main.c
M	postpone.c
M	protos.h
M	send.c
M	sendlib.c

2019-10-31 13:58:22 +0100  Fabian Groffen  <[email protected]> (4cec4b63)

        * mutt_parse_content_type: work around annoying charset behaviour from Outlook
        
        MS Outlook seems to add charset=charset=utf-8 to Content-Type, which
        results in charset_utf-8 inside Mutt, which in turn confuses others.
        
        Strip a leading charset= from charset, so we work around this odd
        behaviour.
        
        Signed-off-by: Fabian Groffen <[email protected]>

M	parse.c

2019-10-29 13:21:51 +0800  Kevin McCarthy  <[email protected]> (e9ab7539)

        * Convert smime_decrypt_mime() to use buffer pool.

M	smime.c

2019-10-28 18:59:02 +0800  Kevin McCarthy  <[email protected]> (ccf3f493)

        * Convert smime_handle_entity() to use buffers.
        
        Because of the mutt_body_handler() invocation, we avoid using the
        buffer pool.

M	smime.c

2019-10-28 12:36:29 +0800  Kevin McCarthy  <[email protected]> (05805ddd)

        * Convert smime_verify_one() to use buffer pool.

M	smime.c

2019-10-28 12:22:45 +0800  Kevin McCarthy  <[email protected]> (56856d8e)

        * Convert smime_sign_message() to use buffer pool.

M	smime.c

2019-10-27 19:29:41 +0800  Kevin McCarthy  <[email protected]> (ce55dbbf)

        * Convert smime_build_smime_entity() to use buffer pool.

M	smime.c

2019-10-27 15:47:55 +0800  Kevin McCarthy  <[email protected]> (07e32b7a)

        * Convert smime_invoke_import() and helpers to use buffer pool.

M	smime.c

2019-10-27 13:28:59 +0800  Kevin McCarthy  <[email protected]> (d4c00c67)

        * Convert smime_verify_sender() and helpers to use buffer pool.

M	smime.c

2019-10-27 11:09:00 +0800  Kevin McCarthy  <[email protected]> (7c81cd61)

        * Convert smime_get_candidates() to use buffer pool.

M	smime.c

2019-10-26 19:36:33 +0800  Kevin McCarthy  <[email protected]> (7e29eb23)

        * Convert mutt_write_fcc() to use buffer pool.

M	sendlib.c

2019-10-25 19:29:56 +0800  Kevin McCarthy  <[email protected]> (58a81897)

        * Convert _mutt_bounce_message to use buffer pool.

M	sendlib.c

2019-10-25 19:13:50 +0800  Kevin McCarthy  <[email protected]> (8de05d5f)

        * Convert send_msg() $sendmail_wait to use buffer pool.

M	sendlib.c

2019-10-25 15:55:49 +0800  Kevin McCarthy  <[email protected]> (3565f686)

        * Convert transform_to_7bit() to use buffer pool.

M	sendlib.c

2019-10-25 15:28:25 +0800  Kevin McCarthy  <[email protected]> (671e653c)

        * Convert mutt_message_to_7bit() to use buffer.
        
        Clean up the error handling a bit.
        
        Because of the recursive invocation, avoid the buffer pool in this
        case.

M	sendlib.c

2019-10-24 14:46:06 +0800  Kevin McCarthy  <[email protected]> (c5d770ea)

        * Convert fcc to a buffer.
        
        This affects the send.c flow (ci_send_message()), the compose menu,
        and various helper functions.

M	compose.c
M	edit.c
M	headers.c
M	hook.c
M	postpone.c
M	protos.h
M	send.c
M	sendlib.c

2019-10-24 11:23:20 +0800  Kevin McCarthy  <[email protected]> (2fcde005)

        * Convert send_message() to use buffer pool.

M	send.c

2019-10-23 19:17:09 +0800  Kevin McCarthy  <[email protected]> (12cd2d52)

        * Add typelen parameter to rfc1524_mailcap_lookup().
        
        Because of mime_lookup commands, the call to mutt_check_lookup_list()
        inside the function can modify the passed in type.  Add an explicit
        length parameter to the function, rather than assume the parameter
        size.  This also makes it more evident the type parameter can be
        modified to callers.
        
        Change the len parameter to mutt_check_lookup_list() to type size_t,
        just to be correct about it.

M	attach.c
M	handler.c
M	protos.h
M	recvattach.c
M	rfc1524.c
M	rfc1524.h

2019-10-23 19:01:17 +0800  Kevin McCarthy  <[email protected]> (8997c55f)

        * Convert rfc1524_mailcap_lookup() to use buffer pool for path.
        
        Adjust the rfc1524_mailcap_parse() and get_field_text() filename and
        type parameters to be const.
        
        Note that the sizeof(type) needs to be passed to
        rfc1524_mailcap_lookup().  I'll fix that next.

M	rfc1524.c

2019-10-23 16:03:56 +0800  Kevin McCarthy  <[email protected]> (6380cbd6)

        * Convert mutt_attach_reply() to use buffer pool.

M	recvcmd.c

2019-10-23 15:36:59 +0800  Kevin McCarthy  <[email protected]> (8d12d900)

        * Convert attach_forward_msgs() to use buffer pool.

M	recvcmd.c

2019-10-23 15:04:49 +0800  Kevin McCarthy  <[email protected]> (0b59dc75)

        * Convert attach_forward_bodies to use buffer pool.

M	recvcmd.c

2019-10-23 14:44:47 +0800  Kevin McCarthy  <[email protected]> (1f71fad9)

        * Convert attach_fmt %f to use buffer pool.

M	recvattach.c

2019-10-23 14:33:09 +0800  Kevin McCarthy  <[email protected]> (80bc61db)

        * Convert mutt_num_postponed() maildir check to use buffer pool.

M	postpone.c

2019-10-23 13:53:26 +0800  Kevin McCarthy  <[email protected]> (d8b6f94e)

        * Convert pop_fetch_message() to use buffer pool.

M	pop.c

2019-10-23 11:39:22 +0800  Kevin McCarthy  <[email protected]> (08480fa8)

        * Convert pop_read_header() to use buffer pool.

M	pop.c

2019-10-20 15:52:22 +0800  Kevin McCarthy  <[email protected]> (5b53290a)

        * Convert pgp_find_hash to use buffer pool.

M	pgpmicalg.c

2019-10-20 15:27:10 +0800  Kevin McCarthy  <[email protected]> (26e89164)

        * Convert pgp_make_key_attachment() to use buffer pool.

M	pgpkey.c

2019-10-20 14:06:24 +0800  Kevin McCarthy  <[email protected]> (15f89f8e)

        * Remove make_key_attachment parameter.
        
        The parameter is not actually used anywhere.  The next commit will
        convert the classic pgp implementation to use the buffer pool.  This
        change will simplify the logic.

M	compose.c
M	crypt-gpgme.c
M	crypt-gpgme.h
M	crypt-mod-pgp-classic.c
M	crypt-mod-pgp-gpgme.c
M	crypt-mod.h
M	cryptglue.c
M	mutt_crypt.h
M	pgp.h
M	pgpkey.c
M	send.c

2019-10-20 13:41:30 +0800  Kevin McCarthy  <[email protected]> (e3408a00)

        * Convert pgp_select_key() to use buffer pool.

M	pgpkey.c

2019-10-19 15:50:22 +0800  Kevin McCarthy  <[email protected]> (782bcd7d)

        * Convert pgp_traditional_encryptsign() to use buffer pool.

M	pgp.c

2019-10-19 15:35:06 +0800  Kevin McCarthy  <[email protected]> (978cdaf7)

        * Convert pgp_encrypt_message() to use buffer pool.

M	pgp.c

2019-10-19 15:07:53 +0800  Kevin McCarthy  <[email protected]> (38291748)

        * Convert pgp_sign_message to use buffer pool.

M	pgp.c

2019-10-19 14:48:17 +0800  Kevin McCarthy  <[email protected]> (48a34377)

        * Convert pgp_encrypted_handler() to use buffer pool.

M	pgp.c

2019-10-18 15:05:33 +0800  Kevin McCarthy  <[email protected]> (aa66b414)

        * Convert pgp_decrypt_mime() to use buffer pool.

M	pgp.c

2019-10-18 14:41:06 +0800  Kevin McCarthy  <[email protected]> (e383f5c9)

        * Convert pgp_decrypt_part() to use buffer pool.

M	pgp.c

2019-10-18 14:29:56 +0800  Kevin McCarthy  <[email protected]> (f3bfb7d1)

        * Convert pgp_extract_keys_from_attachment() to use buffer pool.

M	pgp.c

2019-10-18 14:21:19 +0800  Kevin McCarthy  <[email protected]> (e2722551)

        * Convert pgp_verify_one() to use buffer pool.

M	pgp.c

2019-10-18 14:02:02 +0800  Kevin McCarthy  <[email protected]> (c1f9f00f)

        * Convert pgp_check_traditional_one_body() to use buffer pool.

M	pgp.c

2019-10-17 18:34:55 +0800  Kevin McCarthy  <[email protected]> (e750e39c)

        * Clean up pager change folder aborts to return to pager.
        
        Changing folder from within the pager behaved inconsistently when
        aborting, or upon a normal error.  It would sometimes return the pager
        and other times return to the index.
        
        Ensure it returns to the pager, except in the case where
        mx_close_mailbox() fails due to a new mail or reopen event.  In that
        case we likely want to be in the index - the message we were viewing
        could have disappeared or relocated.

M	curs_main.c

2019-10-17 17:30:03 +0800  Kevin McCarthy  <[email protected]> (b15e8659)

        * Remove menu->menu hack when redirecting pager ops through index.
        
        As noted in commit a327386c, this causes problems when redirecting ops
        that open new menus.  There is no need to change the menu->menu type,
        as a flag works perfectly well with no such side effects.
        
        This also removes the need for comments explaning the hack before
        mutt_folder_hooks() when changing folders, or before displaying a
        message in the pager.

M	curs_main.c

2019-10-17 16:01:11 +0800  Kevin McCarthy  <[email protected]> (e5f24ca8)

        * Merge branch 'stable'

2019-10-17 15:48:31 +0800  Kevin McCarthy  <[email protected]> (a327386c)

        * Stable branch quick fix for pager change-mailbox push/exec bug.
        
        The menu functions mutt_push/pop_current_menu() keep track of the menu
        stack, automatically setting CurrentMenu when exiting menus.
        
        The only gotcha was the function sharing between the index and pager
        menus.  The index uses a hack, setting menu->menu to MENU_PAGER for
        operations redirecting through the index and back to the pager
        afterwards.
        
        I thought this was covered by the restoration of the menu before
        returning to the pager, or when exiting the index switch.  However it
        is not: invoking other menus, such as the browser, will result in
        CurrentMenu being set to the Pager when exiting those (by
        mutt_pop_current_menu()).  This can result in folder hooks failing for
        unshared functions.
        
        A better fix is to remove the hack of using menu->menu, because this
        can easily cause a problem in the future in other situations.  (I will
        make this fix in master next.)  For the stable branch, I am explicitly
        setting/restoring CurrentMenu before invoking the folder hooks.

M	curs_main.c

2019-10-16 15:42:54 +0800  Kevin McCarthy  <[email protected]> (30b1ff48)

        * Convert pgp_app_handler to use buffer pool.
        
        Rename the pgp_copy_checksig() and mutt_wait_filter() return code
        variables to provide more clarity, and to make the purpose and
        assignment of rc more obvious.
        
        Change tmpfname creation failure to be like pgpoutfile and
        pgperrfile, by going to the cleanup point.

M	pgp.c

2019-10-16 14:41:04 +0800  Kevin McCarthy  <[email protected]> (f566f734)

        * Convert msg_search to use buffer.
        
        Avoid the buffer pool because of the long life cycle (across the
        invocation of mutt_body_handler().

M	pattern.c

2019-10-16 14:13:05 +0800  Kevin McCarthy  <[email protected]> (23bfc45f)

        * Convert mx_close_mailbox() to use buffer pool.

M	mx.c

2019-10-15 15:26:20 +0800  Kevin McCarthy  <[email protected]> (9506db1e)

        * Reduce line buffer size in mx_get_magic().
        
        tmp is only used for mbox and mmdf iniital line examination.  That
        only needs to look at 6 characters from the first line.

M	mx.c

2019-10-15 14:52:26 +0800  Kevin McCarthy  <[email protected]> (0944e898)

        * Convert mutt_save_confirm() to use buffer pool.
        
        These are prompts, so don't really need the larger, dynamic
        capability, but it might not hurt for a larger path.

M	muttlib.c

2019-10-15 14:38:07 +0800  Kevin McCarthy  <[email protected]> (48847904)

        * Removed unused mutt_expand_link()

M	muttlib.c
M	protos.h

2019-10-15 14:33:02 +0800  Kevin McCarthy  <[email protected]> (140cd885)

        * Change ssl_init to use buffer pool for rand filename.

M	mutt_ssl.c

2019-10-15 13:48:59 +0800  Kevin McCarthy  <[email protected]> (5572a302)

        * Convert mbox_sync_mailbox() to use buffer pool.
        
        Rewrite return(-1) to a new fatal target to ensure cleanup.
        
        Remove some repetitive unlink(tempfile) operations by adding a new
        flag pointing when to start and stop that during a bail.

M	mbox.c

2019-10-13 16:25:54 +0800  Kevin McCarthy  <[email protected]> (71d6dbea)

        * Update mime fields when piping a message with $pipe_decode set.
        
        Programs that process the message may get confused if the original
        mime fields are in the output.  Add the CH_MIME flag to strip mime
        headers and CH_TXTPLAIN to add decoded text mime headers in their
        place, just as <decode-copy> does.
        
        However, make sure not to add the flags when printing, as printers
        highly likely won't care and users probably don't want to see those
        headers in their printout.

M	commands.c

2019-10-11 19:31:58 +0800  Kevin McCarthy  <[email protected]> (9a1b08bf)

        * Merge branch 'stable'

2019-10-11 19:17:58 +0800  Beck, Andre  <[email protected]> (937a1eb1)

        * Clear connection input buffer when closing.
        
        An RFC-violating reply from the Dovecot SMTP submission service
        uncovered a bug in Mutt.  Mutt was not clearing out the input buffer
        when closing the connection.
        
        Dovecot was including an extra 250 response after data submission:
        
          DATA
          354 OK
          Subject: Test 3
        
          Test 3
          .
          250 2.0.0  223 byte chunk, total 223
          250 2.0.0 OK id=1iIqT1-0004wS-Ac
          quit
          221 2.0.0 Bye
        
        The multiline 250 reply requires a hyphen in the first response.  Mutt
        closes the connection after the quit, but ends up leaving the
        unexpected second line in the input buffer.  This causes an error in
        the next usage of the connection.
        
        Clean out bufpos and available when closing the socket.

M	mutt_socket.c

2019-10-10 15:03:05 +0800  Kevin McCarthy  <[email protected]> (0e32b977)

        * Add new browse-mailboxes function in index and pager.
        
        This allows direct access to the mailboxes list in the folder menu.
        This is useful, for instance, if $browser_sticky_cursor is set and the
        current directory does not contain the open mailbox.  The macro
        version will lose the current mailbox while toggling to the mailboxes
        list.

M	OPS
M	curs_main.c
M	doc/Muttrc.head
M	functions.h

2019-10-09 12:59:41 +0800  Kevin McCarthy  <[email protected]> (e4c176b3)

        * Convert main() to use buffers for paths.
        
        Convert fpath (used for checking and creating $folder.
        
        Convert expanded_infile and tempfile which are used for the -i,-H, and
        -E options.  We allocate buffers, rather than use the pool, because
        they are used for the duration of the compose/send operation.

M	main.c
M	protos.h
M	send.c

2019-10-09 08:36:59 +0800  Kevin McCarthy  <[email protected]> (fe69e4d1)

        * Add sticky browser behavior for sorting.
        
        The menu isn't rebuilt after sorting, so the selected mailbox was not
        sticky for that operation.
        
        Refactor the sticky cursor setting out so it can be explicitly called
        after sorting too.

M	browser.c

2019-10-08 15:22:27 +0800  Kevin McCarthy  <[email protected]> (46223bc9)

        * Convert start_debug() to use buffer pool.

M	init.c

2019-10-08 15:21:44 +0800  Kevin McCarthy  <[email protected]> (fb2487c2)

        * Convert set/reset and source_rc to use buffers for paths.

M	init.c

2019-10-08 13:07:40 +0800  Kevin McCarthy  <[email protected]> (49c97808)

        * Convert parse_path_(un)list to use buffer pool for path.
        
        Don't use the buf parameter to avoid stretching it out, as it's used
        for the entire rc parsing, and typically just holds command names.

M	init.c

2019-10-08 12:28:30 +0800  Kevin McCarthy  <[email protected]> (d430f372)

        * Change message cache id to use SHORT_STRING.
        
        Even that is too big, but it doesn't make make sense to use
        _POSIX_PATH_MAX for the id string.

M	imap/message.c

2019-10-08 11:24:38 +0800  Kevin McCarthy  <[email protected]> (f055ff54)

        * Convert imap_cachepath() and callers to use buffers.

M	imap/imap_private.h
M	imap/message.c
M	imap/util.c

2019-10-07 10:39:44 +0800  Kevin McCarthy  <[email protected]> (dcdbdfee)

        * Convert imap fetch_new and fetch_message tempfiles to buffer pool.

M	imap/message.c

2019-10-07 09:55:39 +0800  Kevin McCarthy  <[email protected]> (2e0fc335)

        * Convert imap_open_new_message() to use buffer pool.

M	imap/imap.c

2019-10-06 16:32:42 +0800  Kevin McCarthy  <[email protected]> (3f5b0220)

        * Convert save-hook and fcc-hook to use buffer pool internally.
        
        The hook parameters still need to be converted, but I'm working
        towards it slowly.

M	hook.c
M	muttlib.c
M	protos.h

2019-10-06 13:37:14 +0800  Kevin McCarthy  <[email protected]> (8351c060)

        * Convert mutt_parse_hook() to use buffer pool.
        
        Remove the path variable, as this is not needed:
        mutt_buffer_expand_path() and mutt_check_simple() can operate directly
        on the pattern/command buffers.

M	hook.c

2019-10-05 14:10:04 +0800  Kevin McCarthy  <[email protected]> (43bc959c)

        * Convert shrink_histfile() tempfile to use buffer pool.

M	history.c

2019-10-05 13:59:57 +0800  Kevin McCarthy  <[email protected]> (bb62f172)

        * Convert mutt_help() to use buffer for tempfile.

M	help.c

2019-10-05 13:52:50 +0800  Kevin McCarthy  <[email protected]> (dafb1f38)

        * Convert mutt_edit_headers() to use buffer pool.

M	headers.c

2019-10-04 15:29:03 +0800  Kevin McCarthy  <[email protected]> (48cf1092)

        * Fix built-in pager checks for help and attachments.
        
        Mutt uses the built-in pager when $pager is unset too.  Fix a few
        checks to also handle that case.

M	help.c
M	muttlib.c

2019-09-30 18:50:27 -0700  Kevin McCarthy  <[email protected]> (a6bccbe1)

        * Memcpy header cache fetch values to ensure alignment.
        
        While testing the hcache buffer pool changes, I noticed a misaligned
        pointer warning when using LMDB.
        
        The other header cache backends must ensure alignment of the pointer
        they return, but LMDB apparently does not.
        
        Instead of directly assigning and dereferencing the pointer fetched,
        use memcpy to the appropriate type, just as the header cache restore
        operation does.

M	imap/imap.c
M	imap/message.c
M	imap/util.c
M	mh.c

2019-09-28 14:08:39 -0700  Kevin McCarthy  <[email protected]> (fb1686b6)

        * Convert hcache delete and open calls to use buffer pool.

M	hcache.c

2019-09-27 19:21:26 -0700  Kevin McCarthy  <[email protected]> (36ee8d39)

        * Convert hcache fetch and store raw to use buffer pool.

M	hcache.c

2019-09-27 18:12:27 -0700  Kevin McCarthy  <[email protected]> (a736d4a4)

        * Convert hcache_open to use buffer pool.
        
        Change the namer function and mutt_hcache_per_folder to operate on a
        buffer parameter.

M	hcache.c
M	hcache.h
M	imap/util.c
M	pop.c

2019-09-27 15:46:49 -0700  Kevin McCarthy  <[email protected]> (84c1b646)

        * Convert hcache db4 lockfile to buffer.

M	hcache.c

2019-09-27 14:42:45 -0700  Kevin McCarthy  <[email protected]> (34ad2134)

        * Convert run_decode_and_handler() to use buffer pool.

M	handler.c

2019-09-27 14:28:01 -0700  Kevin McCarthy  <[email protected]> (a4f99230)

        * Convert edit_one_message() to use buffer pool.

M	editmsg.c

2019-09-26 15:23:14 -0700  Kevin McCarthy  <[email protected]> (44349c11)

        * Convert mutt_error_history to use buffer pool.

M	curs_lib.c

2019-09-25 18:44:50 -0700  Kevin McCarthy  <[email protected]> (13965f79)

        * Convert crypt_extract_keys and signed handler to use buffers.

M	crypt-mod-smime-classic.c
M	crypt-mod.h
M	crypt.c
M	cryptglue.c
M	mutt_crypt.h
M	smime.c
M	smime.h

2019-09-25 15:28:30 -0700  Kevin McCarthy  <[email protected]> (fc0c2bee)

        * Convert crypt-gpgme to use BUFFER for tempfiles.
        
        Use the pool where possible, but when the function calls other
        long-running functions (such as mutt_body_handler() or
        mutt_do_pager()), allocate the buffer.
        
        smime_gpgme_decrypt_mime() was not freeing the "cur" BODY generated on
        error.  Add a call to mutt_free_body(cur) in the error handling.

M	crypt-gpgme.c

2019-09-22 15:59:27 -0700  Kevin McCarthy  <[email protected]> (4d2f645a)

        * Fix memory leak in compose write-fcc function.
        
        The outer multipart was not being freed after writing.

M	compose.c

2019-09-22 15:58:58 -0700  Kevin McCarthy  <[email protected]> (0637998b)

        * Convert compress setup_paths() to use buffer.

M	compress.c

2019-09-22 14:54:14 -0700  Kevin McCarthy  <[email protected]> (1ae6e10f)

        * Remove nonull check from _mutt_enter_fname()
        
        It was a mistake to add the check when converting to use buffers in
        commit 70ef4e9e.
        
        The buf must be non-null in the original version, and in this version
        we are copying results back to it afterwards.

M	curs_lib.c

2019-09-22 14:38:03 -0700  Kevin McCarthy  <[email protected]> (b4cd9852)

        * Convert compose menu fname variable to buffer.

M	compose.c

2019-09-22 14:16:56 -0700  Kevin McCarthy  <[email protected]> (5da50b4d)

        * Convert buffer callers of mutt_get_field() to use buffer version.

M	browser.c
M	curs_lib.c
M	muttlib.c
M	pattern.c
M	recvattach.c

2019-09-22 14:11:43 -0700  Kevin McCarthy  <[email protected]> (ecd0d6ed)

        * Create mutt_buffer_get_field().
        
        This will reduce the buffer->dptr fiddling all over the place into one
        spot until mutt_enter_string() can be converted.

M	curs_lib.c
M	protos.h

2019-09-21 19:41:28 -0700  Kevin McCarthy  <[email protected]> (4f89f530)

        * Convert compose check_attachments() to use buffer pool.
        
        Modify error message so that the filename comes last, to prevent a
        long path from hiding the error message or prompt.

M	compose.c

2019-09-21 18:34:51 -0700  Kevin McCarthy  <[email protected]> (4050cc43)

        * Fix mutt_save_message() "enter_fname()" to use buffer version.
        
        Commit be632f11 converted this function to use the buffer pool, but
        accidentally used the non-buffer prompt when there was already a
        buffer-converted version.

M	commands.c

2019-09-21 12:41:10 -0700  Kevin McCarthy  <[email protected]> (7ca52826)

        * Merge branch 'stable'

2019-09-21 12:36:56 -0700  Kevin McCarthy  <[email protected]> (34cd43c3)

        * automatic post-release commit for mutt-1.12.2

M	ChangeLog
M	VERSION

2019-09-19 18:52:24 -0700  Kevin McCarthy  <[email protected]> (192a6d0e)

        * Convert mutt_complete() to use the buffer pool.
        
        Add helper functions mutt_buffer_substrcpy() and
        mutt_buffer_concatn_path().
        
        Remove mutt_concatn_path() because mutt_complete() was the only
        caller.

M	buffer.c
M	buffer.h
M	complete.c
M	imap/imap.c
M	imap/imap.h
M	lib.c
M	lib.h
M	muttlib.c
M	protos.h

2019-09-15 15:41:42 -0700  Kevin McCarthy  <[email protected]> (a4b53e19)

        * Improve sidebar indentation and shortpath behavior.
        
        The previous implementation only enabled $sidebar_folder_indent for
        mailboxes underneath $folder.  Change indentation to be based upon the
        previous common-path mailbox in the list.  Indent one more than the
        common-path mailbox, rather than the number of delimiters after
        $folder.
        
        Change $sidebar_short_path to shorten based on the previous mailbox in
        the list too.
        
        Invoke mutt_buffer_pretty_mailbox() to prefix the mailbox with '~' or
        '=' characters.  This changes the output for the case where mailbox
        equals $folder, but provides uniform display behavior across mutt.
        
        Thanks to Christopher Zimmermann (@madroach) for the original patch,
        which this commit is based upon.

M	sidebar.c

2019-09-11 19:47:13 -0700  Kevin McCarthy  <[email protected]> (fa965230)

        * Convert print_attachment_list to use buffer pool.

M	recvattach.c

2019-09-11 19:40:48 -0700  Kevin McCarthy  <[email protected]> (70bb4fad)

        * Convert query_pipe_attachment to use buffer pool.

M	attach.c
M	protos.h
M	recvattach.c

2019-09-11 19:10:02 -0700  Kevin McCarthy  <[email protected]> (4142e2e5)

        * Convert recvattach save_attachment functions to use buffer pool.
        
        Convert utility functions prepend_curdir() and mutt_check_overwrite()
        to use BUFFER, as they are only used by those two functions.

M	muttlib.c
M	protos.h
M	recvattach.c

2019-09-11 16:23:46 -0700  Kevin McCarthy  <[email protected]> (be632f11)

        * Convert mutt_save_message() to use buffer pool.
        
        Change imap_copy_messages() dest parameter to const char *.
        
        mutt_default_save() will be converted to use a buffer next, removing
        the dptr fixups.

M	commands.c
M	imap/imap.h
M	imap/message.c

2019-09-11 15:55:01 -0700  Kevin McCarthy  <[email protected]> (67f4d1d0)

        * Convert mutt_display_message() to buffer pool.
        
        Remove an unused mime-type string generation at the top of the
        function too.  The code using the mime type was removed a long time
        ago in commit 246198ae.

M	commands.c

2019-09-09 18:39:19 -0700  Kevin McCarthy  <[email protected]> (f8e93908)

        * Merge branch 'stable'

2019-09-09 18:19:03 -0700  Kevin McCarthy  <[email protected]> (773166e9)

        * Change browser <display-filename> to show full_path.
        
        Prior to the introduction of display_name/full_path, it showed "name",
        which was the full IMAP URL but the shortname for folder/mailbox view.
        
        Now that the full_path is available, it makes sense to show that for
        all cases.

M	browser.c

2019-09-09 14:06:31 -0700  Kevin McCarthy  <[email protected]> (2e6d4903)

        * Convert remaining mutt_encode_path() call to use BUFFER.
        
        Then rename the other uses of mutt_buffer_encode_path() to
        mutt_encode_path().

M	bcache.c
M	hcache.c
M	muttlib.c
M	protos.h

2019-09-09 18:07:16 -0700  Kevin McCarthy  <[email protected]> (616b2063)

        * Merge branch 'stable'

2019-09-08 10:49:37 -0700  Kevin McCarthy  <[email protected]> (0fa71030)

        * Add $browser_sticky_cursor default set.
        
        This option attempts to keep the browser cursor on the same mailbox.
        
        It does this by keeping track of the current selected mailbox and
        comparing that when regenerating the menu.
        
        Modify imap_mailbox_create() and imap_mailbox_rename() to return the
        new mailbox name so it can be automatically selected.

M	browser.c
M	imap/browse.c
M	imap/imap.h
M	imap/imap_private.h
M	imap/util.c
M	init.h
M	mutt.h

2019-09-08 12:09:51 -0700  Kevin McCarthy  <[email protected]> (1600dd18)

        * Rename browser fields to display_name and full_path.
        
        Mailbox and Folder view don't make use of the desc field.  They store
        an abbreviated version in the name field and expand it when selecting
        or testing it.
        
        IMAP stores the full URL in name, and stores an abbreviated
        version (possibly with a trailing slash) in the desc field.
        
        The asymetricity makes it awkward, and interferes with a smart-cursor
        option in the next commit.  So instead rename the fields to
        "display_name" and "full_path".
        
        In Mailfox and Folder view, store the fully expanded path, which we
        have while iterating, in "full_path", and the shortened version in
        "display_name".
        
        Likewise in IMAP, store the full URL in "full_path" and the shortened
        version in "display_name".
        
        Simplify the code in browser.c to use the full_path instead of
        concatenating and expanding.

M	browser.c
M	browser.h
M	imap/browse.c

2019-09-06 16:14:08 -0700  Kevin McCarthy  <[email protected]> (ad72ec6c)

        * Convert bcache to use buffer pools.

M	bcache.c
M	muttlib.c
M	protos.h

2019-09-01 19:10:23 -0700  Kevin McCarthy  <[email protected]> (c28cba77)

        * Fix memory leak when attaching messages.
        
        Setting actx->idx[]->content->parts to NULL causes a memory leak,
        because message attachments store a BODY there that needs to be freed.
        
        I looked through the various use cases of ci_send_message() and
        actually believe content->parts will be NULL for all other cases
        except message attachments.  From the comment added to
        delete_attachment():
        
          Other ci_send_message() message constructors are careful to free
          any body->parts, removing depth:
           - mutt_prepare_template() used by postponed, resent, and draft files
           - mutt_copy_body() used by the recvattach menu and $forward_attachments.
        
          I believe it is safe to completely remove the "content->parts =
          NULL" statement.  But for safety, am doing so only for the case
          it must be avoided: message attachments.

M	compose.c

2019-09-01 13:25:06 -0700  Kevin McCarthy  <[email protected]> (aafe98ba)

        * Reuse the static space_stuff function for unstuffing.

M	rfc3676.c

2019-08-31 14:17:22 -0700  Kevin McCarthy  <[email protected]> (7949149a)

        * Remove manual note about space-stuffing only once.
        
        Stuffing is now performed each time.

M	doc/manual.xml.head

2019-08-31 13:37:16 -0700  Kevin McCarthy  <[email protected]> (4959e8d4)

        * Re-enable and cleanup format-flowed space stuffing.
        
        Commit 04cb5bde tried to fix re-stuffing a postponed message more than
        once, but unfortunately broke the normal case of composing a new
        message.  So actually, space-stuffing has been turned off the past 7
        years.
        
        Move format=flowed parameter setting below the standard message
        pre-processing block.  It shouldn't be performed for draft-files even
        with $resume_draft_files set.  Moving out of the block makes that
        clearer.
        
        Create mutt_rfc3676_space_(un)stuff() functions, which check the
        content type and stuff/unstuff apprpropriately.  Note that the
        stuff/unstuff does not depend on $text_flowed, which is only in charge
        of setting the format=flowed parameter.  This parameter can also come
        from resumed/resent/draft messages and should still be respected.
        
        Add unstuffing to mutt_prepare_template().  This is called by
        postponed, resent, and draft files.  This will prevent double-stuffing
        in those cases.
        
        Unstuff/restuff around editing the message in the compose menu, to
        keep everything transparent to the user.  I originally put the
        stuffing *after* the compose menu, but previewing the messages in the
        compose menu did not work properly in that case.  It's cleaner this
        way too.
        
        Change the stuff/unstuff functions to preserve the original
        hdr->content->filename.  The "hack" previously used would interact
        poorly with editable body files (mutt -i -E).  Fortunately space
        stuffing was pretty much disabled except in unusual cases before.

M	compose.c
M	doc/manual.xml.head
M	init.h
M	postpone.c
M	rfc3676.c
M	rfc3676.h
M	send.c

2019-08-31 13:36:28 -0700  Kevin McCarthy  <[email protected]> (af47e694)

        * Properly revert on an autocrypt postpone failure.

M	send.c

2019-08-28 14:47:15 -0700  Kevin McCarthy  <[email protected]> (aa6d4663)

        * Merge branch 'stable'

2019-08-28 20:22:10 +0000  Olaf Hering  <[email protected]> (2b8dc129)

        * de.po: proper translation for term collapse
        
        The intention of the term "collapse" is something like opening and
        closing an item. The initial translation which was added two decades
        ago means something like "breaks by weakness", which does not fit in
        the context of mutt.
        
        Use a term which means literally "opening and closing an item, like a
        book".
        
        Signed-off-by: Olaf Hering <[email protected]>

M	po/de.po

2019-08-20 15:37:06 -0700  Kevin McCarthy  <[email protected]> (c8ec78e1)

        * Clean up the autocrypt doc a bit more.

M	doc/manual.xml.head

2019-08-20 15:17:31 -0700  Kevin McCarthy  <[email protected]> (f7c70a02)

        * Update autocrypt keyring documentation.
        
        Recommend setting $autocrypt_dir to your normal keyring directory if
        you want to use your existing key.
        
        Trying to copy it over leads to signature verification issues.  Even
        if I reversed the order (which is much less clean), that would just
        lead to missing key signature errors for Autocrypt messages instead.

M	doc/manual.xml.head

2019-08-20 14:57:29 -0700  Kevin McCarthy  <[email protected]> (577d5d14)

        * Fix --with-sqlite3 test for autocrypt.
        
        Since $with_sqlite3 can contain a path, we want to check if it is
        "no", not that it isn't "yes".

M	configure.ac

2019-08-17 15:38:34 -0700  Kevin McCarthy  <[email protected]> (d4ec818a)

        * Add $ssl_use_tlsv1_3 config variable, default set.

M	init.h
M	mutt.h
M	mutt_ssl.c
M	mutt_ssl_gnutls.c

2019-06-28 15:09:51 -0700  Kevin McCarthy  <[email protected]> (be684ef2)

        * Add size display configuration variables.
        
        Although it would be nice to "open this up" more, performance and
        security/stability issues would arise.
        
        Based on the thread in mutt-dev, I hope these vars will satisfy most
        customization needs:
          $size_show_bytes
          $size_show_mb
          $size_show_fractions
          $size_units_on_left

M	doc/manual.xml.head
M	init.h
M	mutt.h
M	muttlib.c

2019-08-13 21:03:51 -0700  Kevin McCarthy  <[email protected]> (342b91cf)

        * Fix LibreSSL build.
        
        Apparently LibreSSL doesn't implement SSL_has_pending(), even for
        newer versions.

M	mutt_ssl.c

2019-08-13 15:14:37 -0700  Kevin McCarthy  <[email protected]> (536353c7)

        * Update POTFILES.in.
        
        The file was missing a few files with translation strings:
        copy.c, imap/auth_oauth.c, and safe_asprintf.c.

M	po/POTFILES.in

2019-07-28 07:54:32 -0700  Kevin McCarthy  <[email protected]> (8353407c)

        * Add checks for buffered OpenSSL or GnuTLS data when polling.
        
        I don't believe this has had an actual effect, because Mutt doesn't
        support renegotiation, and we are only polling immediately after
        sending NOOP.
        
        However, it looks like checking is technically the correct thing to do
        to avoid polling waiting for data that is already buffered.

M	mutt_ssl.c
M	mutt_ssl_gnutls.c

2019-08-13 14:20:33 -0700  Kevin McCarthy  <[email protected]> (fdfda1b7)

        * Mention base64 keydata being stored in the autocrypt database.

M	doc/manual.xml.head

2019-08-11 14:35:07 -0700  Kevin McCarthy  <[email protected]> (c79c769f)

        * Move LIBAUTOCRYPT before MUTTLIBS to fix building issues.

M	Makefile.am

2019-08-11 14:17:50 -0700  Kevin McCarthy  <[email protected]> (456737cd)

        * Add autocrypt and sqlite3 to .gitlab-ci.yml.

M	.gitlab-ci.yml

2019-08-09 14:15:18 -0700  Kevin McCarthy  <[email protected]> (ae332f72)

        * Add L10N comment about autocrypt menu help line abbreviations.

M	autocrypt/autocrypt_acct_menu.c

2019-08-09 13:58:55 -0700  Kevin McCarthy  <[email protected]> (9f692bd3)

        * Add a note about autocrypt first-run and macros.

M	doc/manual.xml.head

2019-08-09 13:37:08 -0700  Kevin McCarthy  <[email protected]> (b8e9dfc1)

        * Add autocrypt documentation about shared key and keyring strategies.

M	doc/manual.xml.head

2019-08-08 20:49:32 -0700  Kevin McCarthy  <[email protected]> (38f06669)

        * Minor autocrypt manual section updates.
        
        Mention key selection during account creation and $autocrypt_reply for
        controlling autocrypt mode setting during replies.

M	doc/manual.xml.head

2019-08-08 09:18:53 -0700  Kevin McCarthy  <[email protected]> (d0ef8c32)

        * Enabled writing protected subject with autocrypt too.

M	crypt.c

2019-08-07 18:34:58 -0700  Kevin McCarthy  <[email protected]> (1de46058)

        * Turn off macro processing during autocrypt initialization.
        
        The muttrc can push events into the macro buffer, with the assumption
        that mailbox will be opened next.  This will interfere with the
        prompts uses during first run.  The only issue is that macros won't
        work inside the folder browser, if invoked.

M	autocrypt/autocrypt.c

2019-08-07 18:24:15 -0700  Kevin McCarthy  <[email protected]> (41d9d9cf)

        * Allow nested setting of OPTIGNOREMACROEVENTS.
        
        This will be needed for the first-run of autocrypt initialization.
        The initialization involves a number of prompts, and can even use the
        folder browser.  The browser could in turn connect to IMAP which might
        invoke a certificate prompt, login prompt, etc.

M	curs_lib.c
M	mutt_ssl.c
M	mutt_ssl_gnutls.c

2019-08-07 14:31:53 -0700  Kevin McCarthy  <[email protected]> (04817c00)

        * Add $autocrypt_reply.
        
        This allows turning off the force-autocrypt mode when replying to an
        autocrypt email.

M	init.h
M	mutt.h
M	send.c

2019-08-07 14:17:28 -0700  Kevin McCarthy  <[email protected]> (01bc088c)

        * Automatically clear screen when popping the last menu.
        
        This removes the need to manually clear the screen during pre-menu
        operations, such as autocrypt first run initialization.

M	autocrypt/autocrypt.c
M	menu.c

2019-08-07 14:12:43 -0700  Kevin McCarthy  <[email protected]> (d55b0390)

        * Add ability to create autocrypt account from an existing key.
        
        This is useful when adding accounts, or for users who want to use an
        existing key from the keyring during initial account creation.

M	autocrypt/autocrypt.c
M	autocrypt/autocrypt_gpgme.c
M	autocrypt/autocrypt_private.h
M	crypt-gpgme.c
M	crypt-gpgme.h

2019-08-04 07:55:26 -0700  Kevin McCarthy  <[email protected]> (769a7765)

        * Don't try to decrypt autocrypt messages if the option is off.

M	cryptglue.c

2019-08-04 07:52:19 -0700  Kevin McCarthy  <[email protected]> (da54c660)

        * Manual typo fix.
        
        Thanks to Petr Pisar for pointing out the error.

M	doc/manual.xml.head

2019-08-03 13:53:40 -0700  Kevin McCarthy  <[email protected]> (1089deb0)

        * Add autocrypt README file

M	autocrypt/Makefile.am
A	autocrypt/README

2019-08-02 09:03:41 -0700  Kevin McCarthy  <[email protected]> (128127cb)

        * Add documentation for the autocrypt feature.

M	doc/manual.xml.head
M	init.h

2019-07-31 18:56:29 -0700  Kevin McCarthy  <[email protected]> (2822b4eb)

        * Add option to scan mailboxes during first run.
        
        The scanner will disable the header cache, allowing scanning all
        messages in the mailbox.

M	autocrypt/autocrypt.c
M	autocrypt/autocrypt_db.c
M	autocrypt/autocrypt_private.h

2019-07-31 15:42:09 -0700  Kevin McCarthy  <[email protected]> (e01b3f02)

        * Add more translation string comments for autocrypt.

M	autocrypt/autocrypt.c
M	autocrypt/autocrypt_acct_menu.c
M	autocrypt/autocrypt_db.c
M	autocrypt/autocrypt_gpgme.c
M	compose.c

2019-07-28 19:24:11 -0700  Kevin McCarthy  <[email protected]> (85bd11b0)

        * Basic autocrypt account menu.
        
        Provide ability to create, delete, and toggle the prefer-encrypt and
        enabled flag for an account.
        
        Hook into the index via 'A' <autocrypt-acct-menu>.

M	OPS
M	autocrypt/Makefile.am
M	autocrypt/autocrypt.c
M	autocrypt/autocrypt.h
A	autocrypt/autocrypt_acct_menu.c
M	autocrypt/autocrypt_db.c
M	autocrypt/autocrypt_private.h
M	curs_main.c
M	doc/manual.xml.tail
M	functions.h
M	globals.h
M	init.h
M	keymap.c
M	keymap.h
M	po/POTFILES.in

2019-07-30 19:14:56 -0700  Kevin McCarthy  <[email protected]> (36115604)

        * Convert peer_update to just pass the peer object.
        
        Unlike get and insert, there is no need for an addres parameter that
        needs to be normalized, since the address is already in the peer
        object.

M	autocrypt/autocrypt.c
M	autocrypt/autocrypt_db.c
M	autocrypt/autocrypt_private.h

2019-07-28 19:23:12 -0700  Kevin McCarthy  <[email protected]> (71e881a6)

        * Improve gen-map-doc work on multi-word maps.

M	doc/gen-map-doc

2019-07-27 15:34:51 -0700  Kevin McCarthy  <[email protected]> (e5463f57)

        * Add account->enabled checks.
        
        Add to ui recommendation, keylist generator, and autocrypt header
        writing routines.

M	autocrypt/autocrypt.c

2019-07-27 15:11:38 -0700  Kevin McCarthy  <[email protected]> (a7a5abe4)

        * Add prefer-encrypt prompt during account creation.

M	autocrypt/autocrypt.c

2019-07-27 13:44:36 -0700  Kevin McCarthy  <[email protected]> (ec6953f5)

        * Add AUTOCRYPT header to imap fetch list.
        
        If $autocrypt is set, add the header to make IMAP behave the same as
        other formats (parsing on initial mailbox opening).
        
        This will also be useful if we perform an initial scan during account
        creation, to make that work for IMAP too.

M	imap/message.c

2019-07-26 16:27:04 -0700  Kevin McCarthy  <[email protected]> (0d94a3dc)

        * Add L10N translation message comments.

M	autocrypt/autocrypt.c
M	autocrypt/autocrypt_db.c
M	autocrypt/autocrypt_gpgme.c
M	compose.c

2019-07-26 16:00:22 -0700  Kevin McCarthy  <[email protected]> (43c57659)

        * Add autocrypt source files to POTFILES.in

M	po/POTFILES.in

2019-07-26 15:59:47 -0700  Kevin McCarthy  <[email protected]> (baac6d68)

        * Print an error message if an autocrypt key can't be found.

M	autocrypt/autocrypt.c

2019-07-26 13:55:46 -0700  Kevin McCarthy  <[email protected]> (2aec979b)

        * Handle autocrypt message decryption.
        
        Try autocrypt first for crypt_pgp_decrypt_mime() and
        pgp_gpgme_encrypted_handler().
        
        Propagate the autocrypt bit if successful.  This is used when replying
        to an autocrypt message, to force a reply using autocrypt.

M	crypt-gpgme.c
M	crypt.c
M	cryptglue.c
M	handler.c
M	mutt.h

2019-07-25 19:12:32 -0700  Kevin McCarthy  <[email protected]> (d0a56a14)

        * Slightly improve the gossip header key update.
        
        Don't set an empty peer.gossip_keydata with a value that matches the
        current peer.keydata.  This just wastes space.

M	autocrypt/autocrypt.c

2019-07-24 18:59:07 -0700  Kevin McCarthy  <[email protected]> (78d028d7)

        * Fix process_gossip_headers() to look at the right envelope.

M	autocrypt/autocrypt.c
M	autocrypt/autocrypt.h
M	commands.c

2019-07-21 15:15:06 -0700  Kevin McCarthy  <[email protected]> (963fc1ba)

        * Autocrypt outgoing emails.
        
        Change crypt_get_keys() to query autocrypt.
        
        When oppenc_mode is set, we st