Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
M
morley
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 131
    • Issues 131
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 26
    • Merge requests 26
  • Requirements
    • Requirements
    • List
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
  • Analytics
    • Analytics
    • CI/CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Morley
  • morley
  • Merge requests
  • !547

Merged
Created Aug 11, 2020 by Roman Melnikov@rvemMaintainer8 of 8 tasks completed8/8 tasks

[#313] Carry annotations for typed PAIR

  • Overview 3
  • Commits 1
  • Pipelines 7
  • Changes 8

Description

Problem: Currently annotations for instructions are inherited from notes that are stored on the 'HST' during typecheck. Such behaviour can produce invalid field annotations for 'PAIR' instruction in case of special annotations (such as '%@').

Solution: Carry annotations for typed PAIR instructions separately, so that we are sure they are the same as for initial untyped instruction.

Related issue(s)

Resolves #313 (closed)

✅ Checklist for your Merge Request

Related changes (conditional)

  • Tests (see short guidelines)

    • If I added new functionality, I added tests covering it.
    • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • Documentation

    • I checked whether I should update the docs and did so if necessary:
      • Root README and other README.md files
      • Haddock
      • docs/
    • I updated changelog files of all affected packages released to Hackage if my changes are externally visible.

Stylistic guide (mandatory)

  • My commits comply with the following policy.
  • My code complies with the style guide.
Edited Aug 11, 2020 by Roman Melnikov
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: rvem/#313-dedicated-pair-instr-annotations