Extract "sender" argument from transfers in nettest
Clarification and motivation
In my proposal to improving batching interface there is a major issue: plain transfer
, call
and other methods accept sender explicitly, while for batches there can be only one sender for the entire batch so these methods do not fit.
This can be resolved if batched transfer
and other methods do not accept sender as an argument, rather it is specified separately (e.g. in the inBatch
method that runs the batch).
However, having plain tranfer
w/ sender and batched transfer
w/o sender may be confusing, and supporting all the mirrored versions (transfer
, lTrasnfer
, call
, callFrom
) would be an extra maintaince effort.
So in this ticket I propose to modify the existing nettest interface entirely so that instead of
transfer from whom ep arg
we wrote
with from $ transfer whom ep arg
And when with
is not specified, we used nettest
address.
Pros:
- Fewer methods to maintain in interface (
call
andcallFrom
get merged), harder to mess up with arguments. - The main issue of #403 (closed)'s proposal is automatically resolved (we just need to forbid
with
s insideinBatch
, and I suspect it will work so naturally).
I propose to implement with
via just keeping the address in NettestImpl
.
Related issues
Acceptance criteria
-
transfer
and other methods do not accept payer address expicitly; -
with
is implemented; - it is thoroughly thought out which methods should be affected by
with
(e.g. do we want to change originations' author?).