`expectNoUpdates` is quite useless
Clarification and motivation
We have a function that fails if previous operation has made any update. Recently we added GSIncrementCounter
storage update, it happens after every operation. So apparently expectNoUpdates
will always fail.
Acceptance criteria
I see two options:
- Remove
expectNoUpdates
completely. It seems to assert too much. There are different kinds of possible updates and this function tries to cover all of them and can break when we add a new update (that's what happened in this case). I find it better to use more granular functions likeexpectNoStorageUpdates
. But before removingexpectNoUpdates
we should check whether it's used anywhere (including other repos) and whether it's really useful there or we can change it toexpectNoStorageUpdates
. - Change
expectNoUpdates
to ignoreGSIncrementCounter
.
I prefer (1).