Project 'mordil/redistack' was moved to 'swift-server-community/RediStack'. Please update any links and bookmarks that may still have the old path.
Get pubsub numsub working
All threads resolved!
All threads resolved!
PUBSUB NUMSUB did not work
Expected Results
Command returns number of subscribers to list of channels.
Actual Results
Error. Two problems -
- command needs to be in two parts - command and sub command.
- the results need to be parsed in pairs - channel and count.
Steps to Reproduce
- Run the test I've just written.
Checklist:
-
Copyright headers in new files (see CONTRIBUTING.md) -
Unit test case to prevent the bug in the future
Merge request reports
Activity
- Resolved by Nathan Harris
- Resolved by Nathan Harris
@PeterAdams-A Great catch
I take it you ran into this in production? If so, I'm sorry for the bug!changed milestone to %2.0.0
added bug releasepatch labels
@Mordil No - I didn't run into this in production. I've started looking at the namespacing idea (https://gitlab.com/Mordil/RediStack/-/issues/94) so commands which return Channels or Keys are interesting test cases.
- Resolved by Peter Adams
@Mordil I have made both the changes you suggested.
mentioned in merge request !154 (merged)
added 4 commits
-
2c104b6d...e08b4261 - 2 commits from branch
Mordil:master
- decccae6 - Get pubsub numsub working
- 6c78280d - Address code review feedback
-
2c104b6d...e08b4261 - 2 commits from branch
mentioned in merge request !155 (merged)
Please register or sign in to reply