Skip to content
Snippets Groups Projects

Get pubsub numsub working

Merged Peter Adams requested to merge PeterAdams-A/RediStack:pubsubnumsub into master
All threads resolved!

PUBSUB NUMSUB did not work

Expected Results

Command returns number of subscribers to list of channels.

Actual Results

Error. Two problems -

  1. command needs to be in two parts - command and sub command.
  2. the results need to be parsed in pairs - channel and count.

Steps to Reproduce

  1. Run the test I've just written.

Checklist:

  • Copyright headers in new files (see CONTRIBUTING.md)
  • Unit test case to prevent the bug in the future

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Nathan Harris
  • @PeterAdams-A Great catch :face_palm: I take it you ran into this in production? If so, I'm sorry for the bug!

  • Nathan Harris changed milestone to %2.0.0

    changed milestone to %2.0.0

  • @Mordil No - I didn't run into this in production. I've started looking at the namespacing idea (https://gitlab.com/Mordil/RediStack/-/issues/94) so commands which return Channels or Keys are interesting test cases.

  • Peter Adams added 3 commits

    added 3 commits

    Compare with previous version

  • Nathan Harris resolved all threads

    resolved all threads

  • Nathan Harris approved this merge request

    approved this merge request

  • Nathan Harris mentioned in merge request !154 (merged)

    mentioned in merge request !154 (merged)

  • Peter Adams added 4 commits

    added 4 commits

    Compare with previous version

  • Peter Adams added 1 commit

    added 1 commit

    • 8783c9f4 - Remove accidental blank line addition.

    Compare with previous version

  • Peter Adams resolved all threads

    resolved all threads

  • Nathan Harris approved this merge request

    approved this merge request

  • merged

  • Nathan Harris mentioned in merge request !155 (merged)

    mentioned in merge request !155 (merged)

  • Please register or sign in to reply
    Loading