Skip to content

Jirafeau
Jirafeau
Switch branch/tag
  1. 22 Nov, 2019 7 commits
  3. 19 Nov, 2019 1 commit
  5. 12 Nov, 2019 2 commits
    • Erik Lundin's avatar
      Avoid code duplication when authorizing upload · ebcb7402
      Erik Lundin authored
      ebcb7402
    • Erik Lundin's avatar
      Fix upload IP check · a0040125
      Erik Lundin authored 
      If no IP addresses are listed at 'upload_ip_nopassword', index.php won't
show any login form and indicate the session as authenticated. During
the actual upload, script.php will show the error 'Error 2: No password
nor allowed IP'.

The reason is that jirafeau_challenge_upload_ip returns true if the
supplied IP whitelist is empty, but uploading without a password doesn't
work this way (and shouldn't).

I took the liberty to split 'jirafeau_challenge_upload_ip' into one
function for the normal IP check, and one for checking if allowed to
upload without a password. Having function names that clearly
communicates the intent makes it easier to avoid bugs.
      a0040125
  7. 11 Nov, 2019 7 commits
  9. 08 Nov, 2019 3 commits
  11. 05 Nov, 2019 3 commits
  13. 04 Nov, 2019 3 commits
  15. 22 Oct, 2019 5 commits
  17. 21 Oct, 2019 9 commits