Git Attributes file does not apply to submodules, potentially causes installation issues
Summary
Apologies if this is the wrong place for this issue but it was experienced during the overall installation process and it affects one or more submodules (engine, front, sockets).
There is a .gitattributes file in the main Minds repo but it does not trickle down to the submodules. This means that if a user has line endings converted on checkout the installation shell scripts will fail. Additionally, this would protect against improper line endings being committed directly to a submodule. Obviously this isn't a major issue as it primarily affects Windows developers that have the convert line endings git option enabled as default.
Steps to reproduce
- Set git to convert line endings on checkout
- Follow the Minds installation process
- Any step that runs a shell script will fail due to line endings
Platform information
Windows 10
What is the current bug behavior?
Submodules are checked out and converted according to the user's global git preferences. Installation shell scripts fail.
What is the expected correct behavior?
Files are forced to be checked out with unix-style line endings like the main repo
Relevant logs and/or screenshots
(Paste any relevant logs - please use code blocks (```) to format console output, logs, and code as it's very hard to read otherwise.)
Possible fixes
Copy .gitattributes from main repo to each submodule repository, modifying as necessary for those projects