Skip to content

[Sprint/TrendyTurtle](feat): Added in error message on socket connection breaking. #2115

Ben requested to merge feat/socket-error-comments-2115 into master

Summary

Closes #2115 (closed) MR to add an error message in to show the user when their connection to live comments has been lost.

Steps to test

This can be tested pretty simply.

  1. Make a post or go to visit one https://feat-socket-error-comments-2115.minds.io/newsfeed/1049089523444617221
  2. Keep the page open, drag the tab into its own window so you can watch it whilst you do step 3.
  3. On the pipeline of this MR. Run the stop job. Do not refresh the page.
  4. Wait and the disconnect message will show (because the stop job killed the sockets container)
  5. Don't close the window!
  6. Start the job again.
  7. The message should go away when the connection is re-established.

image

Estimated Regression Scope

The worst-case scenario is are that something could break in sockets or thread comments. E.g. the error showing at inappropriate times if the error is for some reason called more times than necessary on prod, or maybe the load more of the comments thread.

Edited by Ben

Merge request reports