Skip to content

[Sprint/TrendyTurtle](fix): Pro logo sign-in modal fix #2289

Ben requested to merge fix/pro-logo-modal-2289 into master

Closes #2289 (closed)

Summary:

This change behaves differently if you are on a subdomain.

https://subverse.net, vs https://www.minds.com/pro/subverse

Currently on production, on a subdomain, the logo of the pro user is supposed to show, but it does not. On a non sub-domain, the Minds logo is supposed to show up.

Issue's I'm aware of

There's two modals loading on non-subdomains. This looks a bit like a huge shadow. This is to be dealt with in another card here: minds#981 (closed)

Steps to reproduce

  1. First log out!
  2. Make a new account
  3. Log into admin and give the new account pro.

a) go to channel of the user you want to grant it to. b) hit the briefcase icon on the profile sidebar.

Standard Minds domain

  1. Log out again.
  2. Visit your new pro channel
  3. Verify your avatar is shown on the users pro profile
  4. Scrolling down it not logged in, should show the minds logo.
  5. Set a logo.
  6. Logo should show on page instead of avatar.
  7. Scroll down, modal should trigger and the Minds logo should still be shown.

On a subdomain

  1. Visit https://pro-domain--fix-pro-logo-modal-2289.minds.io/
  2. Click a new tab
  3. Scroll down
  4. In popup modal you should see your chosen logo.

Optionally, to make your own subdomain:

  1. Message me to vacate the above URL.
  2. go to fix-pro-logo-modal-2289.minds.io
  3. enable Pro on the channel you need
  4. go to Pro Settings > Domain > Enter pro-domain--fix-pro-logo-modal-2289.minds.io
  5. Click save
  6. Check that you have a pro logo set, if you don't, add one.
  7. On another tab, go to pro-domain--fix-pro-logo-modal-2289.minds.io
  8. You should see the Pro for the channel you set up
  9. Log out
No pro user set, avatar still shown

image

On a subdomain

image

minds.com/pro/

image

Edited by Ben

Merge request reports