Epic/wallet 80

Walkthrough video

TODO - can't do now because my environment imploded after latest pull so I can't record my screen...

Testing - to keep in mind

Things that might otherwise slip through the cracks:

• The Pro earnings column in the cash settings is only visible for Pro users
• The On-chain Transfer Modal is accessible by a link that is only visible to users who have an on-chain token address and a token balance > 0. (As I'm writing this, someone should probably double-check that the off-chain balance is > 0, not the total token balance.)
• Token onboarding in a browser that doesn't have MetaMask installed
• The cash-onboarding-extras.component.ts (which is only relevant to certain Stripe users)

Issues

Front

• The wallet uses this.session.getLoggedInUser.rewards() to determine the user's token onboarding status (e.g. whether to show the onboarding notice, which steps remain to be completed). Mark says that this should return true if their phone number has been verified, but on the review site I am getting false on my accounts that have already completed onboarding. So the page is indicating that I still need to verify my phone even though I already have
• the @Input() cashWallet in balance-cash.component.ts should use a setter so it receives relevant updates
• I refactored the inputs for chart-v2 so they were less dependant on the dashboard response structure, it was working fine for weeks but just now after my latest merge I'm getting a build error about the inputs not being recognizable. So I commented the template for now
• Need to confirm the accountChanged emitter on cash.settings.component.ts works. Might need to rearrange some lines
• e2e and unit tests

Engine-related

• Stripe response format Stripe create account responses are inexplicably not in JSON and therefore error messages aren't appearing and the form gets stuck inProgress if there are any errors.
• Token chart as of this weekend, the token overview chart started to return 1 instead of 0 when there are no tokens
• Remove account In dashboard.service.ts, the removeStripeBank() fx (this.client.delete('api/v2/payments/stripe/connect/bank')) doesn't seem to be working. It produces a success response but then when I refresh the account info, the bank is still there.
• Payout schedules Need to confirm that Mark has migrated or is prepared to migrate everyone's accounts to the same month-end payout date. If not, then the payoutDate in balance-cash.component.ts needs to be changed to accommodate different schedule

Blocked

• Navigation Still using old sidebar menu until new nav is done. Media queries for tx tables are also contingent upon new navigation, so those tables aren't styled yet

Style/UX/UI

• Major
  • rewards-popup.component.ts position needs to be moved away from the element that makes it appear when hovered over
  • Token balance equation needs to be mobile friendly
  • Transactions tables (see blocked - navigation)
• Minor
  • The Stripe bank account / routing number input labels could/should be localized and have informative tooltips. Account formatting rules (and potential validation rules info) are gathered in cash-settings/local-labels.ts but haven't been implemented.
  • The cash-onboarding-extras.component.ts photoId and ProofOfAddress file upload inputs lack so much information/instructions (provided on Stripe's website) that they seem to be setting up users for verification failure.
  • Birthday input on cash-onboarding.component.ts should be empty by default
  • tooltip positions could use an audit
  • phone-verification.component.ts could use some informative button disabling based on form validation status
  • The flag on the phone input field in the cash-onboarding.component.ts form should probably change to match the country the of the country input when the country changes (if the phone input is pristine)