Skip to content
Snippets Groups Projects

Adjusted dropdown menus to have a larger clickable area #2223

Closed Ben requested to merge fix/dropdown-item-padding-2223 into master
All threads resolved!

Let me know what you think of this approach @markeharding.

It was majorly awkward because there are multiple places that these classes are used.

image image image image image image image

Testing

Find dropdowns and check they're not broken - note some dropdowns like the discovery are horizontal.

Edited by Ben

Merge request reports

Checking pipeline status.

Closed by Mark HardingMark Harding 5 years ago (Nov 19, 2019 9:22am UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Mark Harding added StatusRequires Changes label and removed 1 deleted label

    added StatusRequires Changes label and removed 1 deleted label

  • Ben added 1 commit

    added 1 commit

    Compare with previous version

  • Ben added 1 commit

    added 1 commit

    Compare with previous version

  • Ben changed the description

    changed the description

  • Ben resolved all threads

    resolved all threads

  • Ben added 1 deleted label and removed StatusRequires Changes label

    added 1 deleted label and removed StatusRequires Changes label

  • Ben added 29 commits

    added 29 commits

    • 187e8368...a0d1737e - 28 commits from branch master
    • b046e257 - Merge branch 'master' of gitlab.com:minds/front into fix/dropdown-item-padding-2223

    Compare with previous version

  • The tradeoff of introducing so many regressions for such a trivial issue is simply not worth it. Screenshot_2019-11-19_at_09.20.57. Instead we will just work on the new dropdown area following new designs.

    Simply introducing a new class on our topbar dropdown area could have made this simple.

  • closed

  • Please register or sign in to reply
    Loading