(wip) Sort selector rework
New sort-selector interface.
Desktop/Tablet:
Mobile:
Notably this is still missing some kind of distinction between the algorithms and custom types selectors, as well as the settings icon being in an awkward location, both of which I plan to address soon.
Merge request reports
Activity
7 7 > :last-child { 8 8 margin-left: auto; 9 9 } 10 10 11 11 .m-dropdown--list--item { 12 12 cursor: pointer; 13 &.m-sort-selector--custom-type-item, changed this line in version 2 of the diff
8 8 margin-left: auto; 9 9 } 10 10 11 11 .m-dropdown--list--item { 12 12 cursor: pointer; 13 &.m-sort-selector--custom-type-item, 14 &.m-sort-selector--algorithm-item { 15 width: auto; 16 display: block; 17 text-align: center; 18 .m-sort-selector--item-label-icon { 19 margin-right: 0px; 20 margin-inline: 8px; 21 } 22 } -
spacing (make sure you use spaces and not tabs)
Edited by Mark Harding changed this line in version 2 of the diff
61 83 62 84 .m-sort-selector--algorithm-dropdown, 63 85 .m-sort-selector--period-dropdown { 64 .m-dropdown--list { 86 .li { changed this line in version 2 of the diff
-
Nice start @mnurzia ! Left some comments for you
added StatusRequires Changes label and removed 1 deleted label
mentioned in merge request !318 (closed)
added 1 commit
- 59827089 - Fix errors in sort-selector edit, tweak styles
I fixed most of the things you pointed out. However, I couldn't find a way to resolve the issue with the parent selectors cleanly. I'm new to SCSS and there is probably an easier and better looking way of doing it, but I couldn't figure out a solution like you described. I figured that I would commit here and continue trying to fix that in the meantime, since the actual output is acceptable.
@markeharding What should I do next here?
-
Hey Max. Moved this over to !472 (closed) so it will be on our sandbox sites.
Looks good from a code point of view! Let me know when you are free next week for a quick chat.
mentioned in merge request !472 (closed)
