Iframe rich embeds spill out of container in comments

Ben
2023-10-20T08:02:57Z

Summary

Iframe rich embeds spill out of container - see screenshots

Steps to reproduce

Post a link from a site we support iframe rich-embeds for in the comments. Click the link after posting so it becomes a playable embed.

https://giphy.com/gifs/animations-graphicdesign-freelance-DZTLGznWuyEeaVkkv5

https://open.spotify.com/track/1YQWosTIljIvxAgHWTp7KP?si=c9abea2f502948f2

https://soundcloud.com/adrian-dulu/01-aphex-twin-xtal

Note not ALL rich embeds do this - see parseInlineEmbed function for a full list src/app/common/components/rich-embed/rich-embed.ts

Platform information

Firefox & Ubuntu / i3

What is the current bug behavior?

Some iframes spill out of containers

What is the expected correct behavior?

Should display properly.

Mobile web should not break - some have weird padding purely for the sake of mobile so be sure to test mobile.

Relevant logs and/or screenshots

Possible fixes

(If you can, link to the line of code that might be responsible for the problem)