(chore): Follow-up from "(feat): Minds Pro"
The following discussions from !308 (merged) should be addressed:
-
@markeharding started a discussion: This is using legacy JWT library. We should be using the new JWT library used by Core/Sessions/Manager, Core/Security/SignedUri.php etc. The new one is the
Lcobucci\JWTlibrary -
@markeharding started a discussion: Please remove this block. This should be for registration only and also not at the controller level. The
fromparameter is also not very clear and potentially insecure. -
@markeharding started a discussion: This should be done via the referral cookie. Please remove from the controllers.
-
@markeharding started a discussion: Why is this added in here?
-
@markeharding started a discussion: remove from here. There is already referral logic.
-
@markeharding started a discussion: This should be set in the constructor
-
@markeharding started a discussion: Why is this no longer set?
-
@markeharding started a discussion: and here?
-
@markeharding started a discussion: This should be injected
-
@markeharding started a discussion: return type
:void -
@markeharding started a discussion: return type
: Jwt -
@markeharding started a discussion: return type
: array -
@markeharding started a discussion: return type
: string -
@markeharding started a discussion: return type
: string -
@markeharding started a discussion: return type
: array -
@markeharding started a discussion: return type
: Manager -
@markeharding started a discussion: return type
: array -
@markeharding started a discussion: return type
: HydrateSettingsDelegate -
@markeharding started a discussion: return type
: InitializeSettingsDelegate -
@markeharding started a discussion: docs and return type needed
-
@markeharding started a discussion: return type
: ?Settings -
@markeharding started a discussion: return type
: string -
@markeharding started a discussion: return type
: string -
@markeharding started a discussion: return type
: void -
@markeharding started a discussion: return type
: string -
@markeharding started a discussion: return type
: Manager -
@markeharding started a discussion: return type
: Manager -
@markeharding started a discussion: return type
: bool -
@markeharding started a discussion: return type
: bool -
@markeharding started a discussion: return type
: bool -
@markeharding started a discussion: return type
: ?Settings -
@markeharding started a discussion: return type
: bool -
@markeharding started a discussion: return type
: Response -
@markeharding started a discussion: return types needed for this file
-
@markeharding started a discussion: return type
: string -
@markeharding started a discussion: return type
: array -
@markeharding started a discussion: return type
: array -
@markeharding started a discussion: Return types needed for this file
-
@markeharding started a discussion: return types needed
-
@markeharding started a discussion: return types