Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
  • Minds Backend - Engine Minds Backend - Engine
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 239
    • Issues 239
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 18
    • Merge requests 18
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge requests
  • !412

[Sprint/SillySheep](fix): Failing spam detection on staging causing issues when uploading media #1193

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged
Ben requested to merge fix/spam-detection-webm-1193 into master Dec 03, 2019
  • Overview 4
  • Commits 6
  • Pipelines 6
  • Changes 3

Closes #1193 (closed)

Summary

Following an update to the spam detection system, videos stopped working because the spam detector was expecting an Entity object rather than the Video that our media POST was passing to it. The same applies to an Image object being passed through.

This caused an issue where-in ->getDescription() could not be found - as Video has the description attribute, I added getters and setters into the Video and Image classes.

Testing

Test various upload types, try posting with and without a red flag failing link (e.g. bit.ly).

Edited Dec 03, 2019 by Ben
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: fix/spam-detection-webm-1193