Michael Buschbeck commented on merge request !2273 at Inkscape / inkscape

Michael Buschbeck
2020-09-15T09:37:34Z

I agree in principle, but seeing how the int overload had already once been silently called with float params and the implicit assumption that this would just Do the Right Thing (...which it then didn't), I vote to keep the Geom::Coord overload as well. (Or we find a way how we can disabuse the compiler of the notion that silently converting floats to ints is a good idea, ever.)

In my view, the Geom::Coord overload costs us nothing and – if nothing else – it makes for a nice separation of concerns between "pass a Geom::Rect because it's often convenient" and "make sure float coords are properly converted to int coords".

If you insist, I'll factor the code from the current Geom::Coord overload into the Geom::Rect overload, though. Let me know.