Skip to content

Resolve "Refactor to convert plugins to leverage async patterns in hooks"

Needed changes:

  • refactor Hookable to be async
  • update all the hook methods to be async
    • update actual calls and signatures
    • update all the unit tests for the altered methods
  • update methods that trigger hooks to be async
    • update actual calls and signatures
    • walk call tree back upstream and convert to async as need
    • remove vanilla PluginInvoker.invoke
    • update all the unit tests for all the altered methods
  • Update tap discovery to be async
    • update actual calls and signatures
    • update all the unit tests for the altered methods
  • Update airflow before_configure to be async
    • update actual calls and signatures
    • update all the unit tests for the altered method
  • check on SubprocessError error handling (replace with AsyncSubprocessError exception?)
    • Airflow might need some explicit tests around this.
  • clean up aka "make everything work"

Merge Request Checklist

  • Link to an issue
  • Include the proposed fix or feature
  • Include and update tests for the modified code
  • Include a documentation change
  • Add a CHANGELOG.md entry in the Unreleased section for any user-facing changes
  • Mention or assign a maintainer

Closes #2897 (closed)

Edited by Florian

Merge request reports