Incorrect `tap-adwords` configuration in `discovery.yml`
What is the current bug behavior?
What is happening now?
What is the expected correct behavior?
What should be happening?
Steps to reproduce
How one can reproduce the issue?
Trying to get tap-adwords
to accept custom primary_keys
. Follow https://meltano.com/plugins/extractors/adwords.html#primary-keys and set the variables in the meltano.yml file (pic of config below + pic of output for meltano config tap-adwords list
), meltano still uses the default value instead of the custom ones.
Next, set the env var as given in the same documentation. It throws a TypeError on the processing of the config (pic also below).
Relevant logs and/or screenshots
Please use code blocks (```) to format console output meltano config
printout of meltano config tap-adwords list
error from running meltano elt ...
with the env var TAP_ADWORDS_PRIMARY_KEYS
Possible fixes
If you can, link to the line of code that might be responsible for the problem or suggest a fix
If you change the type of the variable primary_keys
from hidden
to object
in the discovery.yml
everything works as expected! I tried this locally and it worked.
Further regression test
Ensure we automatically catch similar issues in the future
-
Write additional adequate test cases and submit test results -
Test results should be reviewed by a person from the team