David H. Flint commented on merge request !420 at Scribble / GDLEnhanced2

David H. Flint
2019-08-08T01:04:25Z

I fixed the conflicts, so it works again. However, I need to know what the preferred way to solve certain issues are.

This MR improves loading speed in three ways:

Disabling of checked iterators and debug iterator support [<StdAfx.h>]

Caching of dungeon enumeration from Cell Data [CWorld::EnumerateDungeonsFromCellData]

Improved insertion of weenies into m_WeenieDefaultsByName [CWeenieFactory::LoadLocalStorage]

Questions respectively are:

I accept we don't want this to be in the main build config, but I'm hesitant to introduce yet another build configuration for it. Would anyone else benefit from this as an option? If I'm the only one this benefits, then I would withdraw this change.

Is this functionality still required? The functionality could be removed easily for a simpler fix. If the functionality is required, a better solution might be to parse in a background thread, or only on-demand.

This change should have no objections.

This MR also makes significant changes to the messages logged on starting up the server. I altered them so I could more easily see where time was being spent, and to be more consistent. The appropriate amount of logging, and the way that it is displayed is subjective, so I want to ensure what I did is acceptable.