Tracking issue for the V136 chain integrations: BNB Smart Chain (BSC), Bitcoin Cash (BCH), TRON and Solana (SOL). **Status (2026-10-23):** all review MRs are open and every CI job passes on each of them. The MRs are waiting for code review. ## V136 review MRs (stacked) Each MR targets the branch of the MR before it. The base is `develop` `cf9714438`. Review each MR as its own commits only; the stack table is also in !883. | # | MR | Branch | Tip | Content | | --- | --- | --- | --- | --- | | 00 | !883 | `v136/00-chain-activation` | `3b1cd2c4e` | `version` 1.136.0; chain-activation gate (`common/chain_activation.go`), so a chain in the support list stays inert until the network reaches its version; Bifrost activation gate (keygen, observer, exinfo, scanner, network fee); genesis publishes the network version; `SkipSignerCache<chain>` is an operational mimir from 1.136.0 | | 01 | !884 | `v136/01-bifrost-utxo-hardening` | `3dc3cb84c` | `[Version-unspecific]` mempool observations never final; reject bad prevout indexes; NULLFAIL is an error; zero EVM gas rounds up; drop invalid observations one at a time; `HALTSIGNING` honored in BTC/DASH consolidation | | 02 | !885 | `v136/02-bifrost-evm-hardening` | `f4e025d48` | `[Version-unspecific]` EVM confirmation framework, Prague signer, receipt effective gas price, router-origin check, per-vault router balances, unstuck honors `HALTSIGNING`, token decimals from the token list, chain-ID pin, receipt retry, THOR parity fixes | | 03 | !886 | `v136/03-bsc` | `49c21169a` | BSC: chain and asset, token list, router, `handler_tss` `handleV136`, `migrateStoreV136` (stale `BSC.BNB` pool cleanup), Bifrost, mocknet geth node, simulation, docs, regression | | 04 | !887 | `v136/04-bch` | `90216dec8` | BCH: CashAddr parsing in the V136 address set, Bifrost client (CashTokens-aware), mocknet BCHN 29, simulation, docs, regression | | 05 | !888 | `v136/05-tron` | `37b345a47` | TRON: chain, addresses, TRC20 token list, `NetworkFeeHandler.handleV136`, Bifrost client, mocknet java-tron + TRC20, simulation, docs, regression | | 06 | !889 | `v136/06-sol` | `aa40b2a7f` | SOL: chain, addresses, tx IDs from 1.136.0, TxOut/Network `VCUR` (rent reserve, sub-dust drop, case-variant refusal), observed-tx `handleV136`, Bifrost client, mocknet, simulation, docs, regression | **Merge note:** squash is on by project default. Squashing a stacked MR rewrites its commits, so the next MR in the stack then shows them again. Disable squash on !883–!889, or merge them in order with rebase. ## Separate MRs on `develop` Bifrost THOR-parity fixes that do not depend on the stack: | MR | Branch | Content | | --- | --- | --- | | !879 | `fix/bifrost-btc-dash-thor-parity` | BTC/DASH THOR parity fixes | | !880 | `feat/bifrost-signer-cache-expiry` | Signer cache entries expire and dropped outbounds are re-signed (the consensus half, the `SKIPSIGNERCACHE` operational mimir, is in !883) | | !881 | `feat/bifrost-evm-rpc-auth` | Bearer and basic-auth support for EVM RPC endpoints | | !882 | `fix/bifrost-eth-zec-asgard-cache` | ETH, ZEC and Cardano keep using the cached Asgard addresses when MAYANode cannot be read (ETH/ZEC part of thornode!4594) | ## Test state - **CI:** every job passes on !879–!889 (generate, lint, unit tests, network-specific tests, regression, test-simulation). - **Unit and lint:** `make test`, `make test-network-specific`, `lint-versions`, `lint-handlers`, `lint-managers` and `trunk check --all` pass on each branch. - **Regression (full `EXPORT=1` runs):** BSC 144/144, BCH 147/147, TRON 150/150, SOL 153/153. The only intermittent failure is `swaps/streaming-swaps` line 81 on BCH. It passes when run alone and is a harness flake. - **Mocknet simulation, run per chain:** - [x] BSC: geth dev node, router deploy (214 actors) - [x] BCH: BCHN 29 (248 actors). Manual CashTokens test passes: a token-only output to the vault is not observed, a mixed tx credits only the plain output, and refunds and a 10-input consolidation never spend token UTXOs. - [x] TRON: java-tron + TRC20 (283 actors). Manual TRC20 round trip passes: deposit, add, withdraw, observed outbound. - [x] SOL (279 actors) - The last commits after these runs change only tests, lint, docs and one behaviour-preserving `if`/`switch` rewrite. The CI regression and simulation jobs cover the final tips. ## Remaining work - [ ] Code review of !879–!889. - [ ] Merge !883–!889 in stack order (see the merge note above). - [ ] CI: `test-simulation` takes 53–60 min against the 1 h job timeout (!889 finished in 3572 s). Raise the timeout or split the suite. - [ ] BCH: - [ ] Mocknet uses a third-party BCHN image pinned by digest. Publish a MAYA-built BCHN 29 image. - [ ] Smoke test `bitcoin_cash.py` is not restored. - [ ] `getGas` still makes one RPC per input; batching is not ported. - [ ] Activation: Bifrost reads `/mayachain/version` `current`, which lags the lowest active version by a few blocks after an upgrade. Bifrost may start a new chain slightly after the chain activates it. Liveness only. - [ ] Per-chain `min_confirmations`, fee bounds and EVM `confirmations` are node config but feed the vote, so they must be identical on every node. Document them in node-launcher. - [ ] Add the new chains to node-launcher (helm charts, separate repo). - [ ] Before enabling TRON: fund and set the default TRON reference address. Done since the last update: stack rebased onto `develop` and exports regenerated; full SOL regression; mocknet runs for all four chains; BCHN 29 RPC shapes confirmed (`tokenData` in `listunspent` / `getblock 2`, `getblockstats avgfeerate`); `InitGenesis` and `ExportGenesis` publish the network version; THOR parity review of each chain; review MRs opened. ## Deferred to a later version - Keygen chain-set preflight and churn-out (THOR `25989b1f7e`, `161ba2adaf`); V137. Until then, a runbook check. - SOL durable nonce and `SOLAnchorMarginSeconds`. Measure keysign p95 on stagenet first. - BSC missing-tx-out security-event exemption (V137). - BCH P2PK-to-vault-key handling (regtest check first). ## Open decisions - BC-6 keysign height pinning. MAYA TSS has no leader rotation, so pinning risks a stuck leader. - THOR's 2 sat/vB BTC fee floor.