Dynasor 2.0 tests fail on Windows
Summary
Running pytest tests
in the dev version fails on Windows.
Steps to reproduce
- clone the repo on Windows
- run
python setup.py build install
- run
pytest tests
- observe failures in several tests
What is the current bug behavior?
Due to how NamedTemporaryFile
works on Windows, tests fail with "Permission denied" errors
What is the expected correct behavior?
We would like the tests to pass if possible, please.
Possible fixes
Add delete=False
in the instantiation of NamedTemporaryFile
Issue definition review
(Before the issue can be moved onto the board it should be discussed with or reviewed by at least one other team member. You can address one or more team members via the following slash (quick action) command):
/cc @(username)
Labeling
(Please suggest labels for the issue, e.g., by using the following slash command):
/label ~(label1) ~(label2)
Time estimation
Estimated time can be indicated with the command /estimate
; use e.g., /estimate 2d
to indicate two days.