1. 03 Mar, 2012 17 commits
  2. 02 Mar, 2012 4 commits
  3. 27 Feb, 2012 5 commits
    • jim warner's avatar
      top: relocate a prototype to prevent compiler warning · efb9fcb8
      jim warner authored
      Until the 'locate/search' provisions were added,
      top avoided the need for any function prototypes
      through careful source file organization.  But
      the addition of the find_string function required
      a prototpe for task_show, lest a massive file
      reorganization be undertaken.
      
      This commit moves the actual protype out of top.h
      and places it adjacent to the caller in order to
      avoid a warning when top_nls.c is compiled.
      
      References:
      commit 270e8e7e
      commit d6e6a9aaSigned-off-by: jim warner's avatarJim Warner <james.warner@comcast.net>
      efb9fcb8
    • jim warner's avatar
      top: isolate #defines actually present in confiure.ac · 4dac0dfe
      jim warner authored
      All top.h defines were lumped together as:
         'Development/Debugging defines'
      
      This commit establishes this new category:
         'Defines represented in configure.ac'
      
      And that new category now contains OOMEM_ENABLE,
      which enables the SuSE out-of-memory additions
      Signed-off-by: jim warner's avatarJim Warner <james.warner@comcast.net>
      4dac0dfe
    • jim warner's avatar
      top: remove residual logic for obsolete functionality · 045538e0
      jim warner authored
      At one time the 'open_psdb_message' library call was
      supported with the concept of a postponed message
      which would display after top startup completed.
      In turn, that required logic to strip the '\n' which
      was embedded (inappropriately) in any such message.
      
      Nowdays top treats such a returned error as fatal so
      there is no need for the 'strim' function which is
      being removed with this commit.
      Signed-off-by: jim warner's avatarJim Warner <james.warner@comcast.net>
      045538e0
    • jim warner's avatar
      top: update latest CPU % distortions understanding · ee3ed4b4
      jim warner authored
      We originally approached the potential problem of
      % CPU distortions as unique to Nehalem type cpus.
      The latest information suggests that it may have
      been due to a kernel anomaly that has since been
      corrected.
      
      Yet even without such a cpu, wide disparities in
      tics allocation among all available cpus have
      sometimes been observed -- spikes as it were in
      the normal pattern.  This has happened under both
      version 2.26.38-13 and 3.0.0-15 kernels.
      
      The small amount of additional code addressing the
      original problem carries very little overhead.  It
      is being retained to afford protection against any
      future tic accounting aberrations.
      
      In this commit, supporting programmer comments have
      been divorced from any particular cpu type.  Also,
      another variable and manifest constant will now be
      eliminated when CPU_ZEROTICS is defined.
      
      References:
      commit 02508b3d
      http://www.freelists.org/post/procps/CStates-handling-new-switch,50
      ee3ed4b4
    • jim warner's avatar
      top: fix regression created when fields mgmt reorg'd · ccb51440
      jim warner authored
      When the calibrate_fields function was broken up for
      mainainability, an obscure regression was introduced.
      
      For the resulting bug to affect the display, all of
      the following conditions would have to be met:
       . USE_X_COLHDR was not defined
       . column highlighting had been turned on
       . many, perhaps all, fields were displayable
       . the user then typed the <End> key
       . and the current sort column just happened to
         be immediately to the left of the left-most
         visible field
      
      This patch corrects for that remote possibility.
      
      Reference:
      commit d0e16acfSigned-off-by: jim warner's avatarJim Warner <james.warner@comcast.net>
      ccb51440
  4. 25 Feb, 2012 1 commit
  5. 14 Feb, 2012 1 commit
  6. 13 Feb, 2012 1 commit
  7. 12 Feb, 2012 6 commits
    • Craig Small's avatar
      Merge remote-tracking branch 'sami/2012wk6' · d9c226c6
      Craig Small authored
      d9c226c6
    • jim warner's avatar
      a096fec8
    • jim warner's avatar
      top: reorganize some fields management logic · d0e16acf
      jim warner authored
      The calibrate_fields function had grown too large and
      was adversly impacting maintainence.  So half of the
      logic was split out into a new function.
      
      Now, maintainence of column headers and the required
      library flags is organized as follows:
      
       . adj_geometry   (calibrate_fields helper)
           provides low-level support for sigwinch, memory
      
       . build_headers  (calibrate_fields helper)
           constructs the headers and library flags
      
       . calibrate_fields
           establishes which fields will be displayed
      
      ( note the alpha order mentioned in a prior commit )
      Signed-off-by: jim warner's avatarJim Warner <james.warner@comcast.net>
      d0e16acf
    • jim warner's avatar
      top: standardize names of all 'helper' functions · 270e8e7e
      jim warner authored
      The top program is carefully organized into sections
      and those sections are carefully placed so as to avoid
      the need for prototypes. *
      
      Additionally, names of functions are carefully chosen
      to maintain alphabetical order within each section.
      
      The names of most 'helper' functions, which are always
      placed immediately above the calling functions, often
      only met the spirit of the alphabetical law, not the
      actual letter of that law.
      
      This commit alters the names of such helper functions
      so as to mainatin strict ascii alphabetical order
      within each section.
      
      * the single exception to prototypes is find_string,
        which calls the task_show function, and would have
        prompted a massive reorganization.
      Signed-off-by: jim warner's avatarJim Warner <james.warner@comcast.net>
      270e8e7e
    • jim warner's avatar
      top: use CPU_ZEROTICS to embrace the Nehalem logic · 02508b3d
      jim warner authored
      The recently added logic dealing with "missing" tics
      is mutually exclusive with logic associated with a
      define called CPU_ZEROTICS.
      
      This commit expands the use of that define to exclude
      such Nehalem logic as appropriate.
      
      It also extends programmer notes in top.h to include
      an attribution for initiating the topic of potential
      Nehalem type % CPU distortions, acknowledging:
        Jaromir Capik, <jcapik@redhat.com>
      
      References
      commit ce1410a5
      commit 9e7dd43a
      commit a9041a55
      02508b3d
    • James Cloos's avatar
      top: postpone the switch from Kb to Mb in summary display · 95f22017
      James Cloos authored
      The mem and swap lines have enough room to show eight significant
      digits, so switch to showing MB when >=100MB, not >=10MB.
      
      The extra detail is valuable; it should not be elided.
      Signed-off-by: default avatarJames Cloos <cloos@jhcloos.com>
      Signed-off-by: jim warner's avatarJim Warner <james.warner@comcast.net>
      95f22017
  8. 11 Feb, 2012 5 commits