Commit ac8f49e7 authored by jim warner's avatar jim warner Committed by Craig Small

top: miscellaneous accumulated tweaks of code/comments

This commit just tries to parallel that newlib branch.
It contains the following changes, which were prompted
by the newlib coverity analysis which Craig initiated:

. comment typo predicting 'String not null terminated'
. eliminate 'Logically dead code' from insp_make_row()

Some tweaks, unrelated to coverity, are also included:

. use more modern (recommended) approach for time call
Signed-off-by: jim warner's avatarJim Warner <>
parent 5e265129
......@@ -982,7 +982,7 @@ static int ioch (int ech, char *buf, unsigned cnt) {
// it may have been the beginning of a lengthy escape sequence
// note: we do NOT produce a vaid 'string'
// note: we do NOT produce a valid 'string'
return rc;
} // end: ioch
......@@ -2699,7 +2699,7 @@ static void sysinfo_refresh (int forced) {
if (forced)
mem_secs = cpu_secs = 0;
cur_secs = time(NULL);
/*** hotplug_acclimated ***/
if (3 <= cur_secs - mem_secs) {
......@@ -3008,7 +3008,6 @@ static inline void insp_make_row (int col, int row) {
int fr, to, ofs;
int hicap = 0;
if (col < INSP_RLEN(row))
memcpy(tline, Insp_p[row] + col, sizeof(tline));
else tline[0] = '\n';
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment