1. 20 Apr, 2016 1 commit
  2. 17 Apr, 2016 2 commits
  3. 16 Apr, 2016 1 commit
  4. 14 Apr, 2016 1 commit
    • jim warner's avatar
      top: minimal necessary corrections to the man document · dad56cc9
      jim warner authored
      After experimenting with those 4.5 kernel enhancements
      to /proc/<pid>/status, that newly added overview topic
      'Memory Types' was found to be in need of some tweaks.
      
      In addition, the 'DATA' description wasn't quite broad
      enough since explicit private file mappings impact it.
      
      ( lastly, for the record, the 2nd commit referred to )
      ( below contained an incorrect reference that should )
      ( have been the original issue 21 commit. instead it )
      ( showed an invalid SHA-1 hash. i believe i have now )
      ( identified a flaw in my workflow that produced it. )
      
      Reference(s):
      . original patch responding to issue #21
      commit e4bbd3ca
      . subsequent patch with invalid commit ref
      commit 5dcbcd00Signed-off-by: jim warner's avatarJim Warner <[email protected]>
      dad56cc9
  5. 23 Mar, 2016 1 commit
    • jim warner's avatar
      top: add additional memory information to the man page · 5dcbcd00
      jim warner authored
      In response to Issue #21, the commit referred to below
      provided some much needed improvements and corrections
      to topic `3a. DESCRIPTIONS of Fields' in the man page.
      However, it assumed a reader possessed much background
      knowledge that may not, in truth, actually be present.
      
      So without, hopefully, insulting anyone's intelligence
      this patch offers an expanded discussion of some terms
      and concepts within a separate section under OVERVIEW.
      
      [ plus it affords an opportunity to incorporate that ]
      [ extremely useful table from Florent Bruneau's post ]
      
      Reference(s):
      commit f2a08cf16794ec6085bdecbaf8f7c2887cd4e87f
      https://techtalk.intersec.com/2013/07/memory-part-1-memory-types/Signed-off-by: jim warner's avatarJim Warner <[email protected]>
      5dcbcd00
  6. 15 Mar, 2016 1 commit
  7. 12 Mar, 2016 2 commits
    • Craig Small's avatar
      Merge branch 'master' into 'master' · 6099f14a
      Craig Small authored
      Cygwin build support
      
      I have added some changes to make building in Cygwin possible. Please review the changes and let me know if there are any ways I may have done anything incorrectly.
      
      strverscmp is included to satisfy a dependency in Cygwin.
      Excluded utmp and prctl functions that are not supported currently.
      
      See merge request !12
      6099f14a
    • jim warner's avatar
      top: tweaks to vertical scroll management & 'i' toggle · 717d73f1
      jim warner authored
      The commit referenced below claims to disable vertical
      scrolling when idle tasks weren't being shown. However
      it really addresses only a point in time when that 'i'
      toggle is keyed. Left untouched were the up/down keys.
      
      So this commit will simply finish the job of disabling
      vertical scrolling whenever tasks which have used some
      CPU are the only ones which are currently being shown.
      
      Reference(s):
      commit c07f6c5eSigned-off-by: jim warner's avatarJim Warner <[email protected]>
      717d73f1
  8. 10 Mar, 2016 4 commits
  9. 03 Mar, 2016 4 commits
    • Craig Small's avatar
      Replace %Lu with standard %llu · da715e3c
      Craig Small authored
      Multiple scanf()s use the GNU-permitted %Lu. This is not supported in
      other libraries and isn't to the POSIX specification. The L modifier
      is only used for floats in POSIX.
      
      Replacing %Lu with %llu is the same for GNU libc (scanf(3) says as much)
      but means other libraries will work fine.
      
      Closes: #19
      
      References:
       http://pubs.opengroup.org/onlinepubs/009695399/functions/fscanf.html
      da715e3c
    • Craig Small's avatar
      Merge branch 'master' into 'master' · 666b2946
      Craig Small authored
      pmap: Fix detail parsing on long mapping lines
      
      If the mapping descriptor is longer than 128 chars, the last parsed
      character won't be a newline even if the current buffer contains it a
      bit further than that. The current code always interprets it as a short
      fgets() read instead, and thus keeps calling fgets() until it gets a
      newline, dropping valid lines and failing with the following error:
      
      pmap: ERROR: inconsistent detail field in smaps file, line:
       Rss:                 212 kB
      
      See merge request !10
      666b2946
    • Craig Small's avatar
      Merge branch 'master' into 'master' · 4acd85d6
      Craig Small authored
      Fix for Bug:1174313
      
      Re-ordered 'tgid' before 'thcount' to fix bug https://bugzilla.redhat.com/show_bug.cgi?id=1174313.
      It was not in alphabetical order. 
      
      See merge request !11
      4acd85d6
    • Craig Small's avatar
      A locale-independent strtod · 32e1b2e2
      Craig Small authored
      There is a need in some utilities to have a way of accepting both
      types of decimal points "." and ",". The only way seems to be to
      rebuild strtod().
      
      This new function will accept "123.456" and "123,456" as 123.456
      and considers them the same number. It means we lose thousands
      separator, but this is rarely used.
      
      test scripts are added to check the function returns the proper
      values. There was simpler predecessor that got stuck on negative
      0 or -0.123 which these tests flushed out.
      
      References:
      32e1b2e2
  10. 02 Mar, 2016 1 commit
  11. 09 Feb, 2016 1 commit
    • Emanuele Aina's avatar
      pmap: Fix detail parsing on long mapping lines · 9965fdcb
      Emanuele Aina authored
      If the mapping descriptor is longer than 128 chars, the last parsed
      character won't be a newline even if the current buffer contains it a
      bit further than that. The current code always interprets it as a short
      fgets() read instead, and thus keeps calling fgets() until it gets a
      newline, dropping valid lines and failing with the following error:
      
      pmap: ERROR: inconsistent detail field in smaps file, line:
       Rss:                 212 kB
      9965fdcb
  12. 03 Jan, 2016 2 commits
  13. 18 Nov, 2015 1 commit
    • Craig Small's avatar
      watch: interpret esc[m sequence · 6fcb6900
      Craig Small authored
      Commit 99fa7f removed watch crashing from having the null ANSI
      sequence. However it just ignored that sequence instead of fixing it.
      
      This change correctly checks buf (not undefined endptr) and sends
      the reset attribute if found.
      
      Closes: #12
      6fcb6900
  14. 28 Oct, 2015 5 commits
    • jim warner's avatar
      top: extend '=' key to include active 'locate' request · 94e4749b
      jim warner authored
      It is documented behavior that when certain other keys
      are active, sorts column highlighting will temporarily
      be disabled. Among those keys is the 'L' (locate/find)
      provision. The equals ('=') key can be used to restore
      column highlighting by resetting other keys, except 1.
      
      When a locate/find is active, the '=' key will have no
      effect on 'x' column highlighting, which still remains
      disabled. Further, when 'L' is active an 'x' keystroke
      is processed changing the state of column highlighting
      but without any visual clue (since it's yet disabled).
      
      So this commit just extends the '=' key to embrace 'L'
      processing resets, just like other highlight disabling
      keys while avoiding 'x' state changes if approproiate.
      Signed-off-by: jim warner's avatarJim Warner <[email protected]>
      94e4749b
    • jim warner's avatar
      top: ATEOJ_RPTHSH prints hash table entries less often · 489d23a1
      jim warner authored
      We'll following the newlib <pids> approach to hashing:
      
      . a 'PIDs at max depth:' portion of that UNREF_RPTHASH
      enabled #define is now published only when the maximum
      depth of hash table entry chains exceed depths of one.
      Signed-off-by: jim warner's avatarJim Warner <[email protected]>
      489d23a1
    • jim warner's avatar
      top: do not co-mingle strings/numbers under namespaces · e1cd74ee
      jim warner authored
      Craig's recent commit under that newlib branch dealing
      with namespace support has prompted me to review top's
      handling of those fields. Currently, when such a field
      is zero, top displays a dash ('-'). This will mean the
      justification toggles ('j/J') will behave incorrectly.
      
      This patch simply allows the potential zero to display
      or be suppressed with the already existing '0' toggle.
      Signed-off-by: jim warner's avatarJim Warner <[email protected]>
      e1cd74ee
    • jim warner's avatar
      top: miscellaneous accumulated tweaks to code/comments · c7201d52
      jim warner authored
      A patch containing the following miscellaneous tweaks:
      
      . remove a function that handled former library errors
      [ that function should have gone bye-bye with 3.3.11 ]
      [ when those 'wchan' provisions were much simplified ]
      Signed-off-by: jim warner's avatarJim Warner <[email protected]>
      c7201d52
    • jim warner's avatar
      b1f7b2a5
  15. 26 Oct, 2015 1 commit
    • Craig Small's avatar
      Closes: #9 ps: Remove Unix98 output limitations · b2f49b10
      Craig Small authored
      ps previously followed the Unix98 standard when it comes to
      user-defined output, sometimes. This meant you could have
      user output format with a header that included commas and
      equals signs. It was dependent on if ps thought you wanted
      sysv or bsd format and THAT was dependent on things in previous
      options.
      
      It was very confusing to a user because
       ps p $$ -o pid=,comm=
      gave you a two-column output but
       ps -p $$ -o pid=,comm=
      would give you a one column output with the header ",comm="
      
      The -p versus p means (to ps) you want sysv or bsd parsing.
      Unix98 standard or not, this is plainly just silly.
      
      The commit removes any of the quirks Unix98 has with user defined
      output.  If you really wanted a ps header with commas in the output,
      today isn't your day.
      Signed-off-by: Craig Small's avatarCraig Small <[email protected]>
      b2f49b10
  16. 24 Oct, 2015 6 commits
  17. 01 Sep, 2015 1 commit
  18. 18 Aug, 2015 1 commit
  19. 15 Aug, 2015 3 commits
  20. 09 Aug, 2015 1 commit