Skip to content

"--custom-approvals-required" Not Respected When "--custom-approver" Is Not Set

I am encountering an issue where Marge-bot does not respect the --custom-approvals-required flag when the _--custom-approver _ flag is not specified. According to the documentation, if --custom-approver is not provided, Marge-bot should fetch the approvers from GitLab and wait for the specified number of approvals before merging. However, it merges immediately, disregarding the --custom-approvals-required setting.

Steps to Reproduce:

  • Configure Marge-bot with --custom-approvals-required=2 and without specifying --custom-approver.
  • Open a merge request and assign to marge-bot.
  • Observe that Marge-bot merges the request without waiting for the required number of approvals.

Expected Behavior:

  • Marge-bot should respect the --custom-approvals-required setting, and wait for at least 2 approvals before merging the merge request.

Actual Behavior:

  • Marge-bot merges the merge request immediately, even when the required number of approvals (set via --custom-approvals-required) has not been met.

Additional Notes:

  • Behavior works as expected when --custom-approver is explicitly specified with a list of approvers.
  • I am using the latest Marge-bot version.

Steps to Investigate:

  • Verify if this is a configuration issue or a bug in the latest version. And would appreciate a tip if there is something I am missing on the conf.