Skip to content
Snippets Groups Projects

Drop browserid and use allauth instead for logging in

Closed Simon Hanna requested to merge thelinuxguy/postorius:allauth-login into master

Fixes #73 (closed)

Changes include:

  • Drop browserid which only provides persona and use allauth instead.
  • Drop ConfirmationProfiles and use allauth confirmation instead
  • Add registration forms that use local accounts
  • Add ability to change password
  • Add ability to reset password

Note this merge request depends on !92 (closed) being merged in first to prevent redirect loops

@abompard I will close my other merge request !91 (closed), and split it up into pieces.
Once it's merged here I will work on getting it into hyperkitty

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Simon Hanna Added 1 commit:

    Added 1 commit:

    • cca8ba93 - Fix pep8 errors
  • Could you please rebase this MR on the changes that have happened in the code recently? Thanks.

  • Sure, I'll start working on it asap.
    In the meantime, could you take a look at !150 (merged). I'm not sure why the tests of the original mr succeeded...
    !92 (closed) is required for this branch. Otherwise we'd end up with redirect loops.

  • Simon Hanna Added 126 commits:

    Added 126 commits:

    • cca8ba93...2fd81c86 - 108 commits from branch mailman:master
    • 762cfba1 - Replace browserid with allauth in setup
    • f2f3864f - Update form template
    • 85bc341c - Remove tests for replaces components
    • e1864ee6 - Remove login template
    • 859c818d - Drop AddressConfirmationProfile
    • 7942575c - Remove old urls
    • 09a832bd - Use new urls in base template
    • cc72f091 - Update test settings
    • c597b4e6 - Add links to manage account
    • 454729c5 - Add app config
    • 5ef0ee37 - Remove old email confirmation template
    • f2fcfe2d - Update user views
    • da75c062 - Add signals
    • fbbbe0af - Add templates
    • 6a084904 - Fix pep8 errors
    • 75914234 - Fix urls
    • 6cc8c8be - Rename signals and fix a small error
    • 94bdb40e - Remove form to add emails from profile page
  • I guess I'll add a couple of tests for the signals, to make sure they work as intended. I also need to fix some existing tests. Currently I don't synchronize the addresses back from mailman. So if an address is added using any other method than postorius, it won't be picked up.
    I guess we could add some way of synchronizing all addresses in the admin, this could also be exposed to the command line.
    Do you think this is enough, or should we also sync the addresses whenever they can be used (probably nearly all requests)

    You can take a look at the templates for the emails that are sent out (signup, adding email, resetting password) and see if you would want to change any of them.

  • Simon Hanna Added 1 commit:

    Added 1 commit:

    • 0994556f - Fix pep8 errors
  • Simon Hanna Added 1 commit:

    Added 1 commit:

    • 4bd8589d - Fix login url in a test case
  • Simon Hanna mentioned in merge request !148 (closed)

    mentioned in merge request !148 (closed)

  • Simon Hanna Added 24 commits:

    Added 24 commits:

  • Terri Oda Status changed to closed

    Status changed to closed

  • We had a great talk with Dan from Mozilla at Pycon about paths for moving away from Persona and I don't think we'll be going with this solution, so I'm going to close this merge request now rather than leave it dangling.

  • Just out of curiosity, which options are you thinking about?

  • Simon Hanna mentioned in merge request hyperkitty!19 (closed)

    mentioned in merge request hyperkitty!19 (closed)

Please register or sign in to reply
Loading