Implement alias_domain attribute for domain object.
This is a companion to mailman!202 (merged). It adds the alias_domain attribute to mailmanclient.
I think the changes are good and all that's required, but I had an issue in re-recording the vcr tape. Upon re-recording, some tests in using.rst
failed that had nothing to do with what I changed. These were:
List Settings: len(settings) returned 52, not 51
Archivers: mail-archive
, mhonarc
and prototype
were initially False
, not True
I ultimately cheated and just reverted that portion of tape.yaml
that didn't involve my changes.
Merge request reports
Activity
@thelinuxguy I'm sure that's correct, but I used the
mailman.cfg
described atsrc/mailmanclient/docs/testing.rst
. I'm sure thelen(settings)
discrepancy is due to some recent change in the core and the doctest just needs updating, but I don't know about the archivers.It seems that either the
mailman.cfg
described atsrc/mailmanclient/docs/testing.rst
needs updating or the doctests need updating, but I don't know enough about the back story to know which it is which is why I chose to bypass the issue in the way I did.Mentioned in merge request mailman!202 (merged)
Added 1 commit:
- 817a10e5 - Updated docs/using.rst to account for added 'info' list setting.
Mentioned in issue postorius#160 (closed)
Mentioned in merge request postorius!186 (merged)
Added 3 commits:
-
817a10e5...c98c56ce - 2 commits from branch
mailman:master
- fd885136 - Merge branch 'master' of gitlab.com:mailman/mailmanclient
-
817a10e5...c98c56ce - 2 commits from branch
Added 5 commits:
-
fd885136...fd6c857b - 3 commits from branch
mailman:master
- 71d25817 - Merge branch 'master' of gitlab.com:mailman/mailmanclient
- 5e861984 - Re-recorded vcr tape after prior merge.
-
fd885136...fd6c857b - 3 commits from branch
added 5 commits
-
5e861984...1ac1b0e0 - 2 commits from branch
mailman:master
- 3e38533e - Implement alias_domain attribute for domain object.
- c6bd84ec - Updated docs/using.rst to account for added 'info' list setting.
- db30d2ac - Re-recorded vcr tape after prior merge.
Toggle commit list-
5e861984...1ac1b0e0 - 2 commits from branch
added 7 commits
-
db30d2ac...15195ac6 - 4 commits from branch
mailman:master
- c25392c7 - Implement alias_domain attribute for domain object.
- 52a7ebd2 - Updated docs/using.rst to account for added 'info' list setting.
- 22a24561 - Re-recorded vcr tape after prior merge.
Toggle commit list-
db30d2ac...15195ac6 - 4 commits from branch
added 11 commits
-
22a24561...5d57d74c - 8 commits from branch
mailman:master
- 674ff23b - Implement alias_domain attribute for domain object.
- c02065cd - Updated docs/using.rst to account for added 'info' list setting.
- aebd8333 - Recorded a new tape.
Toggle commit list-
22a24561...5d57d74c - 8 commits from branch
added 41 commits
-
aebd8333...1804b2fa - 40 commits from branch
mailman:master
- fed4d3c0 - Implement alias_domain attribute for domain object.
-
aebd8333...1804b2fa - 40 commits from branch
added 3 commits
-
fed4d3c0...d9e9cb73 - 2 commits from branch
mailman:master
- a6d80153 - Implement alias_domain attribute for domain object.
-
fed4d3c0...d9e9cb73 - 2 commits from branch
Now that !202 is merged, I will merge this too?
What do you think @msapiro ?
@maxking I'm working on it now. I think I need to re-record the tapes for CI to pass. There's also postorius!186 (merged), but that depends on this one. I won't be able to finish this up until probably after the weekend, but I'll keep you posted.
added 7 commits
-
a6d80153...a8a4f624 - 6 commits from branch
mailman:master
- 8546662d - Implement alias_domain attribute for domain object.
-
a6d80153...a8a4f624 - 6 commits from branch
@maxking This is now ready to merge. I needed to update the doctest to account for new attributes in core and re-record the tapes.
Thanks for this @msapiro !
Looks good to me.