Reformatting of code base to follow PEP 8 style guidelines
Code base is not up to date when it comes to following PEP 8 style guide. I would like to make the whole code base follow it. Let me know if it is a valid issue.
Checked using: pylint
Output when checked:
************* Module conf
conf.py:191:0: C0330: Wrong continued indentation (remove 3 spaces).
u'Mailman Coders', 'manual'),
| ^ (bad-continuation)
conf.py:1:0: C0111: Missing module docstring (missing-docstring)
conf.py:50:0: W0622: Redefining built-in 'copyright' (redefined-builtin)
conf.py:33:0: C0103: Constant name "extensions" doesn't conform to UPPER_CASE naming style (invalid-name)
conf.py:40:0: C0103: Constant name "source_suffix" doesn't conform to UPPER_CASE naming style (invalid-name)
conf.py:46:0: C0103: Constant name "master_doc" doesn't conform to UPPER_CASE naming style (invalid-name)
conf.py:49:0: C0103: Constant name "project" doesn't conform to UPPER_CASE naming style (invalid-name)
conf.py:50:0: C0103: Constant name "copyright" doesn't conform to UPPER_CASE naming style (invalid-name)
conf.py:57:0: C0413: Import "from setup_helpers import get_version" should be placed at the top of the module (wrong-import-position)
conf.py:58:0: C0103: Constant name "_version" doesn't conform to UPPER_CASE naming style (invalid-name)
conf.py:59:0: C0103: Constant name "version" doesn't conform to UPPER_CASE naming style (invalid-name)
conf.py:61:0: C0103: Constant name "release" doesn't conform to UPPER_CASE naming style (invalid-name)
conf.py:75:0: C0103: Constant name "exclude_patterns" doesn't conform to UPPER_CASE naming style (invalid-name)
conf.py:93:0: C0103: Constant name "pygments_style" doesn't conform to UPPER_CASE naming style (invalid-name)
conf.py:103:0: C0103: Constant name "html_theme" doesn't conform to UPPER_CASE naming style (invalid-name)
conf.py:176:0: C0103: Constant name "htmlhelp_basename" doesn't conform to UPPER_CASE naming style (invalid-name)
conf.py:189:0: C0103: Constant name "latex_documents" doesn't conform to UPPER_CASE naming style (invalid-name)
conf.py:222:0: C0103: Constant name "man_pages" doesn't conform to UPPER_CASE naming style (invalid-name)
************* Module conftest
conftest.py:19:0: C0103: Class name "__metaclass__" doesn't conform to PascalCase naming style (invalid-name)
conftest.py:22:0: E0401: Unable to import 'pytest' (import-error)
conftest.py:26:0: C0111: Missing function docstring (missing-docstring)
conftest.py:26:22: W0613: Unused argument 'request' (unused-argument)
************* Module copybump
copybump.py:1:0: C0111: Missing module docstring (missing-docstring)
copybump.py:11:0: C0103: Constant name "this_year" doesn't conform to UPPER_CASE naming style (invalid-name)
copybump.py:12:0: C0103: Constant name "pyre_c" doesn't conform to UPPER_CASE naming style (invalid-name)
copybump.py:13:0: C0103: Constant name "pyre_n" doesn't conform to UPPER_CASE naming style (invalid-name)
copybump.py:14:0: C0103: Constant name "new_c" doesn't conform to UPPER_CASE naming style (invalid-name)
copybump.py:15:0: C0103: Constant name "new_n" doesn't conform to UPPER_CASE naming style (invalid-name)
copybump.py:21:4: C0103: Constant name "pyre" doesn't conform to UPPER_CASE naming style (invalid-name)
copybump.py:22:4: C0103: Constant name "new" doesn't conform to UPPER_CASE naming style (invalid-name)
copybump.py:25:4: C0103: Constant name "pyre" doesn't conform to UPPER_CASE naming style (invalid-name)
copybump.py:26:4: C0103: Constant name "new" doesn't conform to UPPER_CASE naming style (invalid-name)
copybump.py:29:0: C0111: Missing function docstring (missing-docstring)
copybump.py:39:16: C0103: Variable name "mo" doesn't conform to snake_case naming style (invalid-name)
copybump.py:48:16: W0621: Redefining name 'line' from outer scope (line 33) (redefined-outer-name)
copybump.py:58:0: C0111: Missing function docstring (missing-docstring)
copybump.py:65:0: C0111: Missing function docstring (missing-docstring)
************* Module COPYING
COPYING.LESSER:1:0: E0001: unexpected indent (<unknown>, line 1) (syntax-error)
************* Module index
index.rst:1:0: E0001: invalid syntax (<unknown>, line 1) (syntax-error)
************* Module mailman_test
mailman_test.cfg:1:0: C0111: Missing module docstring (missing-docstring)
mailman_test.cfg:3:0: W0104: Statement seems to have no effect (pointless-statement)
mailman_test.cfg:3:1: E0602: Undefined variable 'devmode' (undefined-variable)
mailman_test.cfg:4:9: E0602: Undefined variable 'yes' (undefined-variable)
mailman_test.cfg:5:9: E0602: Undefined variable 'yes' (undefined-variable)
mailman_test.cfg:6:11: E0602: Undefined variable 'you' (undefined-variable)
mailman_test.cfg:6:15: E0602: Undefined variable 'yourdomain' (undefined-variable)
mailman_test.cfg:8:0: W0104: Statement seems to have no effect (pointless-statement)
mailman_test.cfg:8:1: E0602: Undefined variable 'mta' (undefined-variable)
mailman_test.cfg:11:10: E0602: Undefined variable 'mailman' (undefined-variable)
mailman_test.cfg:13:0: W0104: Statement seems to have no effect (pointless-statement)
mailman_test.cfg:13:1: E0602: Undefined variable 'webservice' (undefined-variable)
mailman_test.cfg:16:0: W0104: Statement seems to have no effect (pointless-statement)
mailman_test.cfg:16:1: E0602: Undefined variable 'archiver' (undefined-variable)
mailman_test.cfg:17:8: E0602: Undefined variable 'yes' (undefined-variable)
mailman_test.cfg:19:0: W0104: Statement seems to have no effect (pointless-statement)
mailman_test.cfg:19:1: E0602: Undefined variable 'archiver' (undefined-variable)
mailman_test.cfg:20:8: E0602: Undefined variable 'yes' (undefined-variable)
mailman_test.cfg:22:0: W0104: Statement seems to have no effect (pointless-statement)
mailman_test.cfg:22:1: E0602: Undefined variable 'archiver' (undefined-variable)
mailman_test.cfg:23:8: E0602: Undefined variable 'yes' (undefined-variable)
************* Module Makefile
Makefile:5:0: E0001: invalid syntax (<unknown>, line 5) (syntax-error)
************* Module MANIFEST
MANIFEST.in:1:0: E0001: invalid syntax (<unknown>, line 1) (syntax-error)
************* Module pytest
pytest.ini:2:0: E0001: can't assign to operator (<unknown>, line 2) (syntax-error)
************* Module README
README.rst:1:0: E0001: invalid syntax (<unknown>, line 1) (syntax-error)
************* Module setup
setup.py:64:0: C0330: Wrong hanging indentation.
]
| ^| (bad-continuation)
setup.py:1:0: C0111: Missing module docstring (missing-docstring)
setup.py:26:0: C0111: Missing function docstring (missing-docstring)
setup.py:27:31: C0103: Variable name "fd" doesn't conform to snake_case naming style (invalid-name)
setup.py:19:0: C0411: third party import "from setuptools import setup, find_packages" should be placed before "from setup_helpers import get_version, require_python" (wrong-import-order)
************* Module setup_helpers
setup_helpers.py:27:0: C0103: Class name "__metaclass__" doesn't conform to PascalCase naming style (invalid-name)
setup_helpers.py:60:8: W0632: Possible unbalanced tuple unpacking with sequence defined at line 57: left side has 4 label(s), right side has 0 value(s) (unbalanced-tuple-unpacking)
setup_helpers.py:94:27: C0103: Variable name "fp" doesn't conform to snake_case naming style (invalid-name)
setup_helpers.py:97:16: C0103: Variable name "mo" doesn't conform to snake_case naming style (invalid-name)
setup_helpers.py:118:17: W0612: Unused variable 'dirnames' (unused-variable)
setup_helpers.py:131:62: C0103: Variable name "fp" doesn't conform to snake_case naming style (invalid-name)
setup_helpers.py:129:8: W0612: Unused variable 'base' (unused-variable)
setup_helpers.py:141:57: C0103: Variable name "fp" doesn't conform to snake_case naming style (invalid-name)
setup.py:64:0: C0330: Wrong hanging indentation.
]
| ^| (bad-continuation)
setup.py:1:0: C0111: Missing module docstring (missing-docstring)
setup.py:26:0: C0111: Missing function docstring (missing-docstring)
setup.py:27:31: C0103: Variable name "fd" doesn't conform to snake_case naming style (invalid-name)
setup.py:19:0: C0411: third party import "from setuptools import setup, find_packages" should be placed before "from setup_helpers import get_version, require_python" (wrong-import-order)
************* Module src.mailmanclient.conftest
src/mailmanclient/conftest.py:19:0: E0401: Unable to import 'pytest' (import-error)
src/mailmanclient/conftest.py:25:0: C0111: Missing function docstring (missing-docstring)
src/mailmanclient/conftest.py:27:8: R1703: The if statement can be replaced with 'return bool(test)' (simplifiable-if-statement)
src/mailmanclient/conftest.py:27:8: R1705: Unnecessary "else" after "return" (no-else-return)
src/mailmanclient/conftest.py:27:11: E1101: Instance of 'closing' has no 'connect_ex' member (no-member)
src/mailmanclient/conftest.py:20:0: C0411: standard import "import subprocess" should be placed before "import pytest" (wrong-import-order)
src/mailmanclient/conftest.py:21:0: C0411: standard import "import socket" should be placed before "import pytest" (wrong-import-order)
src/mailmanclient/conftest.py:22:0: C0411: standard import "from contextlib import closing" should be placed before "import pytest" (wrong-import-order)
************* Module src.mailmanclient
src/mailmanclient/__init__.py:39:0: C0103: Class name "__metaclass__" doesn't conform to PascalCase naming style (invalid-name)
src/mailmanclient/__init__.py:47:4: E0603: Undefined variable name 'DomainHeaderMatch' in __all__ (undefined-all-variable)
************* Module src.mailmanclient.constants
src/mailmanclient/constants.py:1:0: C0111: Missing module docstring (missing-docstring)
************* Module src.mailmanclient._client
src/mailmanclient/_client.py:25:2: W0511: XXX: This module exists for backwards compatibility with older versions of (fixme)
src/mailmanclient/_client.py:21:0: W0401: Wildcard import mailmanclient (wildcard-import)
src/mailmanclient/_client.py:23:0: C0103: Class name "__metaclass__" doesn't conform to PascalCase naming style (invalid-name)
src/mailmanclient/_client.py:21:0: W0614: Unused import Client from wildcard import (unused-wildcard-import)
src/mailmanclient/_client.py:21:0: W0614: Unused import MailmanConnectionError from wildcard import (unused-wildcard-import)
src/mailmanclient/_client.py:21:0: W0614: Unused import Address from wildcard import (unused-wildcard-import)
src/mailmanclient/_client.py:21:0: W0614: Unused import Addresses from wildcard import (unused-wildcard-import)
src/mailmanclient/_client.py:21:0: W0614: Unused import Bans from wildcard import (unused-wildcard-import)
src/mailmanclient/_client.py:21:0: W0614: Unused import BannedAddress from wildcard import (unused-wildcard-import)
src/mailmanclient/_client.py:21:0: W0614: Unused import Configuration from wildcard import (unused-wildcard-import)
src/mailmanclient/_client.py:21:0: W0614: Unused import Domain from wildcard import (unused-wildcard-import)
src/mailmanclient/_client.py:21:0: W0614: Unused import HeaderMatch from wildcard import (unused-wildcard-import)
src/mailmanclient/_client.py:21:0: W0614: Unused import HeaderMatches from wildcard import (unused-wildcard-import)
src/mailmanclient/_client.py:21:0: W0614: Unused import HeldMessage from wildcard import (unused-wildcard-import)
src/mailmanclient/_client.py:21:0: W0614: Unused import ListArchivers from wildcard import (unused-wildcard-import)
src/mailmanclient/_client.py:21:0: W0614: Unused import MailingList from wildcard import (unused-wildcard-import)
src/mailmanclient/_client.py:21:0: W0614: Unused import Member from wildcard import (unused-wildcard-import)
src/mailmanclient/_client.py:21:0: W0614: Unused import Preferences from wildcard import (unused-wildcard-import)
src/mailmanclient/_client.py:21:0: W0614: Unused import PreferencesMixin from wildcard import (unused-wildcard-import)
src/mailmanclient/_client.py:21:0: W0614: Unused import Queue from wildcard import (unused-wildcard-import)
src/mailmanclient/_client.py:21:0: W0614: Unused import Settings from wildcard import (unused-wildcard-import)
src/mailmanclient/_client.py:21:0: W0614: Unused import User from wildcard import (unused-wildcard-import)
************* Module src.mailmanclient.client
src/mailmanclient/client.py:39:0: C0103: Class name "__metaclass__" doesn't conform to PascalCase naming style (invalid-name)
src/mailmanclient/client.py:92:8: W0612: Unused variable 'response' (unused-variable)
src/mailmanclient/client.py:103:8: W0612: Unused variable 'response' (unused-variable)
src/mailmanclient/client.py:113:8: W0612: Unused variable 'response' (unused-variable)
src/mailmanclient/client.py:123:8: W0612: Unused variable 'response' (unused-variable)
src/mailmanclient/client.py:160:8: W0612: Unused variable 'response' (unused-variable)
src/mailmanclient/client.py:186:8: W0612: Unused variable 'response' (unused-variable)
src/mailmanclient/client.py:200:8: W0612: Unused variable 'response' (unused-variable)
src/mailmanclient/client.py:234:8: W0612: Unused variable 'response' (unused-variable)
src/mailmanclient/client.py:251:4: R0913: Too many arguments (6/5) (too-many-arguments)
src/mailmanclient/client.py:276:18: W0612: Unused variable 'content' (unused-variable)
src/mailmanclient/client.py:284:8: W0612: Unused variable 'response' (unused-variable)
src/mailmanclient/client.py:284:18: W0612: Unused variable 'content' (unused-variable)
src/mailmanclient/client.py:294:8: W0612: Unused variable 'response' (unused-variable)
src/mailmanclient/client.py:307:18: W0612: Unused variable 'content' (unused-variable)
src/mailmanclient/client.py:320:8: W0612: Unused variable 'response' (unused-variable)
src/mailmanclient/client.py:331:8: W0612: Unused variable 'response' (unused-variable)
src/mailmanclient/client.py:342:8: W0612: Unused variable 'response' (unused-variable)
src/mailmanclient/client.py:351:8: W0612: Unused variable 'response' (unused-variable)
src/mailmanclient/client.py:351:18: W0612: Unused variable 'content' (unused-variable)
src/mailmanclient/client.py:421:8: W0612: Unused variable 'response' (unused-variable)
src/mailmanclient/client.py:49:0: R0904: Too many public methods (30/20) (too-many-public-methods)
************* Module src.mailmanclient.testing.vcr_helpers
src/mailmanclient/testing/vcr_helpers.py:31:2: W0511: XXX: This module exists to maintain compatibility with some parts of (fixme)
src/mailmanclient/testing/vcr_helpers.py:20:0: E0401: Unable to import 'vcr' (import-error)
src/mailmanclient/testing/vcr_helpers.py:36:0: C0111: Missing function docstring (missing-docstring)
src/mailmanclient/testing/vcr_helpers.py:44:0: C0111: Missing function docstring (missing-docstring)
src/mailmanclient/testing/vcr_helpers.py:47:8: R1705: Unnecessary "else" after "return" (no-else-return)
src/mailmanclient/testing/vcr_helpers.py:63:12: W0212: Access to a protected member _body of a client class (protected-access)
src/mailmanclient/testing/vcr_helpers.py:63:28: W0212: Access to a protected member _body of a client class (protected-access)
src/mailmanclient/testing/vcr_helpers.py:67:8: W0212: Access to a protected member _body of a client class (protected-access)
src/mailmanclient/testing/vcr_helpers.py:67:39: W0212: Access to a protected member _body of a client class (protected-access)
src/mailmanclient/testing/vcr_helpers.py:71:0: C0111: Missing function docstring (missing-docstring)
src/mailmanclient/testing/vcr_helpers.py:80:0: C0103: Class name "vcr_testcase" doesn't conform to PascalCase naming style (invalid-name)
src/mailmanclient/testing/vcr_helpers.py:96:8: C0111: Missing class docstring (missing-docstring)
src/mailmanclient/testing/vcr_helpers.py:99:12: C0103: Method name "setUp" doesn't conform to snake_case naming style (invalid-name)
src/mailmanclient/testing/vcr_helpers.py:99:12: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/testing/vcr_helpers.py:100:16: C0103: Variable name "cm" doesn't conform to snake_case naming style (invalid-name)
src/mailmanclient/testing/vcr_helpers.py:96:8: R0903: Too few public methods (1/2) (too-few-public-methods)
src/mailmanclient/testing/vcr_helpers.py:22:0: C0411: standard import "from functools import update_wrapper" should be placed before "import vcr" (wrong-import-order)
src/mailmanclient/testing/vcr_helpers.py:23:0: C0411: third party import "from six import binary_type, text_type" should be placed before "import vcr" (wrong-import-order)
src/mailmanclient/testing/vcr_helpers.py:24:0: C0411: third party import "from six.moves.urllib.parse import urlparse, urlunparse, parse_qsl, urlencode" should be placed before "import vcr" (wrong-import-order)
************* Module src.mailmanclient.testing.documentation
src/mailmanclient/testing/documentation.py:22:0: C0103: Class name "__metaclass__" doesn't conform to PascalCase naming style (invalid-name)
src/mailmanclient/testing/documentation.py:28:0: C0111: Missing function docstring (missing-docstring)
************* Module src.mailmanclient.restbase.connection
src/mailmanclient/restbase/connection.py:1:0: C0111: Missing module docstring (missing-docstring)
src/mailmanclient/restbase/connection.py:20:0: E0401: Unable to import 'requests' (import-error)
src/mailmanclient/restbase/connection.py:24:0: C0103: Class name "__metaclass__" doesn't conform to PascalCase naming style (invalid-name)
src/mailmanclient/restbase/connection.py:103:15: C1801: Do not use `len(SEQUENCE)` to determine if a sequence is empty (len-as-condition)
src/mailmanclient/restbase/connection.py:35:0: R0903: Too few public methods (1/2) (too-few-public-methods)
************* Module src.mailmanclient.restbase.page
src/mailmanclient/restbase/page.py:1:0: C0111: Missing module docstring (missing-docstring)
src/mailmanclient/restbase/page.py:20:0: C0103: Class name "__metaclass__" doesn't conform to PascalCase naming style (invalid-name)
src/mailmanclient/restbase/page.py:26:0: C0111: Missing class docstring (missing-docstring)
src/mailmanclient/restbase/page.py:28:4: R0913: Too many arguments (6/5) (too-many-arguments)
src/mailmanclient/restbase/page.py:54:8: C0103: Variable name "qs" doesn't conform to snake_case naming style (invalid-name)
src/mailmanclient/restbase/page.py:62:8: W0612: Unused variable 'response' (unused-variable)
src/mailmanclient/restbase/page.py:70:4: C0103: Attribute name "nr" doesn't conform to snake_case naming style (invalid-name)
src/mailmanclient/restbase/page.py:70:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/restbase/page.py:74:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/restbase/page.py:80:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/restbase/page.py:80:4: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements)
src/mailmanclient/restbase/page.py:87:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/restbase/page.py:91:4: C0111: Missing method docstring (missing-docstring)
************* Module src.mailmanclient.restbase.base
src/mailmanclient/restbase/base.py:1:0: C0111: Missing module docstring (missing-docstring)
src/mailmanclient/restbase/base.py:19:0: C0103: Class name "__metaclass__" doesn't conform to PascalCase naming style (invalid-name)
src/mailmanclient/restbase/base.py:74:12: W0612: Unused variable 'response' (unused-variable)
src/mailmanclient/restbase/base.py:81:8: R1720: Unnecessary "else" after "raise" (no-else-raise)
src/mailmanclient/restbase/base.py:108:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/restbase/base.py:109:8: W0612: Unused variable 'response' (unused-variable)
src/mailmanclient/restbase/base.py:109:18: W0612: Unused variable 'content' (unused-variable)
src/mailmanclient/restbase/base.py:130:23: E1135: Value 'self._properties' doesn't support membership test (unsupported-membership-test)
src/mailmanclient/restbase/base.py:134:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/restbase/base.py:139:0: R0901: Too many ancestors (8/7) (too-many-ancestors)
src/mailmanclient/restbase/base.py:169:4: W0221: Parameters differ from overridden 'update' method (arguments-differ)
src/mailmanclient/restbase/base.py:179:0: R0901: Too many ancestors (8/7) (too-many-ancestors)
src/mailmanclient/restbase/base.py:192:12: W0612: Unused variable 'response' (unused-variable)
src/mailmanclient/restbase/base.py:216:4: C0111: Missing method docstring (missing-docstring)
************* Module src.mailmanclient.docs.conftest
src/mailmanclient/docs/conftest.py:21:0: E0401: Unable to import 'pytest' (import-error)
src/mailmanclient/docs/conftest.py:26:0: C0111: Missing function docstring (missing-docstring)
src/mailmanclient/docs/conftest.py:32:0: C0111: Missing function docstring (missing-docstring)
************* Module src.mailmanclient.tests.test_unicode
src/mailmanclient/tests/test_unicode.py:24:0: E0401: Unable to import 'pytest' (import-error)
src/mailmanclient/tests/test_unicode.py:31:0: C0103: Class name "__metaclass__" doesn't conform to PascalCase naming style (invalid-name)
src/mailmanclient/tests/test_unicode.py:37:0: C0111: Missing class docstring (missing-docstring)
src/mailmanclient/tests/test_unicode.py:52:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/tests/test_unicode.py:58:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/tests/test_unicode.py:64:8: C0103: Variable name "e" doesn't conform to snake_case naming style (invalid-name)
src/mailmanclient/tests/test_unicode.py:25:0: C0411: standard import "import unittest" should be placed before "import pytest" (wrong-import-order)
src/mailmanclient/tests/test_unicode.py:28:0: C0411: third party import "from six.moves.urllib_error import HTTPError" should be placed before "import pytest" (wrong-import-order)
************* Module src.mailmanclient.tests.test_domain
src/mailmanclient/tests/test_domain.py:23:0: E0401: Unable to import 'pytest' (import-error)
src/mailmanclient/tests/test_domain.py:29:0: C0103: Class name "__metaclass__" doesn't conform to PascalCase naming style (invalid-name)
src/mailmanclient/tests/test_domain.py:35:0: C0111: Missing class docstring (missing-docstring)
src/mailmanclient/tests/test_domain.py:41:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/tests/test_domain.py:26:0: C0411: third party import "from six.moves.urllib_error import HTTPError" should be placed before "import pytest" (wrong-import-order)
************* Module src.mailmanclient.tests.test_templates
src/mailmanclient/tests/test_templates.py:31:40: C0326: Exactly one space required after comma
'http://localhost:9001/3.1/', 'restadmin', 'restpass')
^ (bad-whitespace)
src/mailmanclient/tests/test_templates.py:44:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/tests/test_templates.py:74:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/tests/test_templates.py:88:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/tests/test_templates.py:101:4: C0111: Missing method docstring (missing-docstring)
************* Module src.mailmanclient.tests.test_page
src/mailmanclient/tests/test_page.py:23:0: E0401: Unable to import 'pytest' (import-error)
src/mailmanclient/tests/test_page.py:30:0: C0103: Class name "__metaclass__" doesn't conform to PascalCase naming style (invalid-name)
src/mailmanclient/tests/test_page.py:36:0: C0111: Missing class docstring (missing-docstring)
src/mailmanclient/tests/test_page.py:39:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/tests/test_page.py:43:37: W0212: Access to a protected member _build_url of a client class (protected-access)
src/mailmanclient/tests/test_page.py:48:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/tests/test_page.py:52:37: W0212: Access to a protected member _build_url of a client class (protected-access)
src/mailmanclient/tests/test_page.py:24:0: C0411: standard import "from unittest.mock import Mock" should be placed before "import pytest" (wrong-import-order)
src/mailmanclient/tests/test_page.py:25:0: C0411: standard import "from urllib.parse import urlsplit, parse_qs" should be placed before "import pytest" (wrong-import-order)
************* Module src.mailmanclient.tests.test_list
src/mailmanclient/tests/test_list.py:26:0: C0111: Missing class docstring (missing-docstring)
src/mailmanclient/tests/test_list.py:40:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/tests/test_list.py:63:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/tests/test_list.py:80:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/tests/test_list.py:98:4: C0111: Missing method docstring (missing-docstring)
************* Module src.mailmanclient.restobjects.templates
src/mailmanclient/restobjects/templates.py:32:38: C0326: Exactly one space required after comma
def __init__(self, connection, url, data=None, context=None):
^ (bad-whitespace)
src/mailmanclient/restobjects/templates.py:30:0: C0111: Missing class docstring (missing-docstring)
src/mailmanclient/restobjects/templates.py:30:0: R0901: Too many ancestors (9/7) (too-many-ancestors)
src/mailmanclient/restobjects/templates.py:33:8: E1003: Bad first argument 'RESTList' given to super() (bad-super-call)
src/mailmanclient/restobjects/templates.py:32:52: W0613: Unused argument 'context' (unused-argument)
src/mailmanclient/restobjects/templates.py:38:0: C0111: Missing class docstring (missing-docstring)
************* Module src.mailmanclient.restobjects.styles
src/mailmanclient/restobjects/styles.py:1:0: C0111: Missing module docstring (missing-docstring)
src/mailmanclient/restobjects/styles.py:19:0: C0111: Missing class docstring (missing-docstring)
src/mailmanclient/restobjects/styles.py:19:0: R0901: Too many ancestors (9/7) (too-many-ancestors)
src/mailmanclient/restobjects/styles.py:19:0: W0223: Method '__delitem__' is abstract in class 'RESTDict' but is not overridden (abstract-method)
************* Module src.mailmanclient.restobjects.preferences
src/mailmanclient/restobjects/preferences.py:1:0: C0111: Missing module docstring (missing-docstring)
src/mailmanclient/restobjects/preferences.py:18:0: C0103: Class name "__metaclass__" doesn't conform to PascalCase naming style (invalid-name)
src/mailmanclient/restobjects/preferences.py:25:0: C0111: Missing class docstring (missing-docstring)
src/mailmanclient/restobjects/preferences.py:25:0: R0901: Too many ancestors (9/7) (too-many-ancestors)
src/mailmanclient/restobjects/preferences.py:25:0: W0223: Method '__delitem__' is abstract in class 'RESTDict' but is not overridden (abstract-method)
src/mailmanclient/restobjects/preferences.py:33:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/restobjects/preferences.py:34:8: W0612: Unused variable 'response' (unused-variable)
src/mailmanclient/restobjects/preferences.py:34:18: W0612: Unused variable 'content' (unused-variable)
src/mailmanclient/restobjects/preferences.py:41:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/restobjects/preferences.py:37:0: R0903: Too few public methods (1/2) (too-few-public-methods)
************* Module src.mailmanclient.restobjects.member
src/mailmanclient/restobjects/member.py:53:2: W0511: TODO: call .delete() instead? (fixme)
src/mailmanclient/restobjects/member.py:1:0: C0111: Missing module docstring (missing-docstring)
src/mailmanclient/restobjects/member.py:19:0: C0103: Class name "__metaclass__" doesn't conform to PascalCase naming style (invalid-name)
src/mailmanclient/restobjects/member.py:25:0: C0111: Missing class docstring (missing-docstring)
src/mailmanclient/restobjects/member.py:41:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/restobjects/member.py:46:4: C0111: Missing method docstring (missing-docstring)
************* Module src.mailmanclient.restobjects.user
src/mailmanclient/restobjects/user.py:1:0: C0111: Missing module docstring (missing-docstring)
src/mailmanclient/restobjects/user.py:22:0: C0103: Class name "__metaclass__" doesn't conform to PascalCase naming style (invalid-name)
src/mailmanclient/restobjects/user.py:28:0: C0111: Missing class docstring (missing-docstring)
src/mailmanclient/restobjects/user.py:44:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/restobjects/user.py:58:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/restobjects/user.py:63:16: W0612: Unused variable 'response' (unused-variable)
src/mailmanclient/restobjects/user.py:75:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/restobjects/user.py:99:18: W0612: Unused variable 'content' (unused-variable)
************* Module src.mailmanclient.restobjects.settings
src/mailmanclient/restobjects/settings.py:1:0: C0111: Missing module docstring (missing-docstring)
src/mailmanclient/restobjects/settings.py:18:0: C0103: Class name "__metaclass__" doesn't conform to PascalCase naming style (invalid-name)
src/mailmanclient/restobjects/settings.py:24:0: C0111: Missing class docstring (missing-docstring)
src/mailmanclient/restobjects/settings.py:24:0: R0901: Too many ancestors (9/7) (too-many-ancestors)
src/mailmanclient/restobjects/settings.py:24:0: W0223: Method '__delitem__' is abstract in class 'RESTDict' but is not overridden (abstract-method)
************* Module src.mailmanclient.restobjects.mailinglist
src/mailmanclient/restobjects/mailinglist.py:1:0: C0111: Missing module docstring (missing-docstring)
src/mailmanclient/restobjects/mailinglist.py:30:0: C0103: Class name "__metaclass__" doesn't conform to PascalCase naming style (invalid-name)
src/mailmanclient/restobjects/mailinglist.py:36:0: C0111: Missing class docstring (missing-docstring)
src/mailmanclient/restobjects/mailinglist.py:50:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/restobjects/mailinglist.py:53:8: R1705: Unnecessary "else" after "return" (no-else-return)
src/mailmanclient/restobjects/mailinglist.py:52:8: W0612: Unused variable 'response' (unused-variable)
src/mailmanclient/restobjects/mailinglist.py:61:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/restobjects/mailinglist.py:64:8: R1705: Unnecessary "else" after "return" (no-else-return)
src/mailmanclient/restobjects/mailinglist.py:63:8: W0612: Unused variable 'response' (unused-variable)
src/mailmanclient/restobjects/mailinglist.py:72:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/restobjects/mailinglist.py:74:8: W0612: Unused variable 'response' (unused-variable)
src/mailmanclient/restobjects/mailinglist.py:82:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/restobjects/mailinglist.py:86:8: W0612: Unused variable 'response' (unused-variable)
src/mailmanclient/restobjects/mailinglist.py:93:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/restobjects/mailinglist.py:97:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/restobjects/mailinglist.py:105:8: R1705: Unnecessary "else" after "return" (no-else-return)
src/mailmanclient/restobjects/mailinglist.py:106:12: W0612: Unused variable 'response' (unused-variable)
src/mailmanclient/restobjects/mailinglist.py:115:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/restobjects/mailinglist.py:125:8: W0612: Unused variable 'response' (unused-variable)
src/mailmanclient/restobjects/mailinglist.py:132:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/restobjects/mailinglist.py:136:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/restobjects/mailinglist.py:145:8: R1705: Unnecessary "else" after "return" (no-else-return)
src/mailmanclient/restobjects/mailinglist.py:143:8: W0612: Unused variable 'response' (unused-variable)
src/mailmanclient/restobjects/mailinglist.py:159:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/restobjects/mailinglist.py:170:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/restobjects/mailinglist.py:173:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/restobjects/mailinglist.py:176:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/restobjects/mailinglist.py:183:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/restobjects/mailinglist.py:186:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/restobjects/mailinglist.py:189:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/restobjects/mailinglist.py:203:18: W0612: Unused variable 'content' (unused-variable)
src/mailmanclient/restobjects/mailinglist.py:231:18: W0612: Unused variable 'content' (unused-variable)
src/mailmanclient/restobjects/mailinglist.py:269:12: W0612: Unused variable 'response' (unused-variable)
src/mailmanclient/restobjects/mailinglist.py:275:4: R0913: Too many arguments (6/5) (too-many-arguments)
src/mailmanclient/restobjects/mailinglist.py:328:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/restobjects/mailinglist.py:333:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/restobjects/mailinglist.py:339:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/restobjects/mailinglist.py:344:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/restobjects/mailinglist.py:348:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/restobjects/mailinglist.py:364:8: W0612: Unused variable 'response' (unused-variable)
src/mailmanclient/restobjects/mailinglist.py:36:0: R0904: Too many public methods (41/20) (too-many-public-methods)
************* Module src.mailmanclient.restobjects.header_match
src/mailmanclient/restobjects/header_match.py:1:0: C0111: Missing module docstring (missing-docstring)
src/mailmanclient/restobjects/header_match.py:18:0: C0103: Class name "__metaclass__" doesn't conform to PascalCase naming style (invalid-name)
src/mailmanclient/restobjects/header_match.py:25:0: R0901: Too many ancestors (9/7) (too-many-ancestors)
src/mailmanclient/restobjects/header_match.py:59:18: W0612: Unused variable 'content' (unused-variable)
src/mailmanclient/restobjects/header_match.py:64:0: C0111: Missing class docstring (missing-docstring)
************* Module src.mailmanclient.restobjects.queue
src/mailmanclient/restobjects/queue.py:1:0: C0111: Missing module docstring (missing-docstring)
src/mailmanclient/restobjects/queue.py:18:0: C0103: Class name "__metaclass__" doesn't conform to PascalCase naming style (invalid-name)
src/mailmanclient/restobjects/queue.py:24:0: C0111: Missing class docstring (missing-docstring)
src/mailmanclient/restobjects/queue.py:31:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/restobjects/queue.py:35:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/restobjects/queue.py:37:8: W0612: Unused variable 'response' (unused-variable)
************* Module src.mailmanclient.restobjects.ban
src/mailmanclient/restobjects/ban.py:1:0: C0111: Missing module docstring (missing-docstring)
src/mailmanclient/restobjects/ban.py:21:0: C0103: Class name "__metaclass__" doesn't conform to PascalCase naming style (invalid-name)
src/mailmanclient/restobjects/ban.py:28:0: R0901: Too many ancestors (9/7) (too-many-ancestors)
src/mailmanclient/restobjects/ban.py:45:8: R1705: Unnecessary "else" after "return" (no-else-return)
src/mailmanclient/restobjects/ban.py:54:8: R1705: Unnecessary "else" after "return" (no-else-return)
src/mailmanclient/restobjects/ban.py:61:12: C0103: Variable name "e" doesn't conform to snake_case naming style (invalid-name)
src/mailmanclient/restobjects/ban.py:62:16: R1705: Unnecessary "else" after "return" (no-else-return)
src/mailmanclient/restobjects/ban.py:59:16: W0612: Unused variable 'response' (unused-variable)
src/mailmanclient/restobjects/ban.py:59:26: W0612: Unused variable 'content' (unused-variable)
src/mailmanclient/restobjects/ban.py:69:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/restobjects/ban.py:70:18: W0612: Unused variable 'content' (unused-variable)
src/mailmanclient/restobjects/ban.py:75:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/restobjects/ban.py:81:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/restobjects/ban.py:90:0: C0111: Missing class docstring (missing-docstring)
src/mailmanclient/restobjects/ban.py:102:4: C0111: Missing method docstring (missing-docstring)
************* Module src.mailmanclient.restobjects.archivers
src/mailmanclient/restobjects/archivers.py:1:0: C0111: Missing module docstring (missing-docstring)
src/mailmanclient/restobjects/archivers.py:18:0: C0103: Class name "__metaclass__" doesn't conform to PascalCase naming style (invalid-name)
src/mailmanclient/restobjects/archivers.py:24:0: R0901: Too many ancestors (9/7) (too-many-ancestors)
src/mailmanclient/restobjects/archivers.py:24:0: W0223: Method '__delitem__' is abstract in class 'RESTDict' but is not overridden (abstract-method)
************* Module src.mailmanclient.restobjects.address
src/mailmanclient/restobjects/address.py:1:0: C0111: Missing module docstring (missing-docstring)
src/mailmanclient/restobjects/address.py:19:0: C0103: Class name "__metaclass__" doesn't conform to PascalCase naming style (invalid-name)
src/mailmanclient/restobjects/address.py:26:0: C0111: Missing class docstring (missing-docstring)
src/mailmanclient/restobjects/address.py:26:0: R0901: Too many ancestors (9/7) (too-many-ancestors)
src/mailmanclient/restobjects/address.py:33:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/restobjects/address.py:39:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/restobjects/address.py:48:0: C0111: Missing class docstring (missing-docstring)
src/mailmanclient/restobjects/address.py:60:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/restobjects/address.py:62:8: R1705: Unnecessary "else" after "return" (no-else-return)
src/mailmanclient/restobjects/address.py:68:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/restobjects/address.py:71:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/restobjects/address.py:76:4: C0111: Missing method docstring (missing-docstring)
************* Module src.mailmanclient.restobjects.domain
src/mailmanclient/restobjects/domain.py:94:2: W0511: TODO: Add this when the API supports removing a single owner. (fixme)
src/mailmanclient/restobjects/domain.py:1:0: C0111: Missing module docstring (missing-docstring)
src/mailmanclient/restobjects/domain.py:24:0: C0103: Class name "__metaclass__" doesn't conform to PascalCase naming style (invalid-name)
src/mailmanclient/restobjects/domain.py:30:0: C0111: Missing class docstring (missing-docstring)
src/mailmanclient/restobjects/domain.py:41:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/restobjects/domain.py:49:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/restobjects/domain.py:57:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/restobjects/domain.py:60:8: R1705: Unnecessary "else" after "return" (no-else-return)
src/mailmanclient/restobjects/domain.py:59:8: W0612: Unused variable 'response' (unused-variable)
src/mailmanclient/restobjects/domain.py:67:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/restobjects/domain.py:70:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/restobjects/domain.py:74:8: W0612: Unused variable 'response' (unused-variable)
src/mailmanclient/restobjects/domain.py:80:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/restobjects/domain.py:86:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/restobjects/domain.py:91:18: W0612: Unused variable 'content' (unused-variable)
src/mailmanclient/restobjects/domain.py:101:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/restobjects/domain.py:103:18: W0612: Unused variable 'content' (unused-variable)
src/mailmanclient/restobjects/domain.py:107:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/restobjects/domain.py:109:8: W0612: Unused variable 'response' (unused-variable)
src/mailmanclient/restobjects/domain.py:109:18: W0612: Unused variable 'content' (unused-variable)
src/mailmanclient/restobjects/domain.py:113:4: C0111: Missing method docstring (missing-docstring)
src/mailmanclient/restobjects/domain.py:117:4: C0111: Missing method docstring (missing-docstring)
************* Module src.mailmanclient.restobjects.held_message
src/mailmanclient/restobjects/held_message.py:1:0: C0111: Missing module docstring (missing-docstring)
src/mailmanclient/restobjects/held_message.py:19:0: C0103: Class name "__metaclass__" doesn't conform to PascalCase naming style (invalid-name)
src/mailmanclient/restobjects/held_message.py:25:0: C0111: Missing class docstring (missing-docstring)
src/mailmanclient/restobjects/held_message.py:40:18: W0612: Unused variable 'content' (unused-variable)
************* Module src.mailmanclient.restobjects.configuration
src/mailmanclient/restobjects/configuration.py:1:0: C0111: Missing module docstring (missing-docstring)
src/mailmanclient/restobjects/configuration.py:18:0: C0103: Class name "__metaclass__" doesn't conform to PascalCase naming style (invalid-name)
src/mailmanclient/restobjects/configuration.py:24:0: C0111: Missing class docstring (missing-docstring)
src/mailmanclient/restobjects/configuration.py:24:0: R0901: Too many ancestors (9/7) (too-many-ancestors)
src/mailmanclient/restobjects/configuration.py:24:0: W0223: Method '__delitem__' is abstract in class 'RESTDict' but is not overridden (abstract-method)
************* Module tox
tox.ini:2:0: E0001: invalid syntax (<unknown>, line 2) (syntax-error)
tox.ini:1:0: R0801: Similar lines in 2 files
==setup:17
==setup:17
from setup_helpers import get_version, require_python
from setuptools import setup, find_packages
require_python(0x30500f0)
__version__ = get_version('src/mailmanclient/constants.py')
def readme():
with open('README.rst') as fd:
return fd.read()
setup(
name='mailmanclient',
version=__version__,
packages=find_packages('src'),
description='mailmanclient -- Python bindings for Mailman REST API',
long_description=readme(),
long_description_content_type='text/x-rst',
package_dir={'': 'src'},
include_package_data=True,
maintainer='Barry Warsaw',
maintainer_email='barry@list.org',
license='LGPLv3',
url='http://www.list.org/',
classifiers=[
'License :: OSI Approved :: GNU General Public License v3 or later (GPLv3+)', # noqa
'Operating System :: POSIX',
'Programming Language :: Python :: 3.5',
'Programming Language :: Python :: 3.6',
'Programming Language :: Python :: 3.7',
'Topic :: Internet :: WWW/HTTP ',
],
install_requires=[
'requests',
],
extras_require={
'testing': [
'pytest',
'pytest-vcr',
'pytest-services',
'mailman',
],
'lint': [
'flake8>3.0'
]
},
) (duplicate-code)
tox.ini:1:0: R0801: Similar lines in 2 files
==src.mailmanclient.restobjects.domain:111
==src.mailmanclient.restobjects.mailinglist:342
@property
def templates(self):
url = self._url + '/uris'
return TemplateList(self._connection, url)
def set_template(self, template_name, uri, username=None, password=None):
url = self._url + '/uris'
data = {template_name: uri}
if username is not None and password is not None:
data['username'] = username
data['password'] = password
return self._connection.call(url, data, 'PATCH')[1] (duplicate-code)
tox.ini:1:0: R0801: Similar lines in 2 files
==src.mailmanclient.client:157
==src.mailmanclient.restobjects.domain:71
if advertised:
url += '?advertised=true'
response, content = self._connection.call(url)
if 'entries' not in content:
return []
return [MailingList(self._connection, entry['self_link'], entry)
for entry in content['entries']]
def get_list_page(self, count=50, page=1, advertised=None): (duplicate-code)
-----------------------------------
Your code has been rated at 6.21/10
Edited by Hrithik Adhikari