Commit 590d9127 authored by Abhilash Raj's avatar Abhilash Raj

Merge branch 'fix-aa' into 'master'

Do not convert lists to strings when url-encoding.

Closes #28

See merge request !70
parents ab990b4d a67f9323
Pipeline #22602873 passed with stage
in 3 minutes and 14 seconds
......@@ -15,10 +15,9 @@
# along with mailmanclient. If not, see <>.
import json
from base64 import b64encode
from six.moves.urllib_error import HTTPError
from six.moves.urllib_parse import urljoin, urlencode
from urllib.error import HTTPError
from urllib.parse import urljoin, urlencode
import six
from httplib2 import Http
from mailmanclient.constants import __version__
......@@ -81,10 +80,7 @@ class Connection:
data_str = None
if data is not None:
for k, v in data.items():
if not isinstance(v, bytes):
data[k] = six.text_type(v).encode('utf-8')
data_str = urlencode(data, doseq=True)
data_str = urlencode(data, doseq=True, encoding='utf-8')
headers['Content-Type'] = 'application/x-www-form-urlencoded'
if method is None:
if data_str is None:
......@@ -104,7 +100,7 @@ class Connection:
if len(content) == 0:
return response, None
# XXX Work around for
if isinstance(content, six.binary_type):
if isinstance(content, bytes):
content = content.decode('utf-8')
return response, json.loads(content)
except HTTPError:
......@@ -2,6 +2,7 @@
envlist = py{35,36},lint
basepython = python3
usedevelop = True
commands = python -m pytest --vcr-record-mode=once
deps =
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment