1. 29 Aug, 2020 2 commits
  2. 27 Aug, 2020 3 commits
    • Matthew Fernandez's avatar
      Merge branch '571f1f84-a955-4e9b-9911-445f7435dc5a' into 'master' · 5482734c
      Matthew Fernandez authored
      fix Pango plugin build on macOS
      
      See merge request graphviz/graphviz!1533
      5482734c
    • Matthew Fernandez's avatar
      update CMake Cairo discovery to match PangoCairo · b4f998c1
      Matthew Fernandez authored
      This does the equivalent of the previous commit, to now use pkg-config to
      discover Cairo on non-Windows platforms and to suppress the CMake warning:
      
        CMake Warning (dev) at ...FindPackageHandleStandardArgs.cmake:272 (message):
          The package name passed to `find_package_handle_standard_args` (CAIRO) does
          not match the name of the calling package (Cairo).  This can lead to
          problems in calling code that expects `find_package` result variables
          (e.g., `_FOUND`) to follow a certain pattern.
        Call Stack (most recent call first):
          cmake/FindCairo.cmake:12 (find_package_handle_standard_args)
          CMakeLists.txt:81 (find_package)
        This warning is for project developers.  Use -Wno-dev to suppress it.
      b4f998c1
    • Matthew Fernandez's avatar
      fix Pango plugin build on macOS · 3ecf2f62
      Matthew Fernandez authored
      Compiling plugin/pango depends on the discovery of PangoCairo and its dependent
      libraries which is handled by cmake/FindPangoCairo.cmake. This file was assuming
      all libraries were available at default system paths, which is not true on e.g.
      macOS when you install libraries via Homebrew or Macports. We now simply ask
      pkg-config to find all necessary information for us (unless we are on Windows).
      
      This also incidentally cleans up the following warning issued by CMake in CI:
      
        CMake Warning (dev) at C:/…/FindPackageHandleStandardArgs.cmake:272 (message):
          The package name passed to `find_package_handle_standard_args` (PANGOCAIRO)
          does not match the name of the calling package (PangoCairo).  This can lead
          to problems in calling code that expects `find_package` result variables
          (e.g., `_FOUND`) to follow a certain pattern.
        Call Stack (most recent call first):
          cmake/FindPangoCairo.cmake:20 (find_package_handle_standard_args)
          CMakeLists.txt:85 (find_package)
        This warning is for project developers.  Use -Wno-dev to suppress it.
      3ecf2f62
  3. 26 Aug, 2020 10 commits
  4. 25 Aug, 2020 11 commits
  5. 24 Aug, 2020 3 commits
  6. 23 Aug, 2020 5 commits
  7. 22 Aug, 2020 3 commits
    • Matthew Fernandez's avatar
      fix macOS lexer compilation · 429718cb
      Matthew Fernandez authored
      Commits 3b00c1fc and
      5162bfe8 removed find-and-replace of an isatty
      string, which exposed the following compilation error on macOS:
      
        [ 69%] Building C object lib/cgraph/CMakeFiles/cgraph.dir/grammar.c.o
        [ 70%] Building C object lib/cgraph/CMakeFiles/cgraph.dir/scan.c.o
        /Users/north/src/graphviz/build/lib/cgraph/scan.c:1706:12: error: expected
              identifier or '('
        extern int isatty (int );
                   ^
        scan.l:44:19: note: expanded from macro 'isatty'
        #define isatty(x) 0
                          ^
        1 error generated.
        make[2]: *** [lib/cgraph/CMakeFiles/cgraph.dir/scan.c.o] Error 1
        make[1]: *** [lib/cgraph/CMakeFiles/cgraph.dir/all] Error 2
        make: *** [all] Error 2
      
      which conveniently explained why this find-and-replace had existed in the first
      place. Rather than reverting this, the present change uses a more principled way
      of instructing Flex not to call isatty().
      
      This reverts 40a5a33a. Related to #1796, !1522,
      !1523.
      429718cb
    • Matthew Fernandez's avatar
      Merge branch '615aeb22-3c3f-43de-a7d4-e4d13756436f' into 'master' · 276ed587
      Matthew Fernandez authored
      suppress two compiler warnings
      
      See merge request graphviz/graphviz!1528
      276ed587
    • Matthew Fernandez's avatar
      suppress two compiler warnings · eddf90af
      Matthew Fernandez authored
      Commits 02d2cacf and
      80a9dc3a accidentally introduced two new
      compiler warnings to the build. Following this change, the CMake build returns
      to warning-free on Linux with GCC 8.3.0. The Autotools build still sprays
      warnings, but I think it's worth taking proactive steps like this to never
      introduce new warnings.
      
      Though this change looks like it has a semantic effect, it does not. The base
      member of these structs is the first member, used as an inheritance-style
      pattern.
      eddf90af
  8. 21 Aug, 2020 1 commit
  9. 20 Aug, 2020 2 commits