Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
LilyPond
LilyPond
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 1,063
    • Issues 1,063
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 15
    • Merge Requests 15
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Security & Compliance
    • Security & Compliance
    • Dependency List
    • License Compliance
  • Operations
    • Operations
    • Metrics
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • LilyPond
  • LilyPondLilyPond
  • Merge Requests
  • !328

Merged
Opened Aug 14, 2020 by Kevin Barry@barrykpDeveloper

Avoid X-offset callbacks when getting pure Y aligned side

  • Overview 13
  • Commits 1
  • Pipelines 8
  • Changes 2

When a cross-staff beam calls pure_relative_y_coordinate from its consider_auto_knees method the chain of pure calls can eventually result in calling the X-offset callback of a grob in the axis group, which can trigger callbacks for properties that are still "calculation-in-progress".

Explicitly cater for this scenario by avoiding calling parent_relative(X_AXIS) when we are trying to get pure Y relative values for a grob (this is the first point in the call chain where calls stop being pure); assume 0 instead (the default value returned by parent_relative) since we can never have a meaningful X coordinate for the spanner at this point anyway.

Add regression tests for the issues this fixes.

Closes #4182 (closed)
Closes #4691 (closed)

Edited Aug 15, 2020 by Kevin Barry
Assignee
Assign to
Reviewer
Request review from
2.21.6
Milestone
2.21.6 (Past due)
Assign milestone
Time tracking
Reference: lilypond/lilypond!328
Source branch: issue/4182