'Grand Replace' problems
Alas, !1797 (merged) wasn't as smooth as I thought. I missed the following problems because it is a pain to view such large diffs in gitlab's browser interface, and it seems to me that at least the first problem is unexpected and didn't happen in earlier Grand Replace rounds.
-
Copyright years (in contrast to copyright year ranges) were mistreated by the Python script. Here is an example with a potential fix – of course, it's actually the Python script that should be fixed.
diff --git a/flower/test-matrix.cc b/flower/test-matrix.cc index a9b2a840d2..9651d4e878 100644 --- a/flower/test-matrix.cc +++ b/flower/test-matrix.cc @@ -1,7 +1,7 @@ /* This file is part of LilyPond, the GNU music typesetter. - P22--2023 Daniel Eble <nine.fierce.ballads@gmail.com> + Copyright (C) 2022--2023 Daniel Eble <nine.fierce.ballads@gmail.com> LilyPond is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by
-
Lines containing only a copyright year or range without
Copyright
are ignored. Here is an example with a potential fix. Not sure whether it makes sense to make the Python script handle this, or whether this should be fixed manually. I usedgit grep ' [12][0-9][0-9][0-9][ -]'
to find affected lines.diff --git a/scripts/build/lys-to-tely.py b/scripts/build/lys-to-tely.py index d6fb8e9462..bf5a240ce6 100644 --- a/scripts/build/lys-to-tely.py +++ b/scripts/build/lys-to-tely.py @@ -2,8 +2,8 @@ # # This file is part of LilyPond, the GNU music typesetter. # -# Copyright (C) 2002--2023 Han-Wen Nienhuys <hanwen@xs4all.nl>, -# 2001 Jan Nieuwenhuizen <janneke@gnu.org> +# Copyright (C) 2002--2023 Han-Wen Nienhuys <hanwen@xs4all.nl> +# Copyright (C) 2001--2023 Jan Nieuwenhuizen <janneke@gnu.org> # # LilyPond is free software: you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by