Skip to content

[#2056] Add basic support for sig items in scopes

Motivation and Context

Resolves some false negative errors about interfaces and modules. Adds very basic support for sig items. A new MR will be created later with proper code navigation, as there are still some problems in this MR.

Related issues

Part of #2056 (closed). Support for code navigation will be added in a later MR.

Checklist for the LIGO Language Server

  • I checked whether I need to update the README.md file for the plugin and did so if necessary:
    • If I implemented a new LSP request, I added it to the list of supported features that may be disabled
    • If I implemented a new LSP method, I added it to the list of supported functionality
  • I checked that my changes work in Emacs, Vim, and Visual Studio Code
  • (Before merging) The commit history is squashed and prettified, and follows the Serokell commit policy, or the MR is set to squash the commits

Description

For scopes, the changes were mostly done by going through the passes and adding the missing functions for handling the different things to handle interfaces and signatures.

Some parts are still unimplemented due to the complexity (and unfamiliarity) of scopes, but the current changes are good enough to clear some false positives.

I also fixed syntax highlighting that was a bit broken: include wasn't recognized, and attributes weren't working well.

Component

  • compiler
  • website
  • webide
  • vscode-plugin
  • debugger

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Performance improvement (non-breaking change that improves performance)
  • None (change with no changelog)

Changelog

Resolved some false negative errors in the LSP regarding interfaces and signatures and added some very basic support for them. Support for code navigation will come later.

Checklist:

  • Changes follow the existing coding style (use dune @fmt to check).
  • Tests for the changes have been added (for bug fixes / feature).
  • Documentation has been updated.
  • Changelog description has been added (if appropriate).
  • Start titles under ## Changelog section with #### (if appropriate).
  • There is no image or uploaded file in changelog
  • Examples in changed behaviour have been added to the changelog (for breaking change / feature).

Merge request reports