policy-revoke-new-commitment-signed failed

Summary

Integration test failed with:

[2024-02-23 04:15:36.234 [01;31m[Kvlsd2/vls_proxy::grpc::signer INFO] signer got request[m[K 380 dbid 1 - GetPerCommitmentPoint(GetPerCommitmentPoint { commitment_number: 5 })
[2024-02-23 04:15:36.234 [01;31m[Kvlsd2/lightning_signer::policy WARN[m[K] policy failed: policy-revoke-new-commitment-signed get_per_commitment_secret: cannot revoke commitment_number 3 when next_holder_commit_num is 4
[2024-02-23 04:15:36.235 [01;31m[Kvlsd2/lightning_signer::util::status ERROR[m[K] FAILED PRECONDITION: policy failure: get_per_commitment_secret: cannot revoke commitment_number 3 when next_holder_commit_num is 4

Failed ci job: https://gitlab.com/lightning-signer/vls-hsmd/-/jobs/6239684891

Integration test logs: 2024-02-revoke-current-bad.tar.gz

[user@devel-usb vls-hsmd] git:(2024-02-remote-hsmd-v24.02) 1≡ 1M$ make list-versions 
vls-hsmd (vls-v0.11.0-rc.1-33-g4014e0c)
 26bff4e8102e989a50c9d9a4339fca3e71cad8aa lightning (v24.02rc2-18-g26bff4e81)
 8b0ed51ae9189de7508195470ea288cfea63bc80 vls (v0.11.0-rc.2-6-g8b0ed51a)

To run locally:

make test-one TEST=tests/test_connection.py::test_mutual_reconnect_race

The CI test failed in test-openv1-enforcing-socket` mode which is our "core" test mode.

This test does not fail reliably, subsequent retry of the run worked.

The symptom is interesting, it might be the case that we are missing another conversion of a GetCommitmentPoint to RevokeCommitmentTx