Skip to content
  • Felix Lange's avatar
    693d9ccb
    trie: more node iterator improvements (#14615) · 693d9ccb
    Felix Lange authored
    * ethdb: remove Set
    
    Set deadlocks immediately and isn't part of the Database interface.
    
    * trie: add Err to Iterator
    
    This is useful for testing because the underlying NodeIterator doesn't
    need to be kept in a separate variable just to get the error.
    
    * trie: add LeafKey to iterator, panic when not at leaf
    
    LeafKey is useful for callers that can't interpret Path.
    
    * trie: retry failed seek/peek in iterator Next
    
    Instead of failing iteration irrecoverably, make it so Next retries the
    pending seek or peek every time.
    
    Smaller changes in this commit make this easier to test:
    
    * The iterator previously returned from Next on encountering a hash
      node. This caused it to visit the same path twice.
    * Path returned nibbles with terminator symbol for valueNode attached
      to fullNode, but removed it for valueNode attached to shortNode. Now
      the terminator is always present. This makes Path unique to each node
      and simplifies Leaf.
    
    * trie: add Path to MissingNodeError
    
    The light client trie iterator needs to know the path of the node that's
    missing so it can retrieve a proof for it. NodeIterator.Path is not
    sufficient because it is updated when the node is resolved and actually
    visited by the iterator.
    
    Also remove unused fields. They were added a long time ago before we
    knew which fields would be needed for the light client.
    693d9ccb
    trie: more node iterator improvements (#14615)
    Felix Lange authored
    * ethdb: remove Set
    
    Set deadlocks immediately and isn't part of the Database interface.
    
    * trie: add Err to Iterator
    
    This is useful for testing because the underlying NodeIterator doesn't
    need to be kept in a separate variable just to get the error.
    
    * trie: add LeafKey to iterator, panic when not at leaf
    
    LeafKey is useful for callers that can't interpret Path.
    
    * trie: retry failed seek/peek in iterator Next
    
    Instead of failing iteration irrecoverably, make it so Next retries the
    pending seek or peek every time.
    
    Smaller changes in this commit make this easier to test:
    
    * The iterator previously returned from Next on encountering a hash
      node. This caused it to visit the same path twice.
    * Path returned nibbles with terminator symbol for valueNode attached
      to fullNode, but removed it for valueNode attached to shortNode. Now
      the terminator is always present. This makes Path unique to each node
      and simplifies Leaf.
    
    * trie: add Path to MissingNodeError
    
    The light client trie iterator needs to know the path of the node that's
    missing so it can retrieve a proof for it. NodeIterator.Path is not
    sufficient because it is updated when the node is resolved and actually
    visited by the iterator.
    
    Also remove unused fields. They were added a long time ago before we
    knew which fields would be needed for the light client.
Loading