Skip to content
  • Felix Lange's avatar
    5c8fe28b
    common: move big integer math to common/math (#3699) · 5c8fe28b
    Felix Lange authored
    * common: remove CurrencyToString
    
    Move denomination values to params instead.
    
    * common: delete dead code
    
    * common: move big integer operations to common/math
    
    This commit consolidates all big integer operations into common/math and
    adds tests and documentation.
    
    There should be no change in semantics for BigPow, BigMin, BigMax, S256,
    U256, Exp and their behaviour is now locked in by tests.
    
    The BigD, BytesToBig and Bytes2Big functions don't provide additional
    value, all uses are replaced by new(big.Int).SetBytes().
    
    BigToBytes is now called PaddedBigBytes, its minimum output size
    parameter is now specified as the number of bytes instead of bits. The
    single use of this function is in the EVM's MSTORE instruction.
    
    Big and String2Big are replaced by ParseBig, which is slightly stricter.
    It previously accepted leading zeros for hexadecimal inputs but treated
    decimal inputs as octal if a leading zero digit was present.
    
    ParseUint64 is used in places where String2Big was used to decode a
    uint64.
    
    The new functions MustParseBig and MustParseUint64 are now used in many
    places where parsing errors were previously ignored.
    
    * common: delete unused big integer variables
    
    * accounts/abi: replace uses of BytesToBig with use of encoding/binary
    
    * common: remove BytesToBig
    
    * common: remove Bytes2Big
    
    * common: remove BigTrue
    
    * cmd/utils: add BigFlag and use it for error-checked integer flags
    
    While here, remove environment variable processing for DirectoryFlag
    because we don't use it.
    
    * core: add missing error checks in genesis block parser
    
    * common: remove String2Big
    
    * cmd/evm: use utils.BigFlag
    
    * common/math: check for 256 bit overflow in ParseBig
    
    This is supposed to prevent silent overflow/truncation of values in the
    genesis block JSON. Without this check, a genesis block that set a
    balance larger than 256 bits would lead to weird behaviour in the VM.
    
    * cmd/utils: fixup import
    5c8fe28b
    common: move big integer math to common/math (#3699)
    Felix Lange authored
    * common: remove CurrencyToString
    
    Move denomination values to params instead.
    
    * common: delete dead code
    
    * common: move big integer operations to common/math
    
    This commit consolidates all big integer operations into common/math and
    adds tests and documentation.
    
    There should be no change in semantics for BigPow, BigMin, BigMax, S256,
    U256, Exp and their behaviour is now locked in by tests.
    
    The BigD, BytesToBig and Bytes2Big functions don't provide additional
    value, all uses are replaced by new(big.Int).SetBytes().
    
    BigToBytes is now called PaddedBigBytes, its minimum output size
    parameter is now specified as the number of bytes instead of bits. The
    single use of this function is in the EVM's MSTORE instruction.
    
    Big and String2Big are replaced by ParseBig, which is slightly stricter.
    It previously accepted leading zeros for hexadecimal inputs but treated
    decimal inputs as octal if a leading zero digit was present.
    
    ParseUint64 is used in places where String2Big was used to decode a
    uint64.
    
    The new functions MustParseBig and MustParseUint64 are now used in many
    places where parsing errors were previously ignored.
    
    * common: delete unused big integer variables
    
    * accounts/abi: replace uses of BytesToBig with use of encoding/binary
    
    * common: remove BytesToBig
    
    * common: remove Bytes2Big
    
    * common: remove BigTrue
    
    * cmd/utils: add BigFlag and use it for error-checked integer flags
    
    While here, remove environment variable processing for DirectoryFlag
    because we don't use it.
    
    * core: add missing error checks in genesis block parser
    
    * common: remove String2Big
    
    * cmd/evm: use utils.BigFlag
    
    * common/math: check for 256 bit overflow in ParseBig
    
    This is supposed to prevent silent overflow/truncation of values in the
    genesis block JSON. Without this check, a genesis block that set a
    balance larger than 256 bits would lead to weird behaviour in the VM.
    
    * cmd/utils: fixup import
Loading