1. 01 Mar, 2019 4 commits
  2. 28 Feb, 2019 2 commits
  3. 10 Aug, 2018 1 commit
  4. 24 Jul, 2018 3 commits
    • Ivan Jose Lozano Fernandez's avatar
      Changed the comments in the last commit (no relevant changes in the code). · b2cfdbab
      Ivan Jose Lozano Fernandez authored
      After looking into the code, I think the workaround (removing some Flags from ALL_VERIFY_FLAGS) is not a workaround, but a valid and needed change, in order to keep the existing functionality.
      
      Still, I consider that a deep research into the code is needed, in order to refactor all the uses of these Flags. Since these Flags affect the way the script is executed, the different invocations to the script engine should be aware of what flags are being used (as a parameter, for example). At this moment, these Flags are hardcoded, and that should not be the case (unless there is a clear consensus about that).
      
      The current commit runs OK and the legacy tests also run OK. But we should make it clear that ALL_VERIFY_FLAGS doen NOT measn ALL of them, just the ones that allow a "safe" script execution.
      b2cfdbab
    • Ivan Jose Lozano Fernandez's avatar
      Changed the comments regarding the ALL_VERIFY_FLAGS. · f42befcd
      Ivan Jose Lozano Fernandez authored
      After looking into the code, I think the workaround (removing some Flags from ALL_VERIFY_FLAGS) is not a workaround, but a valid and needed change, in order to keep the existing functionality.
      
      Still, I consider that a deep research into the code is needed, in order to refactor all the uses of these Flags. Since these Flags affect the way the script is executed, the different invocations to the script engine should be aware of what flags are being used 8as a parameter, for example). At this moment, these Flags are hardcoded, and that shouldn,t be the case. If we want to harcode the Verification Flags used when validating the script, then we shoul
      Still, I consider that a deep research into the code is needed, in order to refactor all the uses of these Flags. Since these Flags affect the way the script is executed, the different invocations to the script engine should be aware of what flags are being used 8as a parameter, for example). At this moment, these Flags are hardcoded in some places, and that shouldn't be the case (unles there is a clear consensus about that).
      
      The current commit runs OK and the legacy tests also run OK. But we should make it clear that ALL_VERIFY_FLAGS doen NOT measn ALL of them, just the ones that allow a "safe" script execution.
      f42befcd
    • Ivan Jose Lozano Fernandez's avatar
  5. 19 Jul, 2018 2 commits
  6. 18 Jul, 2018 1 commit
  7. 16 Jul, 2018 1 commit
  8. 13 Jul, 2018 26 commits