unit file tweaks
I was recently pointed to the libvirtd systemd service unit file (in the context of possible boottime optimizations). I noticed a few things I wanted to mention here, that might deserve some clean-up.
I am looking at this file:
https://gitlab.com/libvirt/libvirt/-/blob/master/src/remote/libvirtd.service.in#L19
The After=local-fs.target should be dropped, it has no effect. All regular services are ordered after this anyway, by default. (The only reason you might ever want to specify this is for special early boot services that set DefaultDependencies=no to turn off these deps, but libvirtd is certainly not like that).
The dep against machined and logind appears unnecessary to me. both services are bus activated, and if libvirtd talks to them it should not be necessary to syncrhonize explicitly against them because dbus will just wait for the services to be started on its own.
the two iptables deps are redundant too, because they are ordered before network-pre.target (as they should), and that's ordered before network.target, which you also order against. so that should be entirely enough, and the explicit deps gain you little, in particular as I think the two iptables units are fedora/rh specific. if you drop this you not only simplify the service but you also make it more distro agnostic at no loss.
the firewalld dep is the same story, please drop. firewalld orders itself correctly before network-pre.target hence you should be covered anyway.
hope this is useful