1. 10 May, 2019 1 commit
    • Laine Stump's avatar
      nwfilter: allow for different format of IPv6 netmask/prefix in ebtables output · 90664ac0
      Laine Stump authored
      The iptables-ebtables package is meant as a drop-in replacement for
      the native ebtables package, but it formats some items in the -L
      output differently, leading to failure of scripts that depend on the
      output of ebtables -L. In particular:
      
      with old ebtables IPv6 prefixes are output as a netmask (e.g.: "/ffff:fc00")
      
      with iptables-ebtables IPv6 prefixes are always output as a numeric
         prefix (e.g. "/22"), and suppressed completely if the prefix is
         /128.
      
      This difference is also described in
      https://bugzilla.redhat.com/show_bug.cgi?id=1674536
      
      "old" ebtables upstream has just accepted a patch to change its output
      to match that of iptables-ebtables:
      
      https://marc.info/?l=netfilter-devel&m=155000828923204&w=2
      
      so it makes sense for libvirt-tck to accept the new format (as well as
      the old). As with the patch for fixing up MAC addresses with leading
      0s, this patch also uses sed to apply a substitution to the scraped
      output of ebtables -L. However, rather than keeping the comparison
      (expected) output in the old (netmask) form, it is changed to the new
      (prefix) form, and the sed commands change netmasks to prefixes. (This
      works out better because in some cases we need to replace [all ff's]
      with "", and it's not possible to do that in the opposite direction)
      Signed-off-by: 's avatarLaine Stump <laine@laine.org>
      Reviewed-by: 's avatarDaniel P. Berrangé <berrange@redhat.com>
      90664ac0
  2. 09 May, 2019 2 commits
  3. 27 Feb, 2019 2 commits
  4. 13 Feb, 2019 1 commit
  5. 11 Feb, 2019 3 commits
  6. 24 Dec, 2018 3 commits
  7. 19 Nov, 2018 3 commits
  8. 19 Oct, 2018 3 commits
  9. 01 Oct, 2018 1 commit
  10. 26 Sep, 2018 1 commit
  11. 18 Sep, 2018 1 commit
  12. 09 Aug, 2018 1 commit
    • Jim Fehlig's avatar
      Cleanup secret in disk encryption test · 3836a38c
      Jim Fehlig authored
      100-disk-encryption.t does not undefine the secret it defines
      for the test disk, causing subsequent runs of the test to fail
      
      not ok 1 - secret created
       Failed test 'secret created'
       at /usr/share/libvirt-tck/tests/qemu/100-disk-encryption.t line 65.
      died: Sys::Virt::Error (libvirt error code: 1, message: internal error: a
      secret with UUID 212c459b-b02c-41fc-8ae2-714cc31612c5 is already defined
      for use with /var/cache/libvirt-tck/300-disk-encryption/demo.qcow2
      Signed-off-by: Jim Fehlig's avatarJim Fehlig <jfehlig@suse.com>
      Reviewed-by: 's avatarDaniel P. Berrangé <berrange@redhat.com>
      3836a38c
  13. 15 Jun, 2018 1 commit
    • Laine Stump's avatar
      network tests: change network address to avoid commonly-used subnet · 3ecb368e
      Laine Stump authored
      My own machine has a virtual network on 192.168.123.0/24, and I've
      been told that it's a common selection for people who create a second
      network after libvirt's default (and in the past was used as a manual
      alternative for the default network itself when 192.168.122.0/24
      casued a conflict). Changing to 192.168.97.0/24 also isn't foolproof,
      but it's much less likely to encounter a conflict leading to a failed
      test.
      
      Signed-off-by: Laine Stump <laine@laine.org
      Reviewed-by: 's avatarDaniel P. Berrangé <berrange@redhat.com>
      3ecb368e
  14. 14 Jun, 2018 1 commit
    • Laine Stump's avatar
      scripts: shorten netdev/domain name to prevent overflow · db9c604f
      Laine Stump authored
      When new pids are more than 9 digits long
      
      The nwfilter tests use tck-test${pid} as the auto-generated name for
      their test domains (and therefore the tap devices created for those
      test domains). When the pid is > 9 digits long, the total length of
      the name is > 16, which is the maximum length for any network device
      name (IFNAMSIZ), and this causes failure to create the tap device,
      thus failure of the test:
      
        /home/laine/devel/libvirt-tck/scripts/nwfilter/050-apply-verify-host.t ..
        error: Failed to start domain tck-test10513851
        error: Network interface name 'tck-test10513851' is too long:
               Numerical result out of range
      
      The solution is to just remove "test" from the name template, so pid
      can be up to 12 digits long before the test fails.
      
      Signed-off-by: Laine Stump <laine@laine.org
      Reviewed-by: 's avatarDaniel P. Berrangé <berrange@redhat.com>
      db9c604f
  15. 11 Jun, 2018 7 commits
  16. 08 Jun, 2018 9 commits