1. 04 Jun, 2018 8 commits
  2. 01 Jun, 2018 3 commits
  3. 17 May, 2018 1 commit
  4. 16 May, 2018 1 commit
  5. 09 May, 2018 3 commits
  6. 24 Apr, 2018 1 commit
    • Daniel P. Berrangé's avatar
      git: add config file telling git-publish how to send patches · 281e8099
      Daniel P. Berrangé authored
      The "git-publish" tool is a useful git extension for sending patch
      series for code review. It automatically creates versioned tags
      each time code on a branch is sent, so that there is a record of
      each version. It also remembers the cover letter so it does not
      need re-entering each time the series is reposted.
      With this config file present it is now sufficient[1] to run
        $ git publish
      to send all patches in a branch to the list for review, with the
      correct subject prefix added for this non-core libvirt module.
      [1] Assuming your $HOME/.gitconfig has an SMTP server listed
      at least e.g.
              smtpserver = smtp.example.com
      Signed-off-by: 's avatarDaniel P. Berrangé <berrange@redhat.com>
  7. 26 Mar, 2018 1 commit
    • Laine Stump's avatar
      require libguestfs-tool package · b7e7af5d
      Laine Stump authored
      The nwfilter tests use virt-builder to download and configure a guest
      appliance, but we don't require the libguestfs-tools package. Up until
      now it's just happened that it was always already installed on the
      test systems, so it wasn't a problem, but it's annoying to have to
      type the one extra install command when setting up a new machine to
      run the tests.
      Signed-off-by: 's avatarLaine Stump <laine@laine.org>
      Reviewed-by: 's avatarErik Skultety <eskultet@redhat.com>
  8. 06 Mar, 2018 7 commits
  9. 20 Feb, 2018 1 commit
  10. 09 Feb, 2018 5 commits
  11. 08 Feb, 2018 6 commits
    • Laine Stump's avatar
      Eliminate unnecessary path specifications in binary names · d6ab2540
      Laine Stump authored
      The root account in the Fedora image used for the tests has a properly
      specified path, so the extra verbiage just clutters up the screen.
      Signed-off-by: 's avatarLaine Stump <laine@laine.org>
      Reviewed-by: 's avatarDaniel P. Berrange <berrange@redhat.com>
    • Laine Stump's avatar
      Fix ebtables check in no-mac-broadcast test · 88f78226
      Laine Stump authored
      Once the correct filter is enabled for the no-mac-broadcast test, the
      original test to validate ebtables rules is no longer correct - it was
      checking for the presence of the test guest's MAC address in the
      ebtables output on the host, but the no-mac-broadcast filter doesn't
      have the guest's MAC address anywhere. This patch changes the code to
      look for "-d Broadcast -j DROP", which actually is added to ebtables
      for no-mac-broadcast.
      Signed-off-by: 's avatarLaine Stump <laine@laine.org>
      Reviewed-by: 's avatarDaniel P. Berrange <berrange@redhat.com>
    • Laine Stump's avatar
      Fix no-arp-spoof test script generation · acb98419
      Laine Stump authored
      I'm not sure if or how this ever worked before - what is supposed to
      happen is that the shell script in $cmdfile is put into the file
      /test.sh on the guest, then /test.sh is executed. But the code was
      instead trying to directly execute the text of the entire script as a
      single command and write the generated output to /test.sh, then
      execute that.
      putting echo " ..... " around the whole thing fixed it.
      Signed-off-by: 's avatarLaine Stump <laine@laine.org>
      Reviewed-by: 's avatarDaniel P. Berrange <berrange@redhat.com>
    • Laine Stump's avatar
      Use Net::OpenSSH instead of Net::SSH::Perl · b7456d66
      Laine Stump authored
      Net::SSH::Perl is out of date in the Fedora git repos. The version
      currently supported in Fedora fails to connect to most modern sshd's,
      and updating to the new version would require adding several new perl
      packages to Fedora. Instead, this patch switches to using
      Net::OpenSSH, whose current version in Fedora works properly *EXCEPT*
      that it is missing the line "Requires: perl(IO:TTy)" in its specfiles
      (I filed https://bugzilla.redhat.com/1542666 requesting that fix to be
      applied to Fedora git repos. For now, just run "dnf install
      perl-IO-Tty" separately)
      NB: prior to this patch, Net::SSH::Perl was required, but had no
      Required: line in the specfile, so you would have to install it by
      hand. If you had done that, you can probably now dnf erase it.
      Signed-off-by: 's avatarLaine Stump <laine@laine.org>
      Reviewed-by: 's avatarDaniel P. Berrange <berrange@redhat.com>
    • Laine Stump's avatar
      Use $net->get_dhcp_leases() when available · 433f7f78
      Laine Stump authored
      Newer versions of libvirt no longer let dnsmasq create a leases file,
      they keep track of it themselves and provide an API to retrieve the
      current list of leases. Use that to get the guest's IP address when
      it's available.
      Signed-off-by: 's avatarLaine Stump <laine@laine.org>
      Reviewed-by: 's avatarDaniel P. Berrange <berrange@redhat.com>
    • Laine Stump's avatar
      create vms that use virt-builder images with no graphics and virtio-net · 2299d168
      Laine Stump authored
      This is consistent with what is used to create the disk image supplied
      by virt-builder. It doesn't currently affect the outcome of the test,
      but it's possible that in the future it could.
      In particular, the network device name changes depending on whether or
      not there is a graphics device (due to change in PCI address). The
      virt-builder image is create by installing Fedora on a guest that has
      no graphics card, so it sees the network device as "ens2" and creates
      an appropriate ifcfg-ens2, but if you boot the image with a graphics
      card, then the network device will be named "ens3". It turns out that
      NetworkManager is enabled by default on the virt-builder images, and
      NetworkManager will listen for dhcp on *all* interfaces (not just
      those with a configuration file), so networking still functions on the
      guest, but if a test script were to try to use "ifdown ens3" (for
      example) that wouldn't work.
      The best solution may be to have the image set "biosdevnames=0
      net.ifnames=0" on the kernel commandline (so that the netdev is always
      called "eth0" regardless of its PCI address), but that would also need
      to be done in the kickstart file used to create the image, which is
      done offline by libguestfs people, so it's not something we have
      control over here.
      Signed-off-by: 's avatarLaine Stump <laine@laine.org>
      Reviewed-by: 's avatarDaniel P. Berrange <berrange@redhat.com>
  12. 06 Feb, 2018 1 commit
  13. 24 Jan, 2018 2 commits