Commit db9c604f authored by Laine Stump's avatar Laine Stump

scripts: shorten netdev/domain name to prevent overflow

When new pids are more than 9 digits long

The nwfilter tests use tck-test${pid} as the auto-generated name for
their test domains (and therefore the tap devices created for those
test domains). When the pid is > 9 digits long, the total length of
the name is > 16, which is the maximum length for any network device
name (IFNAMSIZ), and this causes failure to create the tap device,
thus failure of the test:

  /home/laine/devel/libvirt-tck/scripts/nwfilter/050-apply-verify-host.t ..
  error: Failed to start domain tck-test10513851
  error: Network interface name 'tck-test10513851' is too long:
         Numerical result out of range

The solution is to just remove "test" from the name template, so pid
can be up to 12 digits long before the test fails.

Signed-off-by: Laine Stump <laine@laine.org
Reviewed-by: 's avatarDaniel P. Berrangé <berrange@redhat.com>
parent b3b332b2
...@@ -638,8 +638,8 @@ main() { ...@@ -638,8 +638,8 @@ main() {
cd "${curdir}" || { echo "cd failed" >&2; exit 1; } cd "${curdir}" || { echo "cd failed" >&2; exit 1; }
fi fi
vm1="tck-test$$1" vm1="tck-$$1"
vm2="tck-test$$2" vm2="tck-$$2"
createTestFilters "${flags}" createTestFilters "${flags}"
if [ $? -ne 0 ]; then if [ $? -ne 0 ]; then
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment