You need to sign in or sign up before continuing.
Commits on Source (34)
-
Jiri Denemark authoredSigned-off-by:Jiri Denemark <jdenemar@redhat.com>
50236621 -
Erik Skultety authored
We're not good at tracking all the released Python 3 versions (+ we don't support Python 2 anymore). Additionally, future patches will take care of reporting the minimum required version of Python anyway through the 'python_requires' field which shows up correctly in PyPI. Signed-off-by:Erik Skultety <eskultet@redhat.com>
90bf275b -
Erik Skultety authored
3.6 is already EOL, but many platforms still default to Python 3.6 when it comes to the default platform Python package. Since we don't rely on any 3.7+ features in the bindings at the moment, let's keep everyone's life simpler and stay with 3.6 for now, we can bump it again in the future. Signed-off-by:fa96143b -
Erik Skultety authored
First go general, whole module imports, then specific symbol imports. Signed-off-by:5a7ad288 -
Erik Skultety authored
2 newlines in between classes/functions, 1 newline in between methods. Signed-off-by:35182909 -
Erik Skultety authored
Let's standardize on usage of one and be consistent with it. Signed-off-by:df801ceb -
Erik Skultety authored
Signed-off-by:e418191c -
Erik Skultety authored
Signed-off-by:745e5a8c -
Erik Skultety authored
Signed-off-by:ad6a3343 -
Erik Skultety authored
It hinders readability so much when the top-level code that gets executed right away when setup.py is loaded is mixed in between type definitions. Signed-off-by:8c9bc5d2 -
Erik Skultety authored
Drops usage of the glob module along the way as pathlib integrates glob as well. Signed-off-by:e749b4cf -
Erik Skultety authored
We don't need to do both None/non-None checks on the returned string. Signed-off-by:cd936c1f -
Erik Skultety authored
The correct license we've used for a while is LGPLv2+, so drop the original. Signed-off-by:5e2d7df5 -
Erik Skultety authored
Commit 60044515 renamed sanitytest to test_coverage_api but forgot to update the tox.ini file. Fixes: 60044515 Signed-off-by:
724a3051 -
Erik Skultety authored
Signed-off-by:115b1de8 -
Erik Skultety authored
Fix a few more occurrences. Fixes: 745e5a8c Signed-off-by:
583203c9 -
Erik Skultety authored
subprocess is the high-level Pythonic interface providing more flexibility over the low-level os.popen stuff. It is recommended to always use subprocess over the direct 'os' interface. Signed-off-by:d1cf5066 -
Erik Skultety authored
Some of the operations, namely file operations and spawning processes can utilize the power of context managers. Use them more, use them together. Signed-off-by:910079e4 -
Erik Skultety authored
The code is almost identical in the impacted cases, so factor it out. Signed-off-by:8ba4e9d6 -
Erik Skultety authored
No need to do that since we'll create it in the top-level code as a first thing anyway. Signed-off-by:28d620c3 -
Erik Skultety authored
Commit e749b4cf forgot to update a couple more occurrences. Fixes: e749b4cf Signed-off-by:
3ffb60b7 -
Erik Skultety authored
- bump OpenSUSE Leap 15.4 -> 15.5 - add python3-build dependency (PEP-517) - add python3-venv dependency (PEP-517) Signed-off-by:10f0ad6c -
Erik Skultety authored
When migrated to the PEP-517 compliant builds, some errors occurred due to missing or non-existent files mentioned in the MANIFEST. Notable changes: - README and MANIFEST files are automatically added to sdist per MANIFEST documentation - we want all tests/examples to be included, so use the 'graft' keyword instead of enumerating individual files - we want all *.[ch] files as those are needed for the build, so use 'include *.[ch]' instead of enumerating individual files - we want all *.xml files, so use 'include *.xml' - we want all *.py files - in case this is no longer the case in the future, we'll need to tweak that 'include' - we don't want any __pycache__ nor *.pyc build artifacts, so exclude them globally Signed-off-by:e0bf78cf -
Erik Skultety authored
Signed-off-by:68c9acbd -
Erik Skultety authored
So, why using setup.cfg if pyproject.toml is the new best thing recommended everywhere? Well, quite a few of the fields we use with setuptools are setuptools-specific and haven't been introduced as keywords to pyproject.toml yet. There is a chance that these fields could be added via a dedicated 'tool.setuptools' TOML section, but none of it is officially documented and so it would be BETA at best anyway. Let's not try our luck and use a declarative config file tailored specifically to setuptools - setup.cfg. It's also unlikely we'd switch from setuptools to something else in the near future given the nature of building this project (i.e. building with C modules) and if so, it would likely not be a PyPa recommended PEP-517 compliant build system anyway, e.g. meson, so we're totally fine doing this. Signed-off-by:8c3eb736 -
Erik Skultety authored
This makes it possible to programatically query the version in any stage of the build process, including Makefile etc. Signed-off-by:390cadcc -
Erik Skultety authored
- drop direct setup.py invocations - clean the artifacts directly with 'rm' - use tox instead of invoking pytest otherwise we don't have a mechanism to test against the freshly built libvirt modules other than unpacking the built wheel and mangling the PYTHONPATH again - use direct rpmbuild invocation to build RPM (the rpm target in its current form didn't really work anyway) Signed-off-by:72ad0434 -
Erik Skultety authored
This one should be used for the "full" test experience including any additional environments, test suites and linters we may introduce further down the road. Signed-off-by:01ac61c5 -
Erik Skultety authored
Given the missing setuptools keywords issue and hence having moved all the declarative stuff to setup.cfg this one is only a very basic one just to comply PEP-517 and foolproof this project for the future PyPa/pip changes. Signed-off-by:b8656c12 -
Erik Skultety authored
Direct setup.py invocations are discouraged anyway, use git clean or 'make clean' instead. Signed-off-by:aeb62b08 -
Erik Skultety authored
Direct setup.py invocations are being discouraged in favour of using Python's 'build' module. Therefore, we can't really make use of this command anymore since only wheels and tarballs are built with the 'build' module compared to the previous state of the art of dumping the freshly built modules and libraries directly inside the build directory. We'll have to encourage usage of tox which will install the package inside a virtualenvironment for the tests. Future patch will update the Makefile targets to make this easier for the end users. Signed-off-by:1baa0870 -
Erik Skultety authored
With all the bits in place we can now drop the 'setup.py' invocations with preferred alternatives. The way to do this in a SPEC file is to use either of the following macros: %tox or %pytest - both of which automatically set paths for the test suite correctly which is something we used to do ourselves in our implementation of the setup.py's test command originally. That is wrong and with the migration to PEP-517 compliant builds it also won't work anymore properly, because there'd be no libs to import by mangling PYTHONPATH, we'd only get an sdist or a wheel, or in case of rpmbuild a preset buildroot environment. Signed-off-by:8d89f932 -
Erik Skultety authored
With all the bits in place we can now drop the 'setup.py' invocations with preferred alternatives. This patch does a few things: - we don't run plain install because that always spins up a new build process regardless of whether there are build artifacts literally from the previous command, so instead we install the built wheel directly - when building, we build both the .whl binary and an sdist because we'll need the sdist for rpmbuild later in the CI job - we don't capture the 'build' path as a job artifact anymore, because that now only contains egg metadata, all the build artifacts are created by Python's build module under 'dist' so we capture that one instead - we always limit pytest to the 'tests' directory which was something 'setup.py test' used to do as a precaution measure, but setup.py no longer has the logic (which is fine) Signed-off-by:333c8bef -
Erik Skultety authored
With all the bits in place we can now replace the direct 'setup.py' invocation examples with alternatives. Signed-off-by:b957ee3d
This diff is collapsed.
COPYING.LESSER
deleted
100644 → 0
This diff is collapsed.
VERSION
0 → 100644