1. 02 Oct, 2015 8 commits
  2. 01 Oct, 2015 6 commits
  3. 30 Sep, 2015 3 commits
    • Michal Privoznik's avatar
      examples: Resolve some warnings · 66efb192
      Michal Privoznik authored
      So, I have a couple of networks and while testing the examples
      I've noticed that there are some warnings being printed out:
      
      [Wed Sep 30 15:53:13 2015] PHP Notice:  Undefined index: forward_dev in /home/zippy/work/libvirt/libvirt-php.git/examples/index.php on line 283
      [Wed Sep 30 15:53:13 2015] PHP Notice:  Undefined index: forward_dev in /home/zippy/work/libvirt/libvirt-php.git/examples/index.php on line 283
      [Wed Sep 30 15:53:13 2015] PHP Notice:  Undefined index: forward_dev in /home/zippy/work/libvirt/libvirt-php.git/examples/index.php on line 283
      [Wed Sep 30 15:53:13 2015] PHP Notice:  Undefined index: ip in /home/zippy/work/libvirt/libvirt-php.git/examples/index.php on line 303
      [Wed Sep 30 15:53:13 2015] PHP Notice:  Undefined index: ip_range in /home/zippy/work/libvirt/libvirt-php.git/examples/index.php on line 304
      
      Make the code work with missing info
      Signed-off-by: 's avatarMichal Privoznik <mprivozn@redhat.com>
      66efb192
    • Michal Privoznik's avatar
      libvirt_network_get_information: Be more tolerant to missing info · 2de29d90
      Michal Privoznik authored
      This function is really build in a way that only NATed networks
      can pass the function. Any other networks (and there's plenty of
      them) will make it fail immediately. So while we are in PHP, we
      can utilize array_key_exist() function and thus just fill just
      those info that we know for now.
      Signed-off-by: 's avatarMichal Privoznik <mprivozn@redhat.com>
      2de29d90
    • Vasiliy Tolstov's avatar
      free xml resources in get_string_from_xpath · 73444c71
      Vasiliy Tolstov authored
      free as much as possible on return from get_string_from_xpath
      Signed-off-by: Vasiliy Tolstov's avatarVasiliy Tolstov <v.tolstov@selfip.ru>
      Signed-off-by: 's avatarMichal Privoznik <mprivozn@redhat.com>
      73444c71
  4. 19 Aug, 2015 1 commit
  5. 06 Aug, 2015 1 commit
  6. 29 Jun, 2015 1 commit
  7. 26 Jun, 2015 9 commits
  8. 22 Jun, 2015 1 commit
  9. 19 Jun, 2015 4 commits
    • Michal Privoznik's avatar
      libvirt_stream_close: Pass the actual connect object · cbc5512b
      Michal Privoznik authored
      There's a bug in the function. When closing a stream, the stream
      refcount should be decremented. We have a helper function for that
      which (among others) take a virConnectPtr as an argument. However,
      we are passing an internal representation of the virConnect.
      Even gcc warns about this:
      
      libvirt-php.c: In function ‘zif_libvirt_stream_close’:
      libvirt-php.c:3748:47: warning: passing argument 2 of ‘resource_change_counter’ from incompatible pointer type
        resource_change_counter(INT_RESOURCE_STREAM, stream->conn, stream->stream, 0 TSRMLS_CC);
                                                     ^
      libvirt-php.c:470:5: note: expected ‘virConnectPtr’ but argument is of type ‘struct php_libvirt_connection *’
       int resource_change_counter(int type, virConnectPtr conn, void *memp, int inc TSRMLS_DC)
           ^
      Signed-off-by: 's avatarMichal Privoznik <mprivozn@redhat.com>
      cbc5512b
    • Michal Privoznik's avatar
      generate-api-docs: Adapt to new comments style · 7e9d7f78
      Michal Privoznik authored
      Previously, it assumed that there's only one star at the
      beginning of the comment block and one at the end. The usual C
      comment style. Now that I reformatted the comments every line
      starts with a star. Update the docs generator to reflect this.
      Signed-off-by: 's avatarMichal Privoznik <mprivozn@redhat.com>
      7e9d7f78
    • Michal Privoznik's avatar
      generate-api-docs.c: :retab · fbf672a5
      Michal Privoznik authored
      Let's not use tabs but spaces instead. This way the formatting
      will be consistent no matter how big tab skips are.
      Moreover, at the same time, reformat the code a bit to be more
      readable.
      Signed-off-by: 's avatarMichal Privoznik <mprivozn@redhat.com>
      fbf672a5
    • Michal Privoznik's avatar
      libvirt-php.h: :retab · f4f88861
      Michal Privoznik authored
      Let's not use tabs but spaces instead. This way the formatting
      will be consistent no matter how big tab skips are.
      Signed-off-by: 's avatarMichal Privoznik <mprivozn@redhat.com>
      f4f88861
  10. 17 Jun, 2015 1 commit
  11. 16 Jun, 2015 2 commits
  12. 15 Jun, 2015 3 commits