1. 09 Jun, 2020 1 commit
  2. 08 Jun, 2020 5 commits
  3. 05 May, 2020 6 commits
  4. 30 Apr, 2020 1 commit
  5. 24 Apr, 2020 4 commits
  6. 16 Apr, 2020 3 commits
  7. 07 Apr, 2020 1 commit
    • Daniel Berrange's avatar
      github: enable lockdown of issues and merge requests · aeb79480
      Daniel Berrange authored
      Libvirt uses GitHub as an automated read-only mirror. The goals were to
      have a disaster recovery backup for libvirt.org, a way to make it easy
      for people to clone their own private copy of libvirt Git, and finally
      as a way to interact with apps like Travis.
      The project description was set to a message telling people that we
      don't respond to pull requests. This was quite a negative message to
      potential contributors, and also did not give them any guidance about
      the right way to submit to libvirt. Many also missed the description and
      submitted issues or pull requests regardless.
      It is possible to disable the issue tracker in GitHub, but there is no
      way to disable merge requests. Disabling the issue tracker would also
      leave the problem of users not being given any positive information
      about where they should be reporting instead.
      There is a fairly new 3rd party application built for GitHub that
      provides a bot which auto-responds to both issues and merge requests,
      closing and locking them, with a arbitrary comment:
      This commit adds a suitable configuration file for libvirt, which
      tries to give a positive response to user's issue/pullreq and guide
      them to the desired contribution path on GitLab.
      Reviewed-by: Andrea Bolognani's avatarAndrea Bolognani <[email protected]>
      Reviewed-by: Pavel Hrdina's avatarPavel Hrdina <[email protected]>
      Reviewed-by: Eric Blake's avatarEric Blake <[email protected]>
      Signed-off-by: Daniel Berrange's avatarDaniel P. Berrangé <[email protected]>
  8. 08 Feb, 2020 2 commits
  9. 07 Feb, 2020 1 commit
  10. 17 Jan, 2020 1 commit
  11. 16 Jan, 2020 1 commit
  12. 30 Dec, 2019 1 commit
    • Michal Privoznik's avatar
      libvirt-php: Simplify querying for emulator path · a2fc80ce
      Michal Privoznik authored
      There's this function called connection_get_emulator() which is
      supposed to return emulator path for given architecture (or for
      the host architecture if none given). It does this by querying
      capabilities. Twice. The first time it looks at some bogus XPath
      (that never existed), and if that fails, it tries to look at the
      correct XPath location. Remove the first attempt which will never
      succeed and only burns CPU cycles.
      Signed-off-by: default avatarMichal Privoznik <[email protected]>
  13. 06 Dec, 2019 1 commit
    • Michal Privoznik's avatar
      libvirt-domain: Switch to modern domain listing API · 52ba9562
      Michal Privoznik authored
      For listing domains, we offer libvirt_list_domains(),
      libvirt_list_active_domain_ids(), libvirt_list_active_domains()
      and finally libvirt_list_inactive_domains(). All of these are
      using the old, racy APIs to list domains. Switch them to use
      virConnectListAllDomains() which list domains in desired state in
      one go.
      Signed-off-by: default avatarMichal Privoznik <[email protected]>
  14. 03 Aug, 2019 3 commits
  15. 02 Aug, 2019 2 commits
    • Michal Privoznik's avatar
      libvirt_domain_disk_remove: Fix disk detach · f45b3404
      Michal Privoznik authored
      Thing is that we need to pass full device XML as mandated by
      virDomainDetachDeviceFlags() API. So far we are not doing that.
      We construct a minimalistic <disk/> XML and hope for the best.
      Use freshly introduce get_node_string_from_xpath() to get disk
      XML from the domain XML.
      Also, fix a copy/paste error in the error message that is
      produced when detach fails.
      Signed-off-by: default avatarMichal Privoznik <[email protected]>
    • Michal Privoznik's avatar
      libvirt-php: Introduce get_node_string_from_xpath() · cd5c11d3
      Michal Privoznik authored
      So far we have get_string_from_xpath() which works in most cases,
      but it is no good for the next commit. Problem with
      get_string_from_xpath() is that it immediately converts the
      result using xmlNodeListGetString() which is like wrapping xpath
      into string() like this: "string(xpath)". While this works in
      most cases when we query for just an attribute value it fails
      when we want to stringify whole node. Introduce
      get_node_string_from_xpath() which does exactly that.
      Signed-off-by: default avatarMichal Privoznik <[email protected]>
  16. 15 Jul, 2019 2 commits
  17. 24 Apr, 2018 1 commit
    • Daniel Berrange's avatar
      git: add config file telling git-publish how to send patches · 8626cb01
      Daniel Berrange authored
      The "git-publish" tool is a useful git extension for sending patch
      series for code review. It automatically creates versioned tags
      each time code on a branch is sent, so that there is a record of
      each version. It also remembers the cover letter so it does not
      need re-entering each time the series is reposted.
      With this config file present it is now sufficient[1] to run
        $ git publish
      to send all patches in a branch to the list for review, with the
      correct subject prefix added for this non-core libvirt module.
      [1] Assuming your $HOME/.gitconfig has an SMTP server listed
      at least e.g.
              smtpserver = smtp.example.com
      Signed-off-by: Daniel Berrange's avatarDaniel P. Berrangé <[email protected]>
  18. 11 Dec, 2017 4 commits